[close #749] Fix health checking issue (#748)#753
Merged
shiyuhang0 merged 2 commits intotikv:release-3.3from May 31, 2023
Merged
[close #749] Fix health checking issue (#748)#753shiyuhang0 merged 2 commits intotikv:release-3.3from
shiyuhang0 merged 2 commits intotikv:release-3.3from
Conversation
Collaborator
|
LGTM |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-3.3 #753 +/- ##
==============================================
Coverage ? 37.90%
Complexity ? 1610
==============================================
Files ? 278
Lines ? 17511
Branches ? 1991
==============================================
Hits ? 6637
Misses ? 10211
Partials ? 663 ☔ View full report in Codecov by Sentry. |
shiyuhang0
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #748
What problem does this PR solve?
Issue Number: close #749
pingcap/tispark#2707
Problem Description: StoreHealthyChecker fails to check the status of TiFlash
What is changed and how does it work?
Use isMppalive RPC to probe the status of TiFlash.
Check List for Tests
Manual test:
I have tested this locally with TiSpark. TiSpark will request TiFlash using client-java
Side effects
Related changes