[close #749] Fix health checking issue#748
Merged
zhangyangyu merged 6 commits intotikv:masterfrom May 25, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
============================================
- Coverage 38.15% 37.92% -0.23%
+ Complexity 1614 1611 -3
============================================
Files 278 278
Lines 17493 17511 +18
Branches 1989 1991 +2
============================================
- Hits 6674 6641 -33
- Misses 10149 10210 +61
+ Partials 670 660 -10
☔ View full report in Codecov by Sentry. |
xuanyu66
previously approved these changes
May 22, 2023
b210473 to
b14abce
Compare
iosmanthus
reviewed
May 24, 2023
iosmanthus
previously approved these changes
May 24, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
7f844f5 to
c08ea89
Compare
shiyuhang0
added a commit
to shiyuhang0/client-java
that referenced
this pull request
May 25, 2023
shiyuhang0
added a commit
that referenced
this pull request
May 31, 2023
* optimize getregionstore logical Signed-off-by: shiyuhang <1136742008@qq.com> * decrease impact Signed-off-by: shiyuhang <1136742008@qq.com> * Update RegionManager.java Signed-off-by: shiyuhang <1136742008@qq.com> * [close #749] Fix health checking issue (#748) Signed-off-by: shiyuhang <1136742008@qq.com> * Update RegionManager.java Signed-off-by: shiyuhang <1136742008@qq.com> * add log Signed-off-by: shiyuhang <1136742008@qq.com> * change log level Signed-off-by: shiyuhang <1136742008@qq.com> --------- Signed-off-by: shiyuhang <1136742008@qq.com>
Collaborator
Author
|
/cherry-pick release-3.3 |
ti-chi-bot
pushed a commit
to ti-chi-bot/client-java
that referenced
this pull request
May 31, 2023
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/client-java
that referenced
this pull request
May 31, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/client-java
that referenced
this pull request
May 31, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0
added a commit
that referenced
this pull request
May 31, 2023
* optimize getregionstore logical Signed-off-by: shiyuhang <1136742008@qq.com> * decrease impact Signed-off-by: shiyuhang <1136742008@qq.com> * Update RegionManager.java Signed-off-by: shiyuhang <1136742008@qq.com> * Fix health checking issue (#748) Signed-off-by: shiyuhang <1136742008@qq.com> * Update RegionManager.java Signed-off-by: shiyuhang <1136742008@qq.com> * add log Signed-off-by: shiyuhang <1136742008@qq.com> * change log level Signed-off-by: shiyuhang <1136742008@qq.com> --------- Signed-off-by: shiyuhang <1136742008@qq.com> Co-authored-by: shiyuhang <1136742008@qq.com> Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
shiyuhang0
added a commit
that referenced
this pull request
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #749
pingcap/tispark#2707
Problem Description: StoreHealthyChecker fails to check the status of TiFlash
What is changed and how does it work?
Use isMppalive RPC to probe the status of TiFlash.
Check List for Tests
Manual test:
I have tested this locally with TiSpark. TiSpark will request TiFlash using client-java
Side effects
Related changes