Support grpc forward by Little-Wallace · Pull Request #198 · tikv/client-java

Little-Wallace · 2021-06-16T07:47:20Z

What problem does this PR solve?

When TiKV cluster deploy in three IDC A/B/C, if there is network isolation between the A and B, the message which should be send to leader in A can be forward by B.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

MyonKeminta · 2021-06-16T08:04:19Z

src/main/java/org/tikv/common/TiConfiguration.java

    setIfMissing(TIKV_METRICS_ENABLE, DEF_METRICS_ENABLE);
    setIfMissing(TIKV_METRICS_PORT, DEF_METRICS_PORT);
    setIfMissing(TIKV_NETWORK_MAPPING_NAME, DEF_TIKV_NETWORK_MAPPING_NAME);
+    setIfMissing(TIKV_ENABLE_GRPC_FORWARD, false);


Looks like you'd better define a DEF_ENABLE_GRPC_FORWARD

MyonKeminta · 2021-06-16T08:40:51Z

src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java

+      if (checkHealth(store)) {
+        return true;
+      } else {
+        store.invalid();


Does the function invalid actually means invalidate?

MyonKeminta · 2021-06-16T09:04:33Z

src/main/java/org/tikv/common/TiConfiguration.java


  private static final Logger logger = LoggerFactory.getLogger(TiConfiguration.class);
  private static final ConcurrentHashMap<String, String> settings = new ConcurrentHashMap<>();
+  public static final Metadata.Key FORWARD_META_DATA_KEY =


Suggested change

public static final Metadata.Key FORWARD_META_DATA_KEY =

public static final Metadata.Key FORWARD_METADATA_KEY =

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

birdstorm

LGTM

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

MyonKeminta · 2021-06-18T05:21:22Z

src/main/java/org/tikv/common/ConfigUtils.java

  public static final boolean DEF_METRICS_ENABLE = false;
  public static final int DEF_METRICS_PORT = 3140;
  public static final String DEF_TIKV_NETWORK_MAPPING_NAME = "";
+  public static final boolean DEF_GRPC_FORWARD_ENABLE = true;


Why enable by default?

MyonKeminta

Rest LGTM, but I'm not very confident. Please confirm it works by tests.

MyonKeminta · 2021-06-18T06:15:04Z

src/main/java/org/tikv/common/region/UnreachableStoreChecker.java

+    TiStore oldStore = this.stores.get(Long.valueOf(store.getId()));
+    if (oldStore != null) {
+      return;
+    }
+    synchronized (this.taskQueue) {
+      this.stores.put(Long.valueOf(store.getId()), store);
+      this.taskQueue.add(store);
+    }


Is this function possible to be called concurrently? May it be a race that multiple threads do the check-and-insert-if-not-exist operation at the same time?

MyonKeminta · 2021-06-18T06:22:34Z

src/main/java/org/tikv/common/region/UnreachableStoreChecker.java

+          continue;
+        }
+      } finally {
+      }


What's the purpose of the try-finally?

MyonKeminta · 2021-06-18T06:29:58Z

src/main/java/org/tikv/common/region/UnreachableStoreChecker.java

+    List<TiStore> unhealthStore = getUnhealthStore();
+    List<TiStore> restStore = new LinkedList<>();
+    for (TiStore store : unhealthStore) {
+      String addressStr = store.getStore().getAddress();


Did you check if the store becomes tombstone?

No, the store will not be tombstone after it was created. Because it is a final object.

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-06-23T06:35:28Z

cherry pick to release-3.1 in PR #208

* support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

* support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: birdstorm <samuelwyf@hotmail.com>

* Support grpc forward (#198) * support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: birdstorm <samuelwyf@hotmail.com> * fix compile Signed-off-by: birdstorm <samuelwyf@hotmail.com> Co-authored-by: Wallace <bupt2013211450@gmail.com> Co-authored-by: birdstorm <samuelwyf@hotmail.com>

Little-Wallace added 3 commits June 15, 2021 21:42

refactor kverrorhandler

e1ec2b5

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

add parameter store

bc8ce39

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

support grpc forward for tikv client

2c0492b

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

MyonKeminta reviewed Jun 16, 2021

View reviewed changes

Little-Wallace added 2 commits June 16, 2021 20:26

check health periodly

0237ac5

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Merge branch 'master' into grpc

9431bd3

birdstorm approved these changes Jun 17, 2021

View reviewed changes

ti-srebot added the status/LGT1 label Jun 17, 2021

Little-Wallace added 3 commits June 17, 2021 22:05

fix null pointer bug

5759e25

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Merge branch 'grpc' of github.com:Little-Wallace/client-java into grpc

305c203

fix some bug

403c1ed

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

MyonKeminta reviewed Jun 18, 2021

View reviewed changes

fix some bug

b7fd0de

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

MyonKeminta approved these changes Jun 18, 2021

View reviewed changes

ti-srebot added status/LGT2 and removed status/LGT1 labels Jun 18, 2021

ti-srebot approved these changes Jun 18, 2021

View reviewed changes

Little-Wallace added 3 commits June 18, 2021 16:24

address comment

000e6fb

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

refactor checker

7953a2e

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

try storeunreachable first

e70177f

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

Little-Wallace merged commit 5815678 into tikv:master Jun 18, 2021

marsishandsome mentioned this pull request Jun 22, 2021

[BUG] JVM does not exit after this PR https://github.com/tikv/client-java/pull/198 #205

Closed

birdstorm added the needs-cherry-pick-3.1 label Jun 23, 2021

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Jun 23, 2021

cherry pick tikv#198 to release-3.1

a2f5d62

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Jun 23, 2021

Support grpc forward (#198) #208

Merged

birdstorm pushed a commit to ti-srebot/client-java that referenced this pull request Jun 23, 2021

Support grpc forward (tikv#198)

239838a

* support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

birdstorm pushed a commit to ti-srebot/client-java that referenced this pull request Jun 23, 2021

Support grpc forward (tikv#198)

374ae9e

* support grpc forward for tikv client Signed-off-by: Little-Wallace <bupt2013211450@gmail.com> Signed-off-by: birdstorm <samuelwyf@hotmail.com>

shiyuhang0 mentioned this pull request Mar 7, 2023

Expose forward and set it to false in default pingcap/tispark#2641

Merged

ti-chi-bot mentioned this pull request Mar 13, 2023

Expose forward and set it to false in default (#2641) pingcap/tispark#2647

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support grpc forward#198

Support grpc forward#198
Little-Wallace merged 12 commits intotikv:masterfrom
Little-Wallace:grpc

Little-Wallace commented Jun 16, 2021

Uh oh!

MyonKeminta Jun 16, 2021

Uh oh!

MyonKeminta Jun 16, 2021

Uh oh!

MyonKeminta Jun 16, 2021

Uh oh!

birdstorm left a comment

Uh oh!

MyonKeminta Jun 18, 2021

Uh oh!

Little-Wallace Jun 18, 2021

Uh oh!

MyonKeminta left a comment

Uh oh!

MyonKeminta Jun 18, 2021

Uh oh!

MyonKeminta Jun 18, 2021

Uh oh!

MyonKeminta Jun 18, 2021

Uh oh!

Little-Wallace Jun 18, 2021

Uh oh!

ti-srebot commented Jun 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	public static final Metadata.Key FORWARD_META_DATA_KEY =
	public static final Metadata.Key FORWARD_METADATA_KEY =

Conversation

Little-Wallace commented Jun 16, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

birdstorm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MyonKeminta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Jun 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants