Skip to content

Expose forward and set it to false in default#2641

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
shiyuhang0:forward
Mar 13, 2023
Merged

Expose forward and set it to false in default#2641
ti-chi-bot merged 4 commits intopingcap:masterfrom
shiyuhang0:forward

Conversation

@shiyuhang0
Copy link
Copy Markdown
Member

@shiyuhang0 shiyuhang0 commented Mar 7, 2023

What problem does this PR solve?

tikv/client-java#198

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xuanyu66
  • zhangyangyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Daemonxiao
Daemonxiao reviewed Mar 7, 2023
View reviewed changes
Comment thread tikv-client/src/main/java/com/pingcap/tikv/operation/iterator/DAGIterator.java Outdated
@shiyuhang0
Copy link
Copy Markdown
Member Author

shiyuhang0 commented Mar 12, 2023

/run-all-tests

@shiyuhang0
Copy link
Copy Markdown
Member Author

shiyuhang0 commented Mar 13, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 13, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3853acc

@ti-chi-bot ti-chi-bot merged commit f2ab73e into pingcap:master Mar 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 13, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 13, 2023

In response to a cherrypick label: new pull request created to branch release-3.2: #2647.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 13, 2023
@shiyuhang0 @ti-chi-bot
This is an automated cherry-pick of pingcap#2641
72236ef 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@zhangyangyu zhangyangyu deleted the forward branch March 13, 2023 13:22
ti-chi-bot added a commit that referenced this pull request Mar 15, 2023
@ti-chi-bot
Expose forward and set it to false in default (#2641) (#2647)
c2c70d7
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
@shiyuhang0
Expose forward and set it to false in default (pingcap#2641)
eaa1dc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuanyu66 xuanyu66 xuanyu66 approved these changes

+2 more reviewers

@Daemonxiao Daemonxiao Daemonxiao left review comments

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-3.2 status/can-merge status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shiyuhang0 @ti-chi-bot @zhangyangyu @xuanyu66 @Daemonxiao