docs: record retained Reservoir dependency decision - #541
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the keep-dependency resolution of #521. The closed vendoring proposal in #344 did not ship; #497 subsequently upgraded Reservoir. The decision explains why the existing pool remains, points to the dependency and strong-naming documentation, and preserves the package verification contract.
Closes #521
Validation
dotnet build Kevlar.slnx -c Release: passed, zero warnings/errors.dotnet pack Kevlar.slnx -c Release --no-build: passed.pwsh scripts/Verify-Packages.ps1 -PackagesPath artifacts/package/release -Version 0.0.0-local: passed dependency metadata, symbols, determinism, SourceLink, consumer, publish compatibility, and analyzer checks. NativeAOT verification remains Linux CI-only.dotnet run --project tests/Kevlar.AllocationTests -c Release -f net8.0 --no-build -- --timeout 5m: 4 passed.-f net10.0: 4 passed.git diff --check: passed. Relative links and anchors checked against repository files.Compatibility
Decision record only, outside the documentation-site content directory. No runtime, package, public API, target framework, benchmark, allocation-gate, or site layout changes.