Skip to content

build: reconcile #344 with the remaining Reservoir dependency #521

Description

@thomhurst

Problem

#344 ("internalise the Reservoir object pool — zero-dependency core, unblocks strong naming") is closed as completed, but the dependency is still present:

  • src/Kevlar/Kevlar.csproj:19 has <PackageReference Include="Reservoir" />.
  • Directory.Packages.props pins Reservoir to [1.9.1,2.0.0), and chore(deps): upgrade Reservoir to 1.9.1 #497 upgraded it.
  • using Reservoir appears in KevlarContext.cs, KevlarProperties.cs, Strategies/Hedging/HedgingStrategy.cs, and Strategies/Timeout/TimeoutStrategy.cs.
  • scripts/Verify-Packages.ps1:307-309 asserts Reservoir as an expected dependency for every target.

#344 has no closing comment, so the decision is not recorded.

Proposed fix

Decide and record one of:

Tests

  • Verify-Packages.ps1 passes for the chosen outcome.
  • Allocation gates and benchmarks unchanged.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions