You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#344 ("internalise the Reservoir object pool — zero-dependency core, unblocks strong naming") is closed as completed, but the dependency is still present:
src/Kevlar/Kevlar.csproj:19 has <PackageReference Include="Reservoir" />.
Vendor the pool. Add an internal ObjectPool under src/Kevlar/Internal/, drop the package reference, and update Verify-Packages.ps1, PackageDependencyPolicy.ps1, and renovate.json.
Tests
Verify-Packages.ps1 passes for the chosen outcome.
Problem
#344 ("internalise the Reservoir object pool — zero-dependency core, unblocks strong naming") is closed as completed, but the dependency is still present:
src/Kevlar/Kevlar.csproj:19has<PackageReference Include="Reservoir" />.Directory.Packages.propspinsReservoirto[1.9.1,2.0.0), and chore(deps): upgrade Reservoir to 1.9.1 #497 upgraded it.using Reservoirappears inKevlarContext.cs,KevlarProperties.cs,Strategies/Hedging/HedgingStrategy.cs, andStrategies/Timeout/TimeoutStrategy.cs.scripts/Verify-Packages.ps1:307-309assertsReservoiras an expected dependency for every target.#344 has no closing comment, so the decision is not recorded.
Proposed fix
Decide and record one of:
ObjectPoolundersrc/Kevlar/Internal/, drop the package reference, and updateVerify-Packages.ps1,PackageDependencyPolicy.ps1, andrenovate.json.Tests
Verify-Packages.ps1passes for the chosen outcome.