Skip to content

Add support for replica zones, service account scopes, and auditd logging in workstations configs#544

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-2aaa5ac47521cc49fba2f19d2596512da0fb0e46
Sep 22, 2023
Merged

Add support for replica zones, service account scopes, and auditd logging in workstations configs#544
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-2aaa5ac47521cc49fba2f19d2596512da0fb0e46

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

fixes: b/274485263, b/296077546, b/286299420

This change updates google_workstations_workstation_config with three fields that are supported by the cloud workstations api.

  • enableAuditAgent can now be specified to enable auditd logging
  • replicaZones can now be set on create
  • host.gceInstance.serviceAccountScopes can now be specified

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

workstations: added `replica_zones`, `service_account_scopes`, and `enable_audit_agent` to `google_workstations_workstation_config` (beta)

Derived from GoogleCloudPlatform/magic-modules#9028

…ging in workstations configs (#9028)

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit f986689 into terraform-google-modules:master Sep 22, 2023
@modular-magician modular-magician deleted the downstream-pr-2aaa5ac47521cc49fba2f19d2596512da0fb0e46 branch November 18, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant