Skip to content

Add support for replica zones, service account scopes, and auditd logging in workstations configs#9028

Merged
trodge merged 1 commit into
GoogleCloudPlatform:mainfrom
joelkattapuram:workstations-newfeatures2
Sep 22, 2023
Merged

Add support for replica zones, service account scopes, and auditd logging in workstations configs#9028
trodge merged 1 commit into
GoogleCloudPlatform:mainfrom
joelkattapuram:workstations-newfeatures2

Conversation

@joelkattapuram

@joelkattapuram joelkattapuram commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

fixes: b/274485263, b/296077546, b/286299420

This change updates google_workstations_workstation_config with three fields that are supported by the cloud workstations api.

  • enableAuditAgent can now be specified to enable auditd logging
  • replicaZones can now be set on create
  • host.gceInstance.serviceAccountScopes can now be specified

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

workstations: added `replica_zones`, `service_account_scopes`, and `enable_audit_agent` to `google_workstations_workstation_config` (beta)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 15 insertions(+))
Terraform Beta: Diff ( 5 files changed, 196 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 31 insertions(+))
TF OiCS: Diff ( 1 file changed, 2 insertions(+))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3076
Passed tests 2767
Skipped tests: 299
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccWorkstationsWorkstationConfig_serviceAccount|TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails|TestAccWorkstationsWorkstationConfigIamMemberGenerated|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccWorkstationsWorkstationConfigIamBindingGenerated

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccWorkstationsWorkstationConfig_serviceAccount[Debug log]
TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]
TestAccWorkstationsWorkstationConfig_update[Debug log]
TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log]
TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants