Skip to content

Move acc tests to service package (mmv1 + related handwritten)#494

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-dcedf6ac561eeff3c6d1dc69f6249afea808c0fe
Aug 11, 2023
Merged

Move acc tests to service package (mmv1 + related handwritten)#494
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-dcedf6ac561eeff3c6d1dc69f6249afea808c0fe

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

As we don't want to move all of the tests in one PR. The PR 8272 is going to be split into two PRs. This is the second PR.

  1. Generate Mmv1 tests to the specific service packages
  2. Move some handwritten tests to the specific service packages. These tests share the same CheckDestroy functions generated in the MMv1 tests.
  3. Copy test-fixtures to the specific service packages
  4. Move function createZIPArchiveForCloudFunctionSource to the acctest package
  5. Move function testBucketName to the acctest package

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#8378

* Generate Mmv1 test files to the service packages

* Fix test-fixtures

* Copy test-fixtures in service packages

* Replace test-fixtures path

* Fix rebasing errors

* Fix function usage

* Fix test TestAccBigQueryExternalDataTable_objectTable

* Fix test-fixtures

* Keep deprecated utility functions

* Move tests

* Fixing rebasing error

* Move more tests to the service packages

* Add back resource_resourcemanager_lien_test.go

* Change package name

* Fix test-fixtures

* Fix the test-fixtures

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician
modular-magician merged commit eed6b4d into terraform-google-modules:master Aug 11, 2023
@modular-magician
modular-magician deleted the downstream-pr-dcedf6ac561eeff3c6d1dc69f6249afea808c0fe branch November 18, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant