Skip to content

Bitbucket Trigger support for Manual, Pub/Sub and Webhook triggers#492

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-b065cd6471f677326b6c7949e9e3234f3b9a5c2a
Aug 11, 2023
Merged

Bitbucket Trigger support for Manual, Pub/Sub and Webhook triggers#492
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-b065cd6471f677326b6c7949e9e3234f3b9a5c2a

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

Adds field bitbucket_server_config to Trigger.git_file_source and Trigger.source_to_build, supporting manual, pub/sub and webhook triggers.

Also fixes TestAccCloudBuildTrigger_basic_bitbucket test.

fixes hashicorp/terraform-provider-google#15079

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: added `git_file_source.bitbucket_server_config` and `source_to_build.bitbucket_server_config` fields to `google_cloudbuild_trigger` resource

Derived from GoogleCloudPlatform/magic-modules#8544

…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (#8544)

Also fixes TestAccCloudBuildTrigger_basic_bitbucket test.

Co-authored-by: Mario Machado <mariomachado@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician
modular-magician merged commit e4df82d into terraform-google-modules:master Aug 11, 2023
@modular-magician
modular-magician deleted the downstream-pr-b065cd6471f677326b6c7949e9e3234f3b9a5c2a branch November 18, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudBuildTrigger_basic_bitbucket

1 participant