Skip to content

Rebase on 4.15 - #80

Merged
crawfxrd merged 0 commit into
system76from
system76-rebase
Dec 21, 2021
Merged

crawfxrd merged 0 commit into
system76from
system76-rebase

Conversation

@crawfxrd

@crawfxrd crawfxrd commented Sep 17, 2021 •

Copy link
Copy Markdown
Member

Replaces: #65, #66, #69, #74, #76

Ref: system76/firmware-open#260

TODO

  • Rebase on the actual 4.15 release, scheduled for November 1st 5th
    • Rebased ahead to include all mainboards and most SoC changes we need
  • Check that the HECI device is disabled at runtime if the CSME is disabled
    • Tested on oryp8 (TGL-H), gaze15 (CML-H), oryp5 (CFL-H), and galp3-c (WHL-U)
  • Reevaluate if we need to force NVIDIA GPU prefetch resources about 4GB
    • Yeah, 30 series wants to claim 16GB for prefmem...
  • Cherry-pick TGL TBT fixes
    • Included in rebase now
  • Potentially, replace IME config with Star Labs' implementation

Testing

Needs testing on, preferably, all boards

  • addw1
  • addw2
  • bonw14
  • darp5
  • darp6
  • darp7
  • galp2
  • galp3
  • galp3-b
  • galp3-c
  • galp4
  • galp5
  • gaze14
  • gaze15
  • gaze16-3050
  • gaze16-3060
  • gaze16-3060-b
  • lemp9
  • lemp10
  • oryp5
  • oryp6
  • oryp7
  • oryp8

Intel Management Engine

IME mode is now controlled by a CMOS option (except on KBL which uses me_cleaner, and so doesn't apply).

  • CNL-based and TGL-H boards default to disabled*
  • TGL-U boards default to enabled

Changing IME modes triggers a global reset to complete the switch. As such, the first boot after flashing will power off for most boards.

The HECI device (00:16.0) is enabled in devicetree in order to trigger the reset and report ME status/version. It will be disabled (except on TGL-U) before the payload runs.

@crawfxrd
crawfxrd force-pushed the system76-rebase branch 6 times, most recently from 51e43c7 to 4ad2033 Compare September 24, 2021 17:36
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 2 times, most recently from 57f0432 to 058caf6 Compare September 27, 2021 14:29
@crawfxrd
crawfxrd marked this pull request as ready for review September 28, 2021 15:05
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 2 times, most recently from ff1828d to a7ad69c Compare September 29, 2021 20:02
@crawfxrd

crawfxrd commented Sep 30, 2021 •

Copy link
Copy Markdown
Member Author

Getting this on gaze16-3050 and oryp8:

irq 10: nobody cared (try booting with the "irqpoll" option)
CPU: 14 PID: 0 Comm: swapper/14 Tainted: P           OE     5.14.9-76051409-generic #202109300934~1633018643~21.10~6609c34
Hardware name: System76 Gazelle/Gazelle, BIOS 2021-09-30_43e3cb1 09/29/2021
Call Trace:
 <IRQ>
 show_stack+0x52/0x58
 dump_stack_lvl+0x4a/0x5f
 dump_stack+0x10/0x12
 __report_bad_irq+0x3a/0xaf
 note_interrupt.cold+0xb/0x60
 handle_irq_event+0xa7/0xb0
 handle_fasteoi_irq+0x7d/0x1c0
 __common_interrupt+0x48/0xb0
 common_interrupt+0x88/0xa0
 </IRQ>
 asm_common_interrupt+0x1e/0x40
RIP: 0010:poll_idle+0x9b/0xb9
Code: 44 89 e8 41 5c 41 5d 41 5e 41 5f 5d c3 4c 89 f7 48 89 de e8 c7 81 d4 ff 49 89 c6 b8 c9 00 00 00 49 8b 17 83 e2 08 75 b1 f3 90 <83> e8 01 >
RSP: 0018:ffffbb8480103e18 EFLAGS: 00000246
RAX: 000000000000007c RBX: ffffdb847fd80b00 RCX: 000000000000001f
RDX: 0000000000000000 RSI: 00000000378e38e3 RDI: fffffffd126cf3b3
RBP: ffffbb8480103e40 R08: 00000000fc993634 R09: 0000000000000004
R10: 0000000000000000 R11: 071c71c71c71c71c R12: 00000000fc95b58c
R13: 0000000000000000 R14: 000000000003d090 R15: ffff9f1b40ba5d00
 ? poll_idle+0xac/0xb9
 cpuidle_enter_state+0x95/0x3e0
 cpuidle_enter+0x2e/0x40
 cpuidle_idle_call+0x132/0x1d0
 do_idle+0x83/0xf0
 cpu_startup_entry+0x20/0x30
 start_secondary+0x127/0x160
 secondary_startup_64_no_verify+0xc2/0xcb
handlers:
[<000000007c3451a7>] azx_interrupt [snd_hda_codec]
Disabling IRQ #10

@crawfxrd
crawfxrd requested review from a team and jackpot51 October 1, 2021 13:32
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 2 times, most recently from e6677f7 to 687fd44 Compare October 5, 2021 01:49
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 3 times, most recently from 9876925 to b0da637 Compare October 13, 2021 14:03
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 4 times, most recently from b45db1a to 2bc7a9f Compare October 23, 2021 22:02
@crawfxrd crawfxrd mentioned this pull request Oct 23, 2021
28 tasks
@crawfxrd crawfxrd changed the title Rebase on upstream Rebase on 4.15 Oct 26, 2021
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 2 times, most recently from e67fcab to cb72974 Compare October 27, 2021 23:18
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 3 times, most recently from d333dcc to c0c283a Compare November 1, 2021 20:22
@jackpot51 jackpot51 mentioned this pull request Nov 2, 2021
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 5 times, most recently from 6aae436 to 825aae5 Compare November 8, 2021 15:56
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 10 times, most recently from de6cabe to 2ba7283 Compare November 16, 2021 14:39
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 5 times, most recently from beabfe8 to eb25d39 Compare November 22, 2021 16:08
@crawfxrd
crawfxrd force-pushed the system76-rebase branch 2 times, most recently from e149312 to 182adc6 Compare December 7, 2021 23:22
@crawfxrd
crawfxrd merged commit 87aaef8 into system76 Dec 21, 2021
@crawfxrd
crawfxrd deleted the system76-rebase branch December 21, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants