Conversation
- Move enabling GPU power from bootblock to romstage
- Provide a header to call power function so source file doesn't have
to be included in the mainboard
- Replace BS_DEV_RESOURCES hook with a chip to bind the driver to the
devices in devicetree
- Set subsystem ID via ops_pci->set_subsystem instead of read_resources
- Fix formatting to follow coreboot style
Tested on gaze15.
- System powers on/off
- GPU has correct subsystem ID on power on*
lspci -s 01:00.0 -vnn | grep Subsystem
Subsystem: CLEVO/KAPOK Computer TU116M [GeForce GTX 1660 Ti Mobile] [1558:8520]
- GPU suspends while inactive in hybrid mode
cat /sys/bus/pci/devices/0000\:01\:00.0/power/runtime_status
suspended
- System completes S3 suspend/resume
- GPU has correct subsystem ID after S3 suspend*
Known issue: GPU subsystem ID is lost after GC6 exit
Change-Id: If3ef35fa0a6eb50b6f580c82d0bfb66d44649d3d
Signed-off-by: Tim Crawford <tcrawford@system76.com>
- Using the new driver chip, explicitly define the NVIDIA GPU devices in the devicetree - Move enabling GPU power from bootblock to romstage Change-Id: Ic47c40fdfa3cab63ec1a16933c691807625b9f8b Signed-off-by: Tim Crawford <tcrawford@system76.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the driver:
BS_DEV_RESOURCEShook with a chip to bind the driver to the devices in devicetreeops_pci->set_subsysteminstead ofread_resourcesFor mainboards:
Tested on gaze15 and gaze16-3050.