Skip to content

Prototype: deployment target conditional compilation in the compiler - #92598

Draft
Jiaxu-Li wants to merge 6 commits into
swiftlang:mainfrom
Jiaxu-Li:deployment-target-ifconfig
Draft

Jiaxu-Li wants to merge 6 commits into
swiftlang:mainfrom
Jiaxu-Li:deployment-target-ifconfig

Conversation

@Jiaxu-Li

Copy link
Copy Markdown
Contributor

@xwu xwu added the swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review label Sep 24, 2026
@xwu

xwu commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

swiftlang/swift-syntax#3450

@swift-ci Please build toolchain

@Jiaxu-Li

Copy link
Copy Markdown
Contributor Author

Thanks for starting the toolchain builds. I’ve fixed the two Windows test failures in the latest commit. Could you rerun the toolchain builds on the updated branch?

@xwu

xwu commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

swiftlang/swift-syntax#3450

@swift-ci Please build toolchain Windows platform

@xwu

xwu commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

swiftlang/swift-syntax#3450

@swift-ci Please build toolchain Linux platform

@Jiaxu-Li
Jiaxu-Li marked this pull request as ready for review September 25, 2026 07:54
@Jiaxu-Li
Jiaxu-Li requested a review from a team as a code owner September 25, 2026 07:54
@Jiaxu-Li
Jiaxu-Li marked this pull request as draft September 25, 2026 07:54
@Jiaxu-Li

Copy link
Copy Markdown
Contributor Author

Thanks for rerunning the builds. Linux is still failing on a network timeout. I’ve fixed the remaining Windows test issue. could you rerun the Windows build on the latest commit?

@xwu

xwu commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

swiftlang/swift-syntax#3450

@swift-ci Please build toolchain Linux platform

@xwu

xwu commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Looks like the test failure isn't getting in the way of having a build artifact, so I think we can stop repeating the Windows build. Will run the Linux toolchain build again one more time.

@Jiaxu-Li

Copy link
Copy Markdown
Contributor Author

The latest Linux build hit the same GitHub connection timeout. The macOS build passed, and Windows produced an artifact. Please let me know if you need anything else from me before the proposal moves to review. Thanks 😊.

@xwu

xwu commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks, I think we've got as much as we're going to get. I'll get things ready to go soon from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

swift evolution pending discussion Flag → feature: A feature that has a Swift evolution proposal currently in review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants