Repository navigation
Conversation
Jiaxu-Li
requested review from
hamishknight,
hborla,
nkcsgexi and
rintaro
as code owners
September 24, 2026 15:09
Jiaxu-Li
marked this pull request as draft
September 24, 2026 15:13
This was referenced Sep 24, 2026
Member
|
FYI #3456 changed how collection nodes are constructed. This PR needs rebasing. 🙇 |
Jiaxu-Li
force-pushed
the
deployment-target-ifconfig
branch
from
October 11, 2026 15:15
e59e5a9 to
0c84a34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
Prototype SwiftSyntax support for
#if deploymentTargetAtLeast(...), as proposed in [Proposal] Deployment target conditional compilation swift-evolution#3478. This draft PR supports building test toolchains during review.Scope:
Adds parsing and conditional-compilation evaluation for the new condition, along with diagnostics and focused tests.
Issues:
Related proposal: [Proposal] Deployment target conditional compilation swift-evolution#3478
Risk:
The condition is experimental and feature-gated. Integration with the compiler should be validated in test toolchains.
Testing:
SwiftIfConfigTest.EvaluateTests/testDeploymentTargetAtLeastpasses.