fix: outside import with relative module graph

[kallebysantos]

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

When using outside import for local development, the bundler does not include relative imports in the Module graph,
Like the following example

Error

worker boot error: failed to create the graph: Module not found "file:///Users/kallebysantos/projects/testing/supa/outside-imports/my-lib/add.ts".
    at file:///Users/kallebysantos/projects/testing/supa/outside-imports/my-lib/index.ts:1:21
worker boot error: failed to create the graph: Module not found "file:///Users/kallebysantos/projects/testing/supa/outside-imports/my-lib/add.ts".
    at file:///Users/kallebysantos/projects/testing/supa/outside-imports/my-lib/index.ts:1:21
InvalidWorkerCreation: worker boot error: failed to create the graph: Module not found "file:///Users/kallebysantos/projects/testing/supa/outside-imports/my-lib/add.ts".
    at file:///Users/kallebysantos/projects/testing/supa/outside-imports/my-lib/index.ts:1:21
    at async UserWorker.create (ext:sb_user_workers/user_workers.js:139:15)
    at async Object.handler (file:///root/index.ts:157:22)
    at async respond (ext:sb_core_main_js/js/http.js:197:14) {
  name: "InvalidWorkerCreation"
}

What is the new behavior?

This PR applies the same import resolution as when deploying from --use-api. So it ensures that all files are bundled for local development.

Fixed

[jumski]

Yes please! This makes the outside imports usable 🎉

[laktek]

Thanks! This applies to local development as in functions serve right?

@sweatybridge and CLI team will review & merge it.

[kallebysantos]

This applies to local development as in functions serve right?

Yes, it will bind the missing files to the docker container

[kallebysantos]

Hey @sweatybridge I think u did revert the absolute path commitc6da3a7. Was that intentional?

[sweatybridge]

yea.. actually the implementation of walkImportPaths assumed inputs are relative paths only, for a few reasons.

1. api upload doesn't support absolute path as the name of form upload
2. we can't get back the absolute path on windows without assuming the drive letter is always the same as cwd

so there are still a bit of touch up / refactoring i need to do after this

[kallebysantos]

I see, well from my tests except by the supabase/function/slug/index.ts file all others was already returned as fullpath from the walkImportPaths method.
You can see it by printing out the unixPath variable

[wyozi]

@kallebysantos does this require some special configuration or flags to supabase serve to work? I tried to use code based on your repo and supabase/cli v2.22.1 to get local relative imports to work but no dice

e: nvm, I had file: prefixes in my import maps, which do not work with this

[kallebysantos]

Hey @wyozi, sorry about that confusion 😅
I used the same repo to test other incoming feature #3430, that's why the current code doesn't works with v2.22.1.
I'll patch fix it, but the error is because v2.22.1 still don't support the importMap so the deno.json file is not resolving any imports.

Working example

// supabase/functions/[slug]/deno.json
{
   "imports": {
    "@mylib": "../../../my-lib/index.ts"
  }
}

[wyozi]

@kallebysantos ah yeah, good stuff. I think that feature actually already is in 2.22.1, which is why just removing the file: prefix seems to have solved the problem