Unexpected behaviour when importing another project using its mod.ts file

[maximilian-hammerl]

Describe the bug

We started using Deno workspaces recently and when we found it that Supabase edge functions do not yet support Deno workspaces (#3047), we worked around this issue by adding the workspace members to the imports like this:

{
  "imports": {
    ...
    "other_workspace_member_name/": "../path/to/workspace/member/",
    ...
  }
}

As the next step we wanted to just import the mod.ts files of the other workspace members:

{
  "imports": {
    ...
    "other_workspace_member_name": "../path/to/workspace/member/mod.ts",
    ...
  }
}

While we refactored our edge functions, we tested every edge functions after we adjusted its imports and everything worked as expected.
But as soon as we refactored the last edge functions, all edge functions always failed with the following error message:

Using supabase-edge-runtime-1.66.5 (compatible with Deno v1.45.2)
serving the request with supabase/functions/import-mod-ts
worker boot error: failed to create the graph: Module not found "file:///.../supabase-local-import-bug/another-project/file_a.ts".
    at file:///.../supabase-local-import-bug/another-project/mod.ts:1:15
worker boot error: failed to create the graph: Module not found "file:///Users/maximilianhammerl/Documents/Repositories/supabase-local-import-bug/another-project/file_a.ts".
    at file:///...supabase-local-import-bug/another-project/mod.ts:1:15
InvalidWorkerCreation: worker boot error: failed to create the graph: Module not found "file:///Users/maximilianhammerl/Documents/Repositories/supabase-local-import-bug/another-project/file_a.ts".
    at file:///.../supabase-local-import-bug/another-project/mod.ts:1:15
    at async UserWorker.create (ext:sb_user_workers/user_workers.js:139:15)
    at async Object.handler (file:///root/index.ts:157:22)
    at async respond (ext:sb_core_main_js/js/http.js:197:14) {
  name: "InvalidWorkerCreation"

To Reproduce

Repository with more details, examples and to how to reproduce: https://github.com/maximilian-hammerl/supabase-local-import-bug

Expected behavior

Imports of one edge functions should not affect other edge functions in any way.

---

I was not sure whether to open this issue here in the CLI repository or in the edge runtime repository. I decided for the CLI repository, as we use the edge runtime through the CLI.

[maximilian-hammerl]

I added a GitHub action with 3 jobs which hopefully make the problem quite clear:

---

The mod-ts-and-relative-import job just calls both edge functions:

relative path test:
...
{"message":"Edge function with relative path import"}
----------
mod.ts test:
---
{"message":"Edge function with mod.ts import"}

Both edge functions respond successfully.

---

In the only-relative-import job the import-mod-ts edge functions is first removed, before the edge functions are called:

relative path test:
...
{"message":"Edge function with relative path import"}
----------
mod.ts test:
...
Function not found

As expected the only-relative-import edge function responds successfully, the import-mod-ts edge function is not found.

---

In the only-mod-ts job the import-relative-path edge functions is first removed, before the edge functions are called:

relative path test:
...
Function not found
----------
mod.ts test:
...
{"code":"BOOT_ERROR","message":"Worker failed to boot (please check logs)"}

As expected the only-relative-import edge functions is not found, but the import-mod-ts edge function fails, although the edge function was not modified in any way.

[sweatybridge]

@nyannyacha fyi

[nyannyacha]

I plan to check this thing in the Deno 2.1 upgrade.
And yes, the workspace feature is currently not supported.
FUNC-172

[maximilian-hammerl]

@sweatybridge, I just wanted to ask whether this problem is really related to Deno workspaces and whether it should be closed as a duplicate of the Deno workspaces issue.

Yes, it occurred when we tried this mod.ts import as an alternative to Deno workspaces, but as far as I am concerned importing something by their mod.ts file should work independent of Deno workspaces.

[nyannyacha]

Perhaps it's a docker volume mount issue?

I looked at https://github.com/maximilian-hammerl/supabase-local-import-bug and it refers to a folder higher than supabase folder.
not sure as I don't monitor the CLI repository often, but does the cli mount the parent folder?

[sweatybridge]

@nyannyacha oh you are probably right. We do support parent directories but in a somewhat limited way. #2533 (comment)

We have released a fix for functions deploy but for local serving, this might still be an issue.

[nyannyacha]

We now support the workspace feature for Deno and NodeJS(npm).

Please refer to the links below for examples:
Deno: https://github.com/supabase/edge-runtime/tree/51173bec0a433c7ec6dbd0a717de48326f07e77b/crates/base/test_cases/workspace
NodeJS: https://github.com/supabase/edge-runtime/tree/51173bec0a433c7ec6dbd0a717de48326f07e77b/crates/base/test_cases/commonjs-workspace

[sweatybridge]

this has been resolved in beta release #3417