hardware wallet misc fixes - #685
Conversation
| </div> | ||
| <div className="LedgerSign__bottom"> | ||
| <LedgerErrorBlock error={connectError} /> | ||
| {isDetectBtnDirty && <LedgerErrorBlock error={connectError} />} |
There was a problem hiding this comment.
hide the connect error before user clicks "detect"
| submitFreighterTransaction.fulfilled.match(submitResp) && | ||
| !isSwap | ||
| ) { | ||
| dispatch(addRecentAddress({ publicKey: destination })); |
There was a problem hiding this comment.
save recent address for hardware wallet successful send
https://stellarorg.atlassian.net/browse/WAL-385
| case LEDGER_ERROR.NOT_OPEN: | ||
| errorMessage = t( | ||
| "Please open the Stellar app on the device and try again.", | ||
| "Connect device to computer and open the Stellar app on it.", |
There was a problem hiding this comment.
| networkDetails, | ||
| if (isHardwareWallet) { | ||
| await dispatch(startHwSign({ transactionXDR, shouldSubmit: true })); | ||
| emitMetric(METRIC_NAMES.manageAssetAddUnsafeAsset, { code, issuer }); |
There was a problem hiding this comment.
ran into this bug, where adding the trustline when the NewAssetWarning popup comes up w/ hardware wallet would throw error
(I fixed this in this PR for the ScamAssetWarning popup, forgot to change here as well)
| @@ -20,9 +20,7 @@ import { settingsNetworkDetailsSelector } from "popup/ducks/settings"; | |||
|
|
|||
| export const Swap = () => { | |||
There was a problem hiding this comment.
other misc bug found. When loading the swap page w/ no trustlines it gets caught in a useEffect loop.
I had fixed this before in #549, but looks like somewhere around the 2.3 merge conflict release it got added back 😬 . Hopefully with the new branch process we're doing won't be an issue!
* add swap button if asset balance 0 (#678) * show swap button if no balance * Add translations Co-authored-by: GitHub Action <action@github.com> * when recovering account pre load first couple accounts if funded (#679) * pre load first couple of accounts if funded * use _activatePublicKey * update key derivation num after recovering account (#683) * add integration tests (#684) * hold * added all tests with todos * clean up * cleanup * clean up * cleanup * dont run test if background not build w/ experimental mode * cleanup * hardware wallet misc fixes (#685) * add recent address for ledger * fix no trustlines swap * hide ledger connect error on first load * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: GitHub Action <action@github.com>
3 participants
misc bug fixes / changes related to hardware wallets. Pointed out in the comments