add swap button if asset balance 0 - #678
Merged
Merged
Conversation
Contributor
piyalbasu
approved these changes
Nov 21, 2022
piyalbasu
added a commit
that referenced
this pull request
Dec 10, 2022
* add swap button if asset balance 0 (#678) * show swap button if no balance * Add translations Co-authored-by: GitHub Action <action@github.com> * when recovering account pre load first couple accounts if funded (#679) * pre load first couple of accounts if funded * use _activatePublicKey * update key derivation num after recovering account (#683) * add integration tests (#684) * hold * added all tests with todos * clean up * cleanup * clean up * cleanup * dont run test if background not build w/ experimental mode * cleanup * hardware wallet misc fixes (#685) * add recent address for ledger * fix no trustlines swap * hide ledger connect error on first load * Add translations Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket
show swap button in asset details if no balance