Merged
Conversation
Rename 'vxlan' -> 'tenant' and avoid setting `provider_network_type` explicitly so that OVS/OVN can choose vxlan/geneve automatically.
Author
|
This change is needed for the AUFN SKC environment, but should also work with multi-node env. |
markgoddard
approved these changes
Jan 10, 2023
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
LGTM, let's get approval from @jackhodgkiss too
jackhodgkiss
approved these changes
Jan 10, 2023
Collaborator
jackhodgkiss
left a comment
jackhodgkiss
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename 'vxlan' -> 'tenant' and avoid setting
provider_network_typeexplicitly so that OVS/OVN can choose vxlan/geneve automatically.