Conversation
|
Are there any more changes that need made before I try testing this? |
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
LGTM, give it a whirl.
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
Extract the non-AUFN bits please
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
Sorry for the slow review. If you rebase your changes onto stackhpc/xena, it should pick up the bits you extracted.
etc/kayobe/environments/aufn-ceph/configure-local-networking.sh
Outdated
Show resolved
Hide resolved
|
I think this is now ready to go. |
Enable provider networks in neutron and add geneve network config
markgoddard
force-pushed
the
yoga-aufn
branch
from
b3c066c to
9960aa5
Compare
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
Great work Scott. I rebased the change to remove the commits that were pulled out into separate PRs. I pushed your original branch to yoga-aufn-og in case you wanted to compare.
|
Looks like there are some pep8 issues: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/3904414510/jobs/6670166003 |
|
Could you add some basic docs in |
|
Seems we have some pep8 failures |
|
How do I fix the final pep8 issue? It's complaining about {% if ... %} syntax in a yaml file. Will add some docs separately here: https://github.com/stackhpc/stackhpc-kayobe-config/tree/yoga-aufn-docs |
….yml Co-authored-by: Mark Goddard <mark@stackhpc.com>
|
How do you feel about squashing the commits? Are they useful to keep separate? |
(Merge pull request is a drop down) |
2 participants
No description provided.