Repository navigation
fix: prevent split-group container teardown when switching worktrees - #726
Merged
brennanb2025 merged 4 commits intoApr 16, 2026
Merged
brennanb2025 merged 4 commits into
brennanb2025 merged 4 commits into
Conversation
…ktree When the split-group renderer path is enabled, the container was conditionally mounted based on effectiveActiveLayout (the active worktree's layout). Switching to a newly-activated worktree that has no split-group layout yet caused the container to unmount, destroying PaneManagers, xterm buffers, and PTY connections for ALL previously mounted worktrees. Fix: use anyMountedWorktreeHasLayout to keep the container mounted whenever any mounted worktree has a layout. When the active worktree has no layout, hide the container with CSS instead of unmounting it, so the legacy fallback renders while existing worktree state is preserved.
Extract getEffectiveLayoutForWorktree and anyMountedWorktreeHasLayout into a standalone helper so the container-teardown fix is covered by unit tests. Remove FIX.md.
brennanb2025
deleted the
brennanb2025/brennanb2025-fix-split-group-container-teardown
branch
April 16, 2026 21:29
brennanb2025
added a commit
that referenced
this pull request
Apr 19, 2026
Adds Playwright coverage for two high-regression areas identified from the last 200 PRs: - worktree-lifecycle.spec.ts: guards removeWorktree cleanup (#532), worktree switch with right sidebar open (#598/#628/#726), and cross-worktree tab isolation (#542/#554). - tab-close-navigation.spec.ts: guards visual-neighbor activation on editor/diff close (#693) and Landing fallback when the last visible surface closes (#677).
3 tasks done
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectiveActiveLayoutgate withanyMountedWorktreeHasLayout— the container stays mounted (hidden via CSS) as long as any mounted worktree has a layout, preventing teardown while the legacy fallback renders the new worktree.getEffectiveLayoutForWorktreeandanyMountedWorktreeHasLayoutintosplit-group-mount.tswith 9 unit tests covering the core bug scenario and edge cases.Test plan
pnpm test— all 1730 tests passpnpm run typecheck— cleanbrennanb2025/brennanb2025-playwright-split-groups-tests), depends on this landing first