Repository navigation
fix: return to Orca landing screen after closing last terminal - #677
Merged
brennanb2025 merged 1 commit intoApr 15, 2026
Merged
Conversation
- Fix blank screen after closing last terminal\n\n- fix: return to landing screen after closing last terminal tab
brennanb2025
force-pushed
the
brennanb2025/close-terminal-cmd-d-blank-screen
branch
from
April 15, 2026 22:38
2d50c8f to
8f30f13
Compare
brennanb2025
changed the title
brennanb2025
added a commit
that referenced
this pull request
Apr 19, 2026
Adds Playwright coverage for two high-regression areas identified from the last 200 PRs: - worktree-lifecycle.spec.ts: guards removeWorktree cleanup (#532), worktree switch with right sidebar open (#598/#628/#726), and cross-worktree tab isolation (#542/#554). - tab-close-navigation.spec.ts: guards visual-neighbor activation on editor/diff close (#693) and Landing fallback when the last visible surface closes (#677).
3 tasks done
5 tasks done
AnddyAgudelo
added a commit
to AnddyAgudelo/orca
that referenced
this pull request
Aug 3, 2026
Closing every terminal/agent/browser/editor tab deselected the workspace,
which emptied the file explorer ("Select a workspace to browse files") and
the Git panel until the user re-opened the workspace and spawned a terminal.
Seven last-tab-close paths now leave `activeWorktreeId` intact: the unified
tab slice, editor.ts's two `shouldDeactivateWorktree` branches (closeFile and
closeAllFiles), the legacy terminal and browser close handlers, and the two
`leaveWorktreeIfEmpty` split-group hooks (now removed outright).
The zero-tab pane body previously rendered nothing, so tab groups gain a
quiet empty state with a direct "New terminal" action and its platform
shortcut. Its visibility is derived from observable state, never a clock and
never mount-local state: `ensureWorktreeRootGroup` creates the root group
before its first tab, and a runtime-owned worktree then waits on the host
session-tab mirror, so the empty state is suppressed for exactly that wait.
That wait ends on a publication epoch held in module-local maps, which move
no store slice when the snapshot carries zero tabs, so `web-session-tabs-sync`
publishes an explicit subscription consumed via useSyncExternalStore.
This supersedes PR stablyai#677 ("return to Orca landing screen after closing last
terminal"). stablyai#677 deselected precisely because a selected workspace with no
surfaces rendered blank; the empty state removes that failure mode, so the
landing fallback is no longer needed. Its E2E guard in
tab-close-navigation.spec.ts now asserts the new contract, and sleeping a
workspace is the route back to Landing.
Fixes stablyai#11699
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closing the last terminal in the active worktree could leave Orca with the worktree still selected but no renderable surface. In the
Cmd+Dexit path, that state produced a blank workspace instead of returning to the Orca landing background.Solution
When
closeUnifiedTabremoves the final renderable surface for the active worktree, clear the active worktree and active surface fields so the renderer falls back to the landing state instead of trying to render an empty split-group workspace. Added a regression test that closes the last terminal tab in the active worktree and verifies the store returns to the landing-state selection.