Repository navigation
fix: audit terminal shortcut interception - #519
Merged
Merged
Conversation
9 tasks
nwparker
force-pushed
the
nwparker/shortcuts
branch
from
April 12, 2026 06:17
17ff166 to
031b17e
Compare
dylanklohr
added a commit
to dylanklohr/orca
that referenced
this pull request
Apr 16, 2026
xterm.js emits \e[1;3D / \e[1;3C for option/alt+arrow, which default readline (bash, zsh) does not bind — so word-by-word navigation silently doesn't work. Translate to \eb / \ef inside the terminal shortcut policy so option+←/→ on macOS and alt+←/→ on Linux/Windows match iTerm2's "Esc+" option-key mode. Extends the stablyai#519 allowlist; no scope beyond that. Fixes stablyai#696
6 of 7 tasks
This was referenced May 13, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Terminal control chords were hard to reason about because Orca intercepted shortcuts in three different places: the main window, browser guests, and the terminal renderer. That made it easy to fix one conflict (
Cmd/Ctrl+Rin #443 / #453) without having an explicit contract for which shortcuts must always keep reaching readline.The linked reports (#481 and #482) exposed the broader issue: shortcut interception was not centralized or auditable, so regressions around terminal control keys were likely to recur.
Solution
Centralize shortcut interception into explicit allowlist helpers and add regression tests around the reservation surface.
mainwhile merging it with the new allowlist-based terminal shortcut handlingdocs/term-shortcut-fix.mdTesting
pnpm exec vitest run --config config/vitest.config.ts src/shared/window-shortcut-policy.test.ts src/renderer/src/components/terminal-pane/terminal-shortcut-policy.test.ts src/main/window/createMainWindow.test.ts src/main/menu/register-app-menu.test.ts src/main/browser/browser-manager.test.tsFixes #482 , #481