Repository navigation
fix: preserve reverse search shortcut - #453
Merged
AmethystLiang merged 2 commits intoApr 10, 2026
Merged
Conversation
colinchambachan
marked this pull request as ready for review
April 10, 2026 22:31
AmethystLiang
self-requested a review
April 10, 2026 23:29
This was referenced Apr 11, 2026
enrick-dev
pushed a commit
to enrick-dev/orca
that referenced
this pull request
Oct 15, 2026
* fix: preserve reverse search shortcut * test: cover cmd+r reverse search regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes terminal reverse search being blocked by Orca's app-level reload shortcut handling.
Changes:
optimizer.watchWindowShortcuts(window), which preventedKeyRwithCtrlorCmdin packaged buildsReload/Force Reloadmenu roles with explicit menu items so plain reload no longer reservesCmdOrCtrl+RForce ReloadonShift+CmdOrCtrl+RF12devtools behavior in the main window input handlerForce Reloadwith platform-correct shortcut labelsUser-visible behavior:
Ctrl+Rnow reaches the shell for reverse-i-search in terminal panesReloadremains available in the View menu, but no longer has a keyboard shortcutForce Reloadis now the only reload shortcut:⇧⌘Ron macOS andCtrl+Shift+Ron Linux/WindowsCloses #443.
Terminal reverse search:

Force Reload shortcut update:

Testing
Ran:
pnpm lintpnpm typecheckpnpm testpnpm buildAdded regression coverage for:
Ctrl/Cmd+RF12behavior after removing the Electron toolkit shortcut hookReloadandForce ReloadManual notes:
UI Notes
Minor visual change only:
Force ReloadNo layout or styling changes beyond that shortcut row.
AI Review Summary
Cross-platform compatibility review:
CmdOrCtrl+Rconflict at the menu layer instead of relying on renderer-only behavior⌘/⇧on macOS,Ctrl/Shifton other platforms)Shift+CmdOrCtrl+Raccelerator forForce ReloadSecurity audit summary:
webContentson the focused window only