Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/flaky-test-pattern-baseline.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@
1 test-skip-needs-quarantine:src/main/browser/browser-session-ua-cloudflare-live.electron.test.ts
3 test-timeout-needs-reason:config/scripts/mobile-web-app/mobile-web-app-frame-budget-sweep.test.ts
2 test-timeout-needs-reason:mobile/src/platform/dictation-capture-bridge-budget.test.tsx
1 test-timeout-needs-reason:mobile/src/session/mobile-native-chat-merged-snapshot-parity.test.ts
1 test-timeout-needs-reason:mobile/src/session/native-chat/mobile-native-chat-merged-snapshot-parity.test.ts
7 test-timeout-needs-reason:mobile/src/tasks/worktree-create-retry.test.ts
2 test-timeout-needs-reason:mobile/src/terminal/document/native-document-bundle.test.ts
1 test-timeout-needs-reason:mobile/src/test-support/rpc-recording/family-recordings.test.ts
Expand Down
28 changes: 14 additions & 14 deletions config/reliability-gates.jsonc

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions mobile/rpc-foundation/pilot-scenarios.json
Original file line number Diff line number Diff line change
Expand Up @@ -17584,7 +17584,7 @@
"id": "native-chat-stop-accepted",
"operation": "session.native-chat-stop",
"family": "session.native-chat-stop",
"sites": ["mobile/src/session/use-mobile-native-chat-stop.ts"],
"sites": ["mobile/src/session/native-chat/use-mobile-native-chat-stop.ts"],
"schedules": [],
"steps": [
{
Expand Down Expand Up @@ -17645,7 +17645,7 @@
"id": "native-chat-stop-both-rejected",
"operation": "session.native-chat-stop",
"family": "session.native-chat-stop",
"sites": ["mobile/src/session/use-mobile-native-chat-stop.ts"],
"sites": ["mobile/src/session/native-chat/use-mobile-native-chat-stop.ts"],
"schedules": [],
"steps": [
{
Expand Down Expand Up @@ -17703,7 +17703,7 @@
"id": "native-chat-stop-delivery-unknown",
"operation": "session.native-chat-stop",
"family": "session.native-chat-stop",
"sites": ["mobile/src/session/use-mobile-native-chat-stop.ts"],
"sites": ["mobile/src/session/native-chat/use-mobile-native-chat-stop.ts"],
"schedules": [],
"steps": [
{
Expand Down Expand Up @@ -20838,7 +20838,7 @@
"id": "native-chat-page-earlier",
"operation": "session.native-chat-page",
"family": "session.native-chat-page",
"sites": ["mobile/src/session/use-mobile-native-chat-session.ts"],
"sites": ["mobile/src/session/native-chat/use-mobile-native-chat-session.ts"],
"schedules": [],
"steps": [
{
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/MobileAgentSessionTabActionSheet.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ActionSheetModal } from '../components/ActionSheetModal'
import { useMobileTranslation } from '../i18n/use-mobile-translation'
import { getMobileNativeChatCliForkActions } from './mobile-native-chat-cli-fork'
import { getMobileNativeChatCliForkActions } from './native-chat/mobile-native-chat-cli-fork'
import { useMobileAllowAutoCloseActions, workerSubjectOf } from './mobile-worker-auto-close'
import type { MobileSessionController } from './use-mobile-session-controller'

Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/MobileNativeChatEmptyStateView.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Text, View } from 'react-native'
import type { NativeChatEmptyStateCopy } from '../../../src/shared/native-chat/native-chat-empty-state'
import { styles } from './mobile-native-chat-view-styles'
import { styles } from './native-chat/mobile-native-chat-view-styles'

export function MobileNativeChatEmptyStateView({ copy }: { copy: NativeChatEmptyStateCopy }) {
return (
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/MobileNativeChatScrollRootsBoundary.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component } from 'react'
import { Platform } from 'react-native'
import type { MobileNativeChatRowKeys } from './native-chat/transcript/mobile-native-chat-row-keys'
import type { MobileNativeChatScrollRoots } from './mobile-native-chat-scroll-roots'
import type { MobileNativeChatScrollRoots } from './native-chat/transcript/mobile-native-chat-scroll-roots'

type Props = {
children?: React.ReactNode
Expand Down
16 changes: 8 additions & 8 deletions mobile/src/session/MobileNativeChatView.streaming-rows.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@ import { afterEach, expect, it, vi } from 'vitest'
import type { AgentJournalRenderItem } from '../../../src/shared/agent-session/journal/agent-session-journal-types'
import { projectStructuredAgentSessionMessages } from '../../../src/shared/agent-session/view/structured-agent-session-message-projection'
import { agentJournalTurnBody } from '../../../src/shared/agent-session/lifecycle/agent-session-turn-record'
import { foldMobileNativeChatMessages } from './mobile-native-chat-render-data'
import { foldMobileNativeChatMessages } from './native-chat/mobile-native-chat-render-data'
import { useMobileStructuredAgentTurnTiming } from './use-mobile-structured-agent-turn-timing'
import { MobileNativeChatPageList } from './MobileNativeChatPageList'
import { MobileNativeChatPageList } from './native-chat/transcript/MobileNativeChatPageList'
import type {
NativeChatMessage,
NativeChatToolResultBlock
} from '../../../src/shared/native-chat/native-chat-types'
import { MobileNativeChatOverlay } from './MobileNativeChatOverlay'
import type * as MobileNativeChatItemReadModule from './mobile-native-chat-item-read'
import { MobileNativeChatOverlay } from './native-chat/MobileNativeChatOverlay'
import type * as MobileNativeChatItemReadModule from './native-chat/mobile-native-chat-item-read'
import type * as MobileNativeChatRowPropsModule from './native-chat/transcript/use-mobile-native-chat-row-props'
import type * as MobileNativeChatRowProjectionModule from './native-chat/transcript/mobile-native-chat-row-projection'
import type * as MobileNativeChatMessageDetailModule from './native-chat/transcript/use-mobile-native-chat-message-detail'
import type { MobileNativeChatController } from './mobile-native-chat-controller-contract'
import type { MobileNativeChatController } from './native-chat/mobile-native-chat-controller-contract'
import { stubRpcClient } from '../transport/rpc-client-test-stub'
import { MobileNativeChatView } from './MobileNativeChatView'
import { MobileNativeChatView } from './native-chat/MobileNativeChatView'
import { MobileNativeChatRowContent } from './native-chat/transcript/MobileNativeChatRowItemSource'

vi.mock('react-native', async () => ({
Expand Down Expand Up @@ -52,7 +52,7 @@ vi.mock('lucide-react-native', () => ({
}))
vi.mock('../components/MobileMarkdown', () => ({ MobileMarkdown: 'MobileMarkdown' }))
const itemReads = vi.hoisted(() => vi.fn())
vi.mock('./mobile-native-chat-item-read', async (importOriginal) => ({
vi.mock('./native-chat/mobile-native-chat-item-read', async (importOriginal) => ({
...(await importOriginal<typeof MobileNativeChatItemReadModule>()),
readMobileNativeChatItem: itemReads
}))
Expand Down Expand Up @@ -120,7 +120,7 @@ const rendered = vi.hoisted(() => new Map<string, number>())
vi.mock('./native-chat/transcript/MobileNativeChatMessage', async () => {
const React = await import('react')
const { useMobileNativeChatFullMessage, MobileNativeChatToolOutput } =
await import('./MobileNativeChatFullContent')
await import('./native-chat/MobileNativeChatFullContent')
const { MobileNativeChatGroupedThought } =
await import('./native-chat/transcript/MobileNativeChatReasoningRow')
return {
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/MobileSessionActiveContent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Animated, View, Text, Pressable, ActivityIndicator } from 'react-native
import { saveTerminalTextScale } from '../storage/preferences'
import { MobileBrowserPane } from '../browser/MobileBrowserPane'
import { TerminalPaneView } from './TerminalPaneView'
import { MobileNativeChatOverlay } from './MobileNativeChatOverlay'
import { MobileNativeChatOverlay } from './native-chat/MobileNativeChatOverlay'
import { MobileAgentMessageProvider } from './native-chat/transcript/MobileAgentMessageProvider'
import { useMobileAgentMessageNavigation } from './use-mobile-agent-message-navigation'
import { MobileNativeChatDictationPreviewContext } from './native-chat/composer/mobile-native-chat-dictation-preview-context'
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/TerminalPaneView.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ vi.mock('react-native', () => ({
vi.mock('../terminal/TerminalWebView', () => ({ TerminalWebView: hosts.TerminalWebView }))
vi.mock('../storage/preferences', () => ({ saveTerminalTextScale: () => Promise.resolve() }))
vi.mock('../browser/MobileBrowserPane', () => ({ MobileBrowserPane: () => null }))
vi.mock('./MobileNativeChatOverlay', () => ({ MobileNativeChatOverlay: () => null }))
vi.mock('./native-chat/MobileNativeChatOverlay', () => ({ MobileNativeChatOverlay: () => null }))
vi.mock('./MobileSessionFileReader', () => ({ FileReader: () => null }))
vi.mock('./MobileSessionMarkdownReader', () => ({ MarkdownReader: () => null }))
vi.mock('./mobile-session-styles', () => ({ styles: {} }))
Expand Down
8 changes: 4 additions & 4 deletions mobile/src/session/__mocks__/mobile-prompt-controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import type { MobileNativeChatSendOutcome } from '../native-chat/mobile-native-c
import type { RpcClient } from '../../transport/rpc-client'
import type { RpcResponse, ConnectionState } from '../../transport/types'
import type { MobileNativeChatTab } from '../native-chat/mobile-native-chat-eligibility'
import type { MobileNativeChatController } from '../mobile-native-chat-controller-contract'
import type { MobileNativeChatController } from '../native-chat/mobile-native-chat-controller-contract'
import { act, create, type ReactTestRenderer } from 'react-test-renderer'
import { vi } from 'vitest'
import { useMobileNativeChatController } from '../use-mobile-native-chat-controller'
import { MobileNativeChatOverlay } from '../MobileNativeChatOverlay'
import { useMobileNativeChatController } from '../native-chat/use-mobile-native-chat-controller'
import { MobileNativeChatOverlay } from '../native-chat/MobileNativeChatOverlay'
import { MobileNativeChatAsk } from '../native-chat/input/MobileNativeChatAsk'
import type { AskAnswerSelection } from '../../../../src/shared/native-chat-ask-answer'
import { mobileNativeChatPromptDismissals } from '../native-chat/input/mobile-native-chat-prompt-dismissals'
Expand Down Expand Up @@ -52,7 +52,7 @@ vi.mock('../use-mobile-session-view-mode', () => ({
toggleTabChatView: () => Object.assign(visible, { value: !visible.value })
})
}))
vi.mock('../use-mobile-native-chat-session-lane', () => ({
vi.mock('../native-chat/use-mobile-native-chat-session-lane', () => ({
useMobileNativeChatSessionLane: () => ({ session, structuredSession, sessionCommands })
}))
setMobileNativeChatDraftText('draft', 'ordinary message')
Expand Down
4 changes: 2 additions & 2 deletions mobile/src/session/mobile-dictation-agent-chat-start.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ vi.mock('./use-mobile-session-view-mode', () => ({
toggleTabChatView: () => {}
})
}))
vi.mock('./use-mobile-native-chat-controller', async () => {
vi.mock('./native-chat/use-mobile-native-chat-controller', async () => {
const { useMobileNativeChatActiveResolution } =
await import('./use-mobile-native-chat-active-resolution')
await import('./native-chat/use-mobile-native-chat-active-resolution')
return {
useMobileNativeChatController: (
args: Parameters<typeof useMobileNativeChatActiveResolution>[0]
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/mobile-dictation-mode-refresh.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ vi.mock('./native-chat/use-mobile-native-chat-input-lease', () => ({
clear: () => {}
})
}))
vi.mock('./use-mobile-native-chat-controller', () => ({
vi.mock('./native-chat/use-mobile-native-chat-controller', () => ({
useMobileNativeChatController: () => ({
toggleTabChatView: () => {},
showNativeChat: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ vi.mock('./native-chat/use-mobile-native-chat-input-lease', () => ({
clear: () => {}
})
}))
vi.mock('./use-mobile-native-chat-controller', () => ({
vi.mock('./native-chat/use-mobile-native-chat-controller', () => ({
useMobileNativeChatController: () => ({
nativeChatSession: { messages: [] },
toggleTabChatView: () => {},
Expand Down
6 changes: 3 additions & 3 deletions mobile/src/session/mobile-native-chat-reading-place.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import type { MobileNativeChatRowKeys } from './native-chat/transcript/mobile-native-chat-row-keys'
import {
mobileNativeChatReadingParts,
mobileNativeChatScrollRootKey,
type MobileNativeChatScrollRoots
} from './mobile-native-chat-scroll-roots'
mobileNativeChatScrollRootKey
} from './native-chat/transcript/mobile-native-chat-scroll-root-handle'
import type { MobileNativeChatScrollRoots } from './native-chat/transcript/mobile-native-chat-scroll-roots'

type Box = { top: number; bottom: number }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ vi.mock('react-native', () => ({
vi.mock('../storage/preferences', () => ({ saveTerminalTextScale: () => Promise.resolve() }))
vi.mock('../browser/MobileBrowserPane', () => ({ MobileBrowserPane: () => null }))
vi.mock('./TerminalPaneView', () => ({ TerminalPaneView: () => null }))
vi.mock('./MobileNativeChatOverlay', () => ({ MobileNativeChatOverlay: () => null }))
vi.mock('./native-chat/MobileNativeChatOverlay', () => ({ MobileNativeChatOverlay: () => null }))
vi.mock('../transport/use-host-profile', () => ({ useHostProfile: () => null }))
vi.mock('./MobileSessionFileReader', () => ({ FileReader: () => null }))
vi.mock('./MobileSessionMarkdownReader', () => ({ MarkdownReader: () => null }))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import type {
import type { MobileNativeChatVisualSource } from './native-chat/visual/mobile-native-chat-visual-read'
import type { MobileChatPermission } from './native-chat/input/mobile-native-chat-permission'
import type { MobileChatQuestion } from './native-chat/input/mobile-native-chat-question'
import type { MobileNativeChatSession } from './use-mobile-native-chat-session'
import type { MobileNativeChatSession } from './native-chat/use-mobile-native-chat-session'
import type { NativeChatLiveTurnIndicator } from '../../../src/shared/native-chat/transcript/native-chat-turn-status'
import type { NativeChatResolvedPrompt } from '../../../src/shared/native-chat/native-chat-resolution-receipt'
import type { useMobileStructuredAgentOptions } from './use-mobile-structured-agent-options'
Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/mobile-terminal-action-sheet-actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Eraser, Monitor, Smartphone } from 'lucide-react-native'
import type { ActionSheetAction } from '../components/ActionSheetModal'
import { translate } from '../i18n/mobile-i18n'
import type { MobileNativeChatTab } from './native-chat/mobile-native-chat-eligibility'
import { getMobileNativeChatToggleActions } from './mobile-native-chat-toggle-action'
import { getMobileNativeChatToggleActions } from './native-chat/mobile-native-chat-toggle-action'

type TerminalTab = MobileNativeChatTab & { id: string; terminal: string | null }

Expand Down
2 changes: 1 addition & 1 deletion mobile/src/session/mobile-terminal-layout-choice.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ vi.mock('expo-router', async () => {
vi.mock('../platform/keyboard-persisting-taps', () => ({ useKeyboardPersistingTaps: () => null }))
vi.mock('../navigation/workspace-execution-host', () => ({ useWorkspaceExecutionHost: () => ({}) }))
vi.mock('../browser/MobileBrowserPane', () => ({ MobileBrowserPane: () => null }))
vi.mock('./MobileNativeChatOverlay', () => ({ MobileNativeChatOverlay: () => null }))
vi.mock('./native-chat/MobileNativeChatOverlay', () => ({ MobileNativeChatOverlay: () => null }))
vi.mock('./MobileSessionFileReader', () => ({ FileReader: () => null }))
vi.mock('./MobileSessionMarkdownReader', () => ({ MarkdownReader: () => null }))
vi.mock('../terminal/TerminalWebView', () => ({ TerminalWebView: 'TerminalWebView' }))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { createElement } from 'react'
import { act, create, type ReactTestRenderer } from 'react-test-renderer'
import { describe, expect, it, vi } from 'vitest'
import { Keyboard } from 'react-native'
import { MobileNativeChatAsk } from './native-chat/input/MobileNativeChatAsk'
import { MobileNativeChatPermission } from './native-chat/input/MobileNativeChatPermission'
import { MobileNativeChatAsk } from './input/MobileNativeChatAsk'
import { MobileNativeChatPermission } from './input/MobileNativeChatPermission'

vi.mock('react-native', () => ({
Keyboard: { dismiss: vi.fn() },
Expand All @@ -22,7 +22,7 @@ vi.mock('lucide-react-native', () => ({
ShieldQuestion: 'ShieldQuestion',
X: 'X'
}))
vi.mock('../components/MobileMarkdown', () => ({ MobileMarkdown: 'Markdown' }))
vi.mock('../../components/MobileMarkdown', () => ({ MobileMarkdown: 'Markdown' }))

describe('rendered prompt card collapse controls', () => {
it('collapses an Ask from its header chevron without cancelling or answering it', async () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Keyboard, Pressable, StyleSheet } from 'react-native'
import { ChevronDown, X } from 'lucide-react-native'
import { colors, pressedStyle } from '../theme/mobile-theme'
import { useMobileColorScheme } from '../theme/use-mobile-color-scheme'
import { useMobileTranslation } from '../i18n/use-mobile-translation'
import { colors, pressedStyle } from '../../theme/mobile-theme'
import { useMobileColorScheme } from '../../theme/use-mobile-color-scheme'
import { useMobileTranslation } from '../../i18n/use-mobile-translation'

export function MobileNativeChatCardHeaderAction<Prompt>({
prompt,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,24 @@
import { useMemo } from 'react'
import { Pressable, Text, View } from 'react-native'
import { MobileNativeChatOwnedScrollView } from './MobileNativeChatOwnedScrollView'
import { MobileNativeChatOwnedScrollView } from './transcript/MobileNativeChatOwnedScrollView'
import { ChevronRight, FileMinus2, FilePen, FilePlus2 } from 'lucide-react-native'
import { nativeChatEditFilePatchText } from '../../../src/shared/native-chat/tools/native-chat-edit-cards'
import { nativeChatEditFilePatchText } from '../../../../src/shared/native-chat/tools/native-chat-edit-cards'
import {
nativeChatEditFileBaseName,
nativeChatEditGutterChars,
unifiedLineNumber,
type NativeChatEditFile,
type NativeChatEditLine
} from '../../../src/shared/native-chat/tools/native-chat-edit-model'
import { nativeChatToolRowVerbCopy } from './native-chat/transcript/native-chat-tool-row-verb-copy'
import { nativeChatDiffCardCopy } from './native-chat-diff-card-copy'
import { useMobileTranslation } from '../i18n/use-mobile-translation'
import { MobileSourceCopyButton } from '../components/MobileSourceCopyButton'
import { colors, pressedStyle } from '../theme/mobile-theme'
import { useMobileColorScheme } from '../theme/use-mobile-color-scheme'
import { useMobileNativeChatOpenedDetail } from './native-chat/visual/mobile-native-chat-opened-detail'
import { useMobileNativeChatDisclosure } from './native-chat/transcript/mobile-native-chat-disclosure-store'
import {
toolStyles as styles,
toolType
} from './native-chat/transcript/mobile-native-chat-tool-styles'
} from '../../../../src/shared/native-chat/tools/native-chat-edit-model'
import { nativeChatToolRowVerbCopy } from './transcript/native-chat-tool-row-verb-copy'
import { nativeChatDiffCardCopy } from '../native-chat-diff-card-copy'
import { useMobileTranslation } from '../../i18n/use-mobile-translation'
import { MobileSourceCopyButton } from '../../components/MobileSourceCopyButton'
import { colors, pressedStyle } from '../../theme/mobile-theme'
import { useMobileColorScheme } from '../../theme/use-mobile-color-scheme'
import { useMobileNativeChatOpenedDetail } from './visual/mobile-native-chat-opened-detail'
import { useMobileNativeChatDisclosure } from './transcript/mobile-native-chat-disclosure-store'
import { toolStyles as styles, toolType } from './transcript/mobile-native-chat-tool-styles'

function VerbIcon({ kind, size }: { kind: NativeChatEditFile['changeKind']; size: number }) {
useMobileColorScheme()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { useEffect, useRef } from 'react'
import { Animated, Easing, Platform, Pressable, View } from 'react-native'
import { ArrowDown } from 'lucide-react-native'
import { SHEET_CURVE } from '../components/sheet-motion-values'
import { useReducedMotionEnabled } from '../platform/use-reduced-motion'
import { colors, feedback } from '../theme/mobile-theme'
import { useMobileColorScheme } from '../theme/use-mobile-color-scheme'
import { SHEET_CURVE } from '../../components/sheet-motion-values'
import { useReducedMotionEnabled } from '../../platform/use-reduced-motion'
import { colors, feedback } from '../../theme/mobile-theme'
import { useMobileColorScheme } from '../../theme/use-mobile-color-scheme'
import { styles } from './mobile-native-chat-view-styles'
import { useMobileTranslation } from '../i18n/use-mobile-translation'
import { useMobileTranslation } from '../../i18n/use-mobile-translation'

const JUMP_EASING = Easing.bezier(...SHEET_CURVE)

Expand Down
Loading
Loading