You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(mobile): organize native chat view and transcript modules - #37054
Groups the mobile chat code into folders so related pieces are easier to find. App behavior stays the same.
What Changed
Combines two related batches: 63 file moves covering the native chat view, controller, and transcript modules. Five imports now point to concrete defining owners and four forwarding exports are removed. Callers, recording adapters, pilot scenarios, reliability paths, and test baselines follow the new locations.
Two recording adapters use erased namespace type imports; their emitted JavaScript is byte-identical to the previous version. Existing upstream test cleanup and current main changes are preserved.
Why
Organizes related code by responsibility while keeping a larger, coherent review scope. Direct owner imports avoid adding barrels or forwarding shims.
Linked Issue
N/A — internal repository organization work; no existing linked issue.
Visual Proof
N/A — file organization and import paths only; no visual or interaction change.
Testing
I manually tested these changes locally
Automated tests updated for moved paths; no new behavior to test
On macOS: 48 mobile test files / 418 tests and two consumer files / 19 tests passed. Mobile production and test typechecks, React Doctor, changed-code quality, formatting, reliability, path-literal, and test-runner checks passed. The final erased-type amendment preserves emitted JavaScript exactly; both mobile typechecks and static checks were rerun. Fresh hosted CI on the final commit passed, including all twelve Node test shards and mobile verification.
Review
Two independent source audits checked behavior preservation, concrete import owners, hooks, literals, mocks, and moved callers. The unchanged refactor merge gate and whole-tree comparison run against current main before merge.
Agent skill upstream boundary
Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.
Notes
No runtime API, wire format, platform path semantics, or remote compatibility changes. Mobile behavior remains unchanged. Tests and validation ran without bringing app windows into focus.
Checklist
This PR is focused on the mobile native-chat domain (63 moves across two related batches)
I explained what changed and why
Visual proof is N/A with reason
Self-reviewed for correctness, security, and performance
Cross-platform, SSH/remote, and path/shortcut impact considered
Focused local validation and the applicable hosted CI checks pass
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
Walkthrough
The mobile native-chat modules now use import paths that match their reorganized directory structure. Related session references, tests, fixtures, reliability-gate entries, baseline paths, and pilot-scenario paths were updated. The summaries report no changes to runtime logic or test expectations, except for removed fixture and scroll-roots re-exports.
Merge Risk: Minimal · up to d946b
No actionable merge-blocking risk was identified in the native-chat reorganization.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the primary change: organizing mobile native chat view and transcript modules.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description covers the required sections, explains the refactor and rationale, documents the lack of visual changes, lists testing results, and addresses review, compatibility, and checklist items…
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 50 files. (68 skipped: 3 unsupported, 65 over the file limit.)
Full details: Description check
Explanation
The description covers the required sections, explains the refactor and rationale, documents the lack of visual changes, lists testing results, and addresses review, compatibility, and checklist items. The linked issue is marked N/A, which is acceptable only if the author is an internal maintainer under the template’s exception.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Groups the mobile chat code into folders so related pieces are easier to find. App behavior stays the same.
What Changed
Combines two related batches: 63 file moves covering the native chat view, controller, and transcript modules. Five imports now point to concrete defining owners and four forwarding exports are removed. Callers, recording adapters, pilot scenarios, reliability paths, and test baselines follow the new locations.
Two recording adapters use erased namespace type imports; their emitted JavaScript is byte-identical to the previous version. Existing upstream test cleanup and current main changes are preserved.
Why
Organizes related code by responsibility while keeping a larger, coherent review scope. Direct owner imports avoid adding barrels or forwarding shims.
Linked Issue
N/A — internal repository organization work; no existing linked issue.
Visual Proof
N/A — file organization and import paths only; no visual or interaction change.
Testing
On macOS: 48 mobile test files / 418 tests and two consumer files / 19 tests passed. Mobile production and test typechecks, React Doctor, changed-code quality, formatting, reliability, path-literal, and test-runner checks passed. The final erased-type amendment preserves emitted JavaScript exactly; both mobile typechecks and static checks were rerun. Fresh hosted CI on the final commit passed, including all twelve Node test shards and mobile verification.
Review
Two independent source audits checked behavior preservation, concrete import owners, hooks, literals, mocks, and moved callers. The unchanged refactor merge gate and whole-tree comparison run against current main before merge.
Agent skill upstream boundary
Notes
No runtime API, wire format, platform path semantics, or remote compatibility changes. Mobile behavior remains unchanged. Tests and validation ran without bringing app windows into focus.
Checklist