Skip to content

refactor: group Claude structured session owners - #37036

Merged
nwparker merged 1 commit into
mainfrom
module-organization/pr38-pr39-pr41-claude-structured
Nov 1, 2026
Merged

nwparker merged 1 commit into
mainfrom
module-organization/pr38-pr39-pr41-claude-structured

Conversation

@nwparker

@nwparker nwparker commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Keep Claude session code near the part of the session it owns, so changes are easier to find and review.

What Changed

Combine the structured Claude launch/options, journal and session-lifecycle moves into one coherent refactor: 97 files (35 production owners and 62 test/support files). Launch/options owners live in claude/structured/launch/, journal owners in claude/structured/journal/, and session lifecycle owners in claude/structured/.

Callers import concrete defining owners. Remove three forwarding declarations; preserve namespace identity, mocks, runtime evaluation order and production function bodies. Retarget one moved fixture URL, timing keys and flaky-test paths. Select current or historical owner paths from each release checkout for the Claude translator and previously moved failure modules. Keep the historical fallbacks and explicitly admit the old Claude path in the path-literal baseline. A real-writer regression test treats the current workspace as a future release without copying source or dependencies.

Ten original tracker paths were already deleted upstream; this PR does not recreate them or count them as moves.

Why

These three tasks share 49 module edges. Reviewing their moves together keeps the complete Claude ownership boundary in one PR and avoids three rounds of caller churn.

Linked Issue

Internal module-organization tracker; no new issue.

Visual Proof

N/A — module organization only; no UI or interaction change.

Testing

Local node/web/CLI typechecks, import boundaries, changed-code quality and normal commit hooks passed. The initial related run passed 1,348 test files and failed four tests across two compiled-CLI suites; rebuilding the CLI and rerunning both suites plus amended-import consumers passed all 13 files / 131 tests. Focused lint, format and the historical path-literal ratchet pass after the reviewed import-only/baseline-only amendment. The original composite remains 26/29; it was not rerun in full.

The new current-layout test reproduced the historical-path failure, then passed with the layout-aware loader. That test and all six cases across three real old releases pass (2 files / 7 tests). Focused e2e typecheck, lint, format, runner classification and path-literal ratchet pass. An intermediate forbidden type-query lint diagnostic was resolved with an erased namespace type import; its emitted runtime JavaScript is unchanged.

Tests run on macOS arm64 with ORCA_BACKGROUND_LAUNCH=1; Linux, Windows and remote execution are covered by hosted checks rather than local execution.

  • I manually tested these changes locally
  • Existing tests moved and imports retargeted; no redundant behavior tests added.

Review

Two independent source audits cover bodies, imports, forwarding removal, namespace/mock identity and relocated resources. Fresh current-main preservation and the unchanged live refactor merge gate remain required before merge.

Agent skill upstream boundary

  • Not applicable; no upstream skill-installer content copied or translated.

Notes

No wire names, platform policy or remote-version behavior changes. Historical release-checkout paths remain compatible with the released module layout.

Checklist

  • Focused on one Claude ownership boundary across three tracker tasks
  • Explained what changed and why
  • N/A visual proof with reason
  • Self-reviewed for correctness, security and performance
  • Cross-platform, remote and mobile impact considered
  • Local validation and hosted required checks pass

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8cb3cd06-71f6-4234-a5ea-221a62ae2db7
Commits

Reviewing files that changed from the base of the PR and between f6a8ffe and 3310aad.

Files selected for processing: 228
  • config/flaky-test-pattern-baseline.txt
  • config/path-literal-baseline.txt
  • config/scripts/ci-shard-timings.json
  • src/main/ai-vault/structured-session-ownership.ts
  • src/main/claude-accounts/claude-launch-routing.test.ts
  • src/main/claude/claude-adapter-capture-replay.test.ts
  • src/main/claude/claude-api-retry-idle-sweep.test.ts
  • src/main/claude/claude-api-retry-row.test.ts
  • src/main/claude/claude-assistant-failures.ts
  • src/main/claude/claude-at-rest-commands.ts
  • src/main/claude/claude-background-task-turn-resumption.test.ts
  • src/main/claude/claude-background-wake-retention.test.ts
  • src/main/claude/claude-can-use-tool-test-support.ts
  • src/main/claude/claude-child-tool-queries.ts
  • src/main/claude/claude-child-work-evidence-retention.test.ts
  • src/main/claude/claude-child-work-evidence.ts
  • src/main/claude/claude-child-work-producer-harness.test-fixture.ts
  • src/main/claude/claude-cli-flag-prewarm.ts
  • src/main/claude/claude-close-turn-end.test.ts
  • src/main/claude/claude-command-lifecycle-frames.test.ts
  • src/main/claude/claude-command-lifecycle.test.ts
  • src/main/claude/claude-command-lifecycle.ts
  • src/main/claude/claude-command-turn.test.ts
  • src/main/claude/claude-command-turn.ts
  • src/main/claude/claude-context-facts.ts
  • src/main/claude/claude-context-usage-restart.test.ts
  • src/main/claude/claude-context-usage-test-support.ts
  • src/main/claude/claude-context-usage-unloaded-turn.test.ts
  • src/main/claude/claude-fold-steer-receipt.test.ts
  • src/main/claude/claude-informational-row.test.ts
  • src/main/claude/claude-informational-row.ts
  • src/main/claude/claude-journal-translator-contract.ts
  • src/main/claude/claude-journal-turn-scope.test.ts
  • src/main/claude/claude-message-journaling.ts
  • src/main/claude/claude-model-catalog-probe.test.ts
  • src/main/claude/claude-model-catalog-probe.ts
  • src/main/claude/claude-naming-generation.ts
  • src/main/claude/claude-naming-invocation.ts
  • src/main/claude/claude-plan-approval-mode.test.ts
  • src/main/claude/claude-replay-turn-resolution.ts
  • src/main/claude/claude-result-journaling.ts
  • src/main/claude/claude-result-outcome.ts
  • src/main/claude/claude-session-state-turn-over.ts
  • src/main/claude/claude-stop-ack-race.test.ts
  • src/main/claude/claude-stream-json-connection.test.ts
  • src/main/claude/claude-stream-json-connection.ts
  • src/main/claude/claude-streamed-block-identity.ts
  • src/main/claude/claude-streamed-thinking.ts
  • src/main/claude/claude-structured-launch-home-perf.test.ts
  • src/main/claude/claude-structured-location-support.ts
  • src/main/claude/claude-structured-result-control-overlap.test.ts
  • src/main/claude/claude-subagent-permission-request.test.ts
  • src/main/claude/claude-subagent-resume-after-restart.test.ts
  • src/main/claude/claude-subagent-task-frames.ts
  • src/main/claude/claude-supervised-stop-real-cli.test.ts
  • src/main/claude/claude-thread-goal-journaling.test.ts
  • src/main/claude/claude-thread-goal.ts
  • src/main/claude/claude-transcript-catch-up-test-support.ts
  • src/main/claude/claude-transcript-catch-up.test.ts
  • src/main/claude/claude-transcript-import-plan.ts
  • src/main/claude/claude-transcript-tail.ts
  • src/main/claude/claude-turn-opening.ts
  • src/main/claude/claude-turn-outcome.test.ts
  • src/main/claude/claude-turn-ownership.test.ts
  • src/main/claude/claude-turn-resumption.test.ts
  • src/main/claude/claude-usage-limits.test.ts
  • src/main/claude/claude-usage-limits.ts
  • src/main/claude/structured/claude-structured-acquisition-release.ts
  • src/main/claude/structured/claude-structured-agent-definition.ts
  • src/main/claude/structured/claude-structured-child-work-captures.test.ts
  • src/main/claude/structured/claude-structured-child-work-producer.test.ts
  • src/main/claude/structured/claude-structured-command-dispatch.ts
  • src/main/claude/structured/claude-structured-content-parts.test.ts
  • src/main/claude/structured/claude-structured-control-actions.test.ts
  • src/main/claude/structured/claude-structured-control-actions.ts
  • src/main/claude/structured/claude-structured-conversation-stop.test.ts
  • src/main/claude/structured/claude-structured-dispatch-admission.test.ts
  • src/main/claude/structured/claude-structured-dispatch-attachment-rejection.test.ts
  • src/main/claude/structured/claude-structured-dispatch-boundary.test.ts
  • src/main/claude/structured/claude-structured-dispatch-content.test.ts
  • src/main/claude/structured/claude-structured-dispatch-content.ts
  • src/main/claude/structured/claude-structured-dispatch-queue-boundary.test.ts
  • src/main/claude/structured/claude-structured-dispatch-test-support.ts
  • src/main/claude/structured/claude-structured-dispatch-waiters.ts
  • src/main/claude/structured/claude-structured-dispatch.test.ts
  • src/main/claude/structured/claude-structured-dispatch.ts
  • src/main/claude/structured/claude-structured-effort-default-at-rest.test.ts
  • src/main/claude/structured/claude-structured-effort-reporting.test.ts
  • src/main/claude/structured/claude-structured-event-delivery.ts
  • src/main/claude/structured/claude-structured-execution-observations.ts
  • src/main/claude/structured/claude-structured-execution-recording.test.ts
  • src/main/claude/structured/claude-structured-in-turn-stop.test.ts
  • src/main/claude/structured/claude-structured-inbound-control.test.ts
  • src/main/claude/structured/claude-structured-inbound-control.ts
  • src/main/claude/structured/claude-structured-init-proof.ts
  • src/main/claude/structured/claude-structured-live-provider-process.test.ts
  • src/main/claude/structured/claude-structured-option-confirmation.test.ts
  • src/main/claude/structured/claude-structured-queued-stop.test.ts
  • src/main/claude/structured/claude-structured-rate-limit-retry.test.ts
  • src/main/claude/structured/claude-structured-real-cli-fold.test.ts
  • src/main/claude/structured/claude-structured-real-cli-rewind.test.ts
  • src/main/claude/structured/claude-structured-real-cli-stop-task.test.ts
  • src/main/claude/structured/claude-structured-real-cli-visuals.test.ts
  • src/main/claude/structured/claude-structured-real-cli.test.ts
  • src/main/claude/structured/claude-structured-reasoning-lifecycle.test.ts
  • src/main/claude/structured/claude-structured-reasoning.test.ts
  • src/main/claude/structured/claude-structured-requested-stop.test.ts
  • src/main/claude/structured/claude-structured-resume-point.test.ts
  • src/main/claude/structured/claude-structured-resume-point.ts
  • src/main/claude/structured/claude-structured-session-acquisition-processless.test.ts
  • src/main/claude/structured/claude-structured-session-acquisition.ts
  • src/main/claude/structured/claude-structured-session-adapter-turns.test.ts
  • src/main/claude/structured/claude-structured-session-adapter.test.ts
  • src/main/claude/structured/claude-structured-session-adapter.ts
  • src/main/claude/structured/claude-structured-session-close.test.ts
  • src/main/claude/structured/claude-structured-session-close.ts
  • src/main/claude/structured/claude-structured-session-commands.test.ts
  • src/main/claude/structured/claude-structured-session-exit-blame.test.ts
  • src/main/claude/structured/claude-structured-session-exit-lifecycle.ts
  • src/main/claude/structured/claude-structured-session-open.ts
  • src/main/claude/structured/claude-structured-session-publication.ts
  • src/main/claude/structured/claude-structured-session-reading-control.test.ts
  • src/main/claude/structured/claude-structured-session-recovery.test.ts
  • src/main/claude/structured/claude-structured-session-startup.test.ts
  • src/main/claude/structured/claude-structured-session-startup.ts
  • src/main/claude/structured/claude-structured-session-state.ts
  • src/main/claude/structured/claude-structured-session-test-support.ts
  • src/main/claude/structured/claude-structured-sign-in.test.ts
  • src/main/claude/structured/claude-structured-startup-settled-test-support.ts
  • src/main/claude/structured/claude-structured-turn-resume-point.test.ts
  • src/main/claude/structured/journal/claude-structured-item-translation.ts
  • src/main/claude/structured/journal/claude-structured-journal-prompt-cards.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-prompt-retry.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-prompts.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-background-tasks.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-context-usage.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-subagents.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-turn-timing.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation.ts
  • src/main/claude/structured/journal/claude-structured-prompt-items.test.ts
  • src/main/claude/structured/journal/claude-structured-prompt-items.ts
  • src/main/claude/structured/journal/claude-structured-prompt-ownership.test.ts
  • src/main/claude/structured/journal/claude-structured-prompt-ownership.ts
  • src/main/claude/structured/journal/claude-structured-prompt-replies.ts
  • src/main/claude/structured/journal/claude-structured-session-journal-control.ts
  • src/main/claude/structured/launch/claude-structured-acquisition-launch.ts
  • src/main/claude/structured/launch/claude-structured-applied-options.test.ts
  • src/main/claude/structured/launch/claude-structured-catalog-listing.ts
  • src/main/claude/structured/launch/claude-structured-child-env.test.ts
  • src/main/claude/structured/launch/claude-structured-child-env.ts
  • src/main/claude/structured/launch/claude-structured-launch-account-routing.test.ts
  • src/main/claude/structured/launch/claude-structured-launch-args.ts
  • src/main/claude/structured/launch/claude-structured-launch-flags.ts
  • src/main/claude/structured/launch/claude-structured-launch-home.ts
  • src/main/claude/structured/launch/claude-structured-launch-resolution.test.ts
  • src/main/claude/structured/launch/claude-structured-launch-resolution.ts
  • src/main/claude/structured/launch/claude-structured-launch-visuals.test.ts
  • src/main/claude/structured/launch/claude-structured-location-support.ts
  • src/main/claude/structured/launch/claude-structured-message-options.test.ts
  • src/main/claude/structured/launch/claude-structured-message-options.ts
  • src/main/claude/structured/launch/claude-structured-model-catalog.ts
  • src/main/claude/structured/launch/claude-structured-model-confirmation.test.ts
  • src/main/claude/structured/launch/claude-structured-options-context-window.test.ts
  • src/main/claude/structured/launch/claude-structured-options.test.ts
  • src/main/claude/structured/launch/claude-structured-options.ts
  • src/main/claude/structured/launch/claude-structured-provider-fallback.test.ts
  • src/main/claude/structured/launch/claude-structured-provider-fallback.ts
  • src/main/claude/structured/launch/claude-structured-real-cli-options.test.ts
  • src/main/claude/structured/launch/claude-structured-session-acquisition-options.ts
  • src/main/claude/structured/launch/claude-structured-session-options.ts
  • src/main/claude/structured/launch/claude-structured-spawn-options.test.ts
  • src/main/claude/structured/launch/claude-structured-spawn-options.ts
  • src/main/native-chat/agent-session-journal/journal-projection-streams.test.ts
  • src/main/native-chat/agent-session-journal/journal-received-content.test.ts
  • src/main/native-chat/agent-session-wire/hook-outcome-rows.test.ts
  • src/main/native-chat/agent-session-wire/mobile-queued-edit-host.test-fixture.ts
  • src/main/native-chat/agent-session-wire/provider-turn-activity-routing.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-adapter-router-test-support.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-at-rest-command-rig.test-fixture.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-compact-stop.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-echo-working.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-hung-start-stop.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-opening-send-hold.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-queued-stop.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-root-exit.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-contract-test-actions.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-contract-test-fixture.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-ends-session.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-exit-ends-record.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-note-end.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-queue-cards.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-turn-end.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-subagent-row.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-command-publication.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-ended-prompt-cancel.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-message-choices.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-options-read.accepted-inputs.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-options-read.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-outgrown-child.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-owed-work-release.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-receiving-auth.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-restart-provider-output.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-status-feed.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-stop-deadline.test-fixture.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-subagent-recency.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-view-start-after-failed-start.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-workspace-sleep-lifetime.test.ts
  • src/main/pi/rpc-message-dispatch.ts
  • src/main/pi/rpc-prompt.ts
  • src/main/runtime/claude-structured-fake-connection-test-fixture.ts
  • src/main/runtime/rpc/methods/structured-agent-session-restart-dismiss-fence.test.ts
  • src/main/runtime/runtime-client-agent-launch-settings-durability.test.ts
  • src/main/runtime/structured-agent-install-refresh.test.ts
  • src/main/runtime/structured-agent-launch-composition.test-support.ts
  • src/main/runtime/structured-agent-launch-parity.test.ts
  • src/main/runtime/structured-agent-runtime-metadata.ts
  • src/main/runtime/structured-agent-runtime-registrations.ts
  • src/main/runtime/structured-chat-naming-agent-launch.ts
  • src/main/runtime/structured-claude-naming-test-support.ts
  • src/main/runtime/structured-claude-pending-rewind.test.ts
  • src/main/runtime/structured-claude-runtime-adapter.ts
  • src/main/runtime/structured-claude-thinking-display-refusal.test.ts
  • src/shared/agent-launch-picker-legacy-permission.test.ts
  • tests/e2e/cross-version-wire/released-chat-current-layout.unit.test.ts
  • tests/e2e/cross-version-wire/released-chat-writers.ts
  • tests/e2e/structured-agent-session-launch-continuation.unit.test.ts
  • tests/e2e/structured-permission-report-publication.unit.test.ts
Files with no reviewable changes: 4
  • src/main/claude/claude-structured-location-support.ts
  • src/main/claude/structured/claude-structured-dispatch-attachment-rejection.test.ts
  • src/main/claude/structured/claude-structured-live-provider-process.test.ts
  • src/main/claude/structured/claude-structured-conversation-stop.test.ts
Files skipped from review as they are similar to previous changes: 3
  • config/path-literal-baseline.txt
  • src/main/claude/structured/claude-structured-session-state.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-stop-deadline.test-fixture.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

Claude structured-session modules and their consumers now use nested structured, journal, and launch paths. Import paths in application code, tests, and CI configuration were updated. Recorded test counts and timing values remain unchanged. The supportsClaudeStructuredLocation function moved to the launch module, and several module re-exports were removed. The cross-version loader now supports the new paths and falls back to legacy paths when needed. A current-layout test was added.

Merge Risk: Minimal · up to 3310a

No actionable merge-blocking risk was established; normal checks remain appropriate.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: grouping Claude structured session owners by ownership.
Description check Passed The description is mostly complete and follows the repository template. It explains the refactor, rationale, testing, compatibility impact, and review status. The Linked Issue section does not provide…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description is mostly complete and follows the repository template. It explains the refactor, rationale, testing, compatibility impact, and review status. The Linked Issue section does not provide a concrete issue reference, but the description identifies this as an internal tracker item and is otherwise sufficiently detailed.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 50 files. (174 skipped: 3 unsupported, 171 over the file limit.)

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: be8096b6-aa2f-44dc-8b0b-3212311bcfff
Commits

Reviewing files that changed from the base of the PR and between 70256ea and f6a8ffe.

Files selected for processing: 227
  • config/flaky-test-pattern-baseline.txt
  • config/path-literal-baseline.txt
  • config/scripts/ci-shard-timings.json
  • src/main/ai-vault/structured-session-ownership.ts
  • src/main/claude-accounts/claude-launch-routing.test.ts
  • src/main/claude/claude-adapter-capture-replay.test.ts
  • src/main/claude/claude-api-retry-idle-sweep.test.ts
  • src/main/claude/claude-api-retry-row.test.ts
  • src/main/claude/claude-assistant-failures.ts
  • src/main/claude/claude-at-rest-commands.ts
  • src/main/claude/claude-background-task-turn-resumption.test.ts
  • src/main/claude/claude-background-wake-retention.test.ts
  • src/main/claude/claude-can-use-tool-test-support.ts
  • src/main/claude/claude-child-tool-queries.ts
  • src/main/claude/claude-child-work-evidence-retention.test.ts
  • src/main/claude/claude-child-work-evidence.ts
  • src/main/claude/claude-child-work-producer-harness.test-fixture.ts
  • src/main/claude/claude-cli-flag-prewarm.ts
  • src/main/claude/claude-close-turn-end.test.ts
  • src/main/claude/claude-command-lifecycle-frames.test.ts
  • src/main/claude/claude-command-lifecycle.test.ts
  • src/main/claude/claude-command-lifecycle.ts
  • src/main/claude/claude-command-turn.test.ts
  • src/main/claude/claude-command-turn.ts
  • src/main/claude/claude-context-facts.ts
  • src/main/claude/claude-context-usage-restart.test.ts
  • src/main/claude/claude-context-usage-test-support.ts
  • src/main/claude/claude-context-usage-unloaded-turn.test.ts
  • src/main/claude/claude-fold-steer-receipt.test.ts
  • src/main/claude/claude-informational-row.test.ts
  • src/main/claude/claude-informational-row.ts
  • src/main/claude/claude-journal-translator-contract.ts
  • src/main/claude/claude-journal-turn-scope.test.ts
  • src/main/claude/claude-message-journaling.ts
  • src/main/claude/claude-model-catalog-probe.test.ts
  • src/main/claude/claude-model-catalog-probe.ts
  • src/main/claude/claude-naming-generation.ts
  • src/main/claude/claude-naming-invocation.ts
  • src/main/claude/claude-plan-approval-mode.test.ts
  • src/main/claude/claude-replay-turn-resolution.ts
  • src/main/claude/claude-result-journaling.ts
  • src/main/claude/claude-result-outcome.ts
  • src/main/claude/claude-session-state-turn-over.ts
  • src/main/claude/claude-stop-ack-race.test.ts
  • src/main/claude/claude-stream-json-connection.test.ts
  • src/main/claude/claude-stream-json-connection.ts
  • src/main/claude/claude-streamed-block-identity.ts
  • src/main/claude/claude-streamed-thinking.ts
  • src/main/claude/claude-structured-launch-home-perf.test.ts
  • src/main/claude/claude-structured-location-support.ts
  • src/main/claude/claude-structured-result-control-overlap.test.ts
  • src/main/claude/claude-subagent-permission-request.test.ts
  • src/main/claude/claude-subagent-resume-after-restart.test.ts
  • src/main/claude/claude-subagent-task-frames.ts
  • src/main/claude/claude-supervised-stop-real-cli.test.ts
  • src/main/claude/claude-thread-goal-journaling.test.ts
  • src/main/claude/claude-thread-goal.ts
  • src/main/claude/claude-transcript-catch-up-test-support.ts
  • src/main/claude/claude-transcript-catch-up.test.ts
  • src/main/claude/claude-transcript-import-plan.ts
  • src/main/claude/claude-transcript-tail.ts
  • src/main/claude/claude-turn-opening.ts
  • src/main/claude/claude-turn-outcome.test.ts
  • src/main/claude/claude-turn-ownership.test.ts
  • src/main/claude/claude-turn-resumption.test.ts
  • src/main/claude/claude-usage-limits.test.ts
  • src/main/claude/claude-usage-limits.ts
  • src/main/claude/structured/claude-structured-acquisition-release.ts
  • src/main/claude/structured/claude-structured-agent-definition.ts
  • src/main/claude/structured/claude-structured-child-work-captures.test.ts
  • src/main/claude/structured/claude-structured-child-work-producer.test.ts
  • src/main/claude/structured/claude-structured-command-dispatch.ts
  • src/main/claude/structured/claude-structured-content-parts.test.ts
  • src/main/claude/structured/claude-structured-control-actions.test.ts
  • src/main/claude/structured/claude-structured-control-actions.ts
  • src/main/claude/structured/claude-structured-conversation-stop.test.ts
  • src/main/claude/structured/claude-structured-dispatch-admission.test.ts
  • src/main/claude/structured/claude-structured-dispatch-attachment-rejection.test.ts
  • src/main/claude/structured/claude-structured-dispatch-boundary.test.ts
  • src/main/claude/structured/claude-structured-dispatch-content.test.ts
  • src/main/claude/structured/claude-structured-dispatch-content.ts
  • src/main/claude/structured/claude-structured-dispatch-queue-boundary.test.ts
  • src/main/claude/structured/claude-structured-dispatch-test-support.ts
  • src/main/claude/structured/claude-structured-dispatch-waiters.ts
  • src/main/claude/structured/claude-structured-dispatch.test.ts
  • src/main/claude/structured/claude-structured-dispatch.ts
  • src/main/claude/structured/claude-structured-effort-default-at-rest.test.ts
  • src/main/claude/structured/claude-structured-effort-reporting.test.ts
  • src/main/claude/structured/claude-structured-event-delivery.ts
  • src/main/claude/structured/claude-structured-execution-observations.ts
  • src/main/claude/structured/claude-structured-execution-recording.test.ts
  • src/main/claude/structured/claude-structured-in-turn-stop.test.ts
  • src/main/claude/structured/claude-structured-inbound-control.test.ts
  • src/main/claude/structured/claude-structured-inbound-control.ts
  • src/main/claude/structured/claude-structured-init-proof.ts
  • src/main/claude/structured/claude-structured-live-provider-process.test.ts
  • src/main/claude/structured/claude-structured-option-confirmation.test.ts
  • src/main/claude/structured/claude-structured-queued-stop.test.ts
  • src/main/claude/structured/claude-structured-rate-limit-retry.test.ts
  • src/main/claude/structured/claude-structured-real-cli-fold.test.ts
  • src/main/claude/structured/claude-structured-real-cli-rewind.test.ts
  • src/main/claude/structured/claude-structured-real-cli-stop-task.test.ts
  • src/main/claude/structured/claude-structured-real-cli-visuals.test.ts
  • src/main/claude/structured/claude-structured-real-cli.test.ts
  • src/main/claude/structured/claude-structured-reasoning-lifecycle.test.ts
  • src/main/claude/structured/claude-structured-reasoning.test.ts
  • src/main/claude/structured/claude-structured-requested-stop.test.ts
  • src/main/claude/structured/claude-structured-resume-point.test.ts
  • src/main/claude/structured/claude-structured-resume-point.ts
  • src/main/claude/structured/claude-structured-session-acquisition-processless.test.ts
  • src/main/claude/structured/claude-structured-session-acquisition.ts
  • src/main/claude/structured/claude-structured-session-adapter-turns.test.ts
  • src/main/claude/structured/claude-structured-session-adapter.test.ts
  • src/main/claude/structured/claude-structured-session-adapter.ts
  • src/main/claude/structured/claude-structured-session-close.test.ts
  • src/main/claude/structured/claude-structured-session-close.ts
  • src/main/claude/structured/claude-structured-session-commands.test.ts
  • src/main/claude/structured/claude-structured-session-exit-blame.test.ts
  • src/main/claude/structured/claude-structured-session-exit-lifecycle.ts
  • src/main/claude/structured/claude-structured-session-open.ts
  • src/main/claude/structured/claude-structured-session-publication.ts
  • src/main/claude/structured/claude-structured-session-reading-control.test.ts
  • src/main/claude/structured/claude-structured-session-recovery.test.ts
  • src/main/claude/structured/claude-structured-session-startup.test.ts
  • src/main/claude/structured/claude-structured-session-startup.ts
  • src/main/claude/structured/claude-structured-session-state.ts
  • src/main/claude/structured/claude-structured-session-test-support.ts
  • src/main/claude/structured/claude-structured-sign-in.test.ts
  • src/main/claude/structured/claude-structured-startup-settled-test-support.ts
  • src/main/claude/structured/claude-structured-turn-resume-point.test.ts
  • src/main/claude/structured/journal/claude-structured-item-translation.ts
  • src/main/claude/structured/journal/claude-structured-journal-prompt-cards.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-prompt-retry.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-prompts.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-background-tasks.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-context-usage.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-subagents.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation-turn-timing.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation.test.ts
  • src/main/claude/structured/journal/claude-structured-journal-translation.ts
  • src/main/claude/structured/journal/claude-structured-prompt-items.test.ts
  • src/main/claude/structured/journal/claude-structured-prompt-items.ts
  • src/main/claude/structured/journal/claude-structured-prompt-ownership.test.ts
  • src/main/claude/structured/journal/claude-structured-prompt-ownership.ts
  • src/main/claude/structured/journal/claude-structured-prompt-replies.ts
  • src/main/claude/structured/journal/claude-structured-session-journal-control.ts
  • src/main/claude/structured/launch/claude-structured-acquisition-launch.ts
  • src/main/claude/structured/launch/claude-structured-applied-options.test.ts
  • src/main/claude/structured/launch/claude-structured-catalog-listing.ts
  • src/main/claude/structured/launch/claude-structured-child-env.test.ts
  • src/main/claude/structured/launch/claude-structured-child-env.ts
  • src/main/claude/structured/launch/claude-structured-launch-account-routing.test.ts
  • src/main/claude/structured/launch/claude-structured-launch-args.ts
  • src/main/claude/structured/launch/claude-structured-launch-flags.ts
  • src/main/claude/structured/launch/claude-structured-launch-home.ts
  • src/main/claude/structured/launch/claude-structured-launch-resolution.test.ts
  • src/main/claude/structured/launch/claude-structured-launch-resolution.ts
  • src/main/claude/structured/launch/claude-structured-launch-visuals.test.ts
  • src/main/claude/structured/launch/claude-structured-location-support.ts
  • src/main/claude/structured/launch/claude-structured-message-options.test.ts
  • src/main/claude/structured/launch/claude-structured-message-options.ts
  • src/main/claude/structured/launch/claude-structured-model-catalog.ts
  • src/main/claude/structured/launch/claude-structured-model-confirmation.test.ts
  • src/main/claude/structured/launch/claude-structured-options-context-window.test.ts
  • src/main/claude/structured/launch/claude-structured-options.test.ts
  • src/main/claude/structured/launch/claude-structured-options.ts
  • src/main/claude/structured/launch/claude-structured-provider-fallback.test.ts
  • src/main/claude/structured/launch/claude-structured-provider-fallback.ts
  • src/main/claude/structured/launch/claude-structured-real-cli-options.test.ts
  • src/main/claude/structured/launch/claude-structured-session-acquisition-options.ts
  • src/main/claude/structured/launch/claude-structured-session-options.ts
  • src/main/claude/structured/launch/claude-structured-spawn-options.test.ts
  • src/main/claude/structured/launch/claude-structured-spawn-options.ts
  • src/main/native-chat/agent-session-journal/journal-projection-streams.test.ts
  • src/main/native-chat/agent-session-journal/journal-received-content.test.ts
  • src/main/native-chat/agent-session-wire/hook-outcome-rows.test.ts
  • src/main/native-chat/agent-session-wire/mobile-queued-edit-host.test-fixture.ts
  • src/main/native-chat/agent-session-wire/provider-turn-activity-routing.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-adapter-router-test-support.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-at-rest-command-rig.test-fixture.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-compact-stop.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-echo-working.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-hung-start-stop.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-opening-send-hold.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-queued-stop.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-root-exit.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-contract-test-actions.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-contract-test-fixture.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-ends-session.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-exit-ends-record.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-note-end.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-queue-cards.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-stop-turn-end.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-claude-subagent-row.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-command-publication.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-ended-prompt-cancel.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-message-choices.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-options-read.accepted-inputs.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-options-read.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-outgrown-child.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-owed-work-release.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-receiving-auth.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-restart-provider-output.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-status-feed.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-stop-deadline.test-fixture.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-subagent-recency.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-view-start-after-failed-start.test.ts
  • src/main/native-chat/agent-session-wire/structured-agent-session-workspace-sleep-lifetime.test.ts
  • src/main/pi/rpc-message-dispatch.ts
  • src/main/pi/rpc-prompt.ts
  • src/main/runtime/claude-structured-fake-connection-test-fixture.ts
  • src/main/runtime/rpc/methods/structured-agent-session-restart-dismiss-fence.test.ts
  • src/main/runtime/runtime-client-agent-launch-settings-durability.test.ts
  • src/main/runtime/structured-agent-install-refresh.test.ts
  • src/main/runtime/structured-agent-launch-composition.test-support.ts
  • src/main/runtime/structured-agent-launch-parity.test.ts
  • src/main/runtime/structured-agent-runtime-metadata.ts
  • src/main/runtime/structured-agent-runtime-registrations.ts
  • src/main/runtime/structured-chat-naming-agent-launch.ts
  • src/main/runtime/structured-claude-naming-test-support.ts
  • src/main/runtime/structured-claude-pending-rewind.test.ts
  • src/main/runtime/structured-claude-runtime-adapter.ts
  • src/main/runtime/structured-claude-thinking-display-refusal.test.ts
  • src/shared/agent-launch-picker-legacy-permission.test.ts
  • tests/e2e/cross-version-wire/released-chat-writers.ts
  • tests/e2e/structured-agent-session-launch-continuation.unit.test.ts
  • tests/e2e/structured-permission-report-publication.unit.test.ts
Files with no reviewable changes: 1
  • src/main/claude/claude-structured-location-support.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

@nwparker
nwparker force-pushed the module-organization/pr38-pr39-pr41-claude-structured branch from f6a8ffe to 3310aad Compare November 1, 2026 14:00
@nwparker
nwparker merged commit b29e7f5 into main Nov 1, 2026
60 checks passed
nwparker added a commit that referenced this pull request Nov 2, 2026
…fines them

v1.4.246 is the first release cut after #36909, #36979, #37036 and #37070 moved
the agent-session modules, so suites that imported the old paths from the
newest release failed with ERR_MODULE_NOT_FOUND for every PR running
cross-version wire. importReleaseCheckoutModule now resolves a moved module to
the path the checked-out release ships, from one table of current and earlier
locations, so both the rolling baseline and older pinned refs load. The
released-chat writers drop their own per-module existsSync fallbacks for it.

v1.4.246 also ships outcome storage, so it reads chats this build writes and
closes its own rows with the outcomes marker. The downgrade test pins its
refusing window to the two releases before outcome storage, and the upgrade
test leaves the marker to the outcome reader, which restoreJournal checks.
nwparker added a commit that referenced this pull request Nov 2, 2026
…fines them (#37297)

* test(cross-version): load moved modules from wherever each release defines them

v1.4.246 is the first release cut after #36909, #36979, #37036 and #37070 moved
the agent-session modules, so suites that imported the old paths from the
newest release failed with ERR_MODULE_NOT_FOUND for every PR running
cross-version wire. importReleaseCheckoutModule now resolves a moved module to
the path the checked-out release ships, from one table of current and earlier
locations, so both the rolling baseline and older pinned refs load. The
released-chat writers drop their own per-module existsSync fallbacks for it.

v1.4.246 also ships outcome storage, so it reads chats this build writes and
closes its own rows with the outcomes marker. The downgrade test pins its
refusing window to the two releases before outcome storage, and the upgrade
test leaves the marker to the outcome reader, which restoreJournal checks.

* test(cross-version): find a moved module by name in the release instead of a path table

A table of earlier paths is a list of stale src literals the path-literal ratchet rightly refuses, and needs an entry for every future move. The release checkout itself says where it ships each module: the one file with that name under the same source root. Prunes the three released-chat-writers entries the ratchet baseline grandfathered.

* test(cross-version): pin the chat-upgrade writers to the releases before outcome storage

v1.4.246 keeps a chat in outcome tables, so its rows hold only the marker and there is no row upgrade to carry on; the newest release stays the reader this build must match.
audichuang pushed a commit to audichuang/orca that referenced this pull request Nov 2, 2026
…fines them (stablyai#37297)

* test(cross-version): load moved modules from wherever each release defines them

v1.4.246 is the first release cut after stablyai#36909, stablyai#36979, stablyai#37036 and stablyai#37070 moved
the agent-session modules, so suites that imported the old paths from the
newest release failed with ERR_MODULE_NOT_FOUND for every PR running
cross-version wire. importReleaseCheckoutModule now resolves a moved module to
the path the checked-out release ships, from one table of current and earlier
locations, so both the rolling baseline and older pinned refs load. The
released-chat writers drop their own per-module existsSync fallbacks for it.

v1.4.246 also ships outcome storage, so it reads chats this build writes and
closes its own rows with the outcomes marker. The downgrade test pins its
refusing window to the two releases before outcome storage, and the upgrade
test leaves the marker to the outcome reader, which restoreJournal checks.

* test(cross-version): find a moved module by name in the release instead of a path table

A table of earlier paths is a list of stale src literals the path-literal ratchet rightly refuses, and needs an entry for every future move. The release checkout itself says where it ships each module: the one file with that name under the same source root. Prunes the three released-chat-writers entries the ratchet baseline grandfathered.

* test(cross-version): pin the chat-upgrade writers to the releases before outcome storage

v1.4.246 keeps a chat in outcome tables, so its rows hold only the marker and there is no row upgrade to carry on; the newest release stays the reader this build must match.

(cherry picked from commit bdd997f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant