Repository navigation
refactor(agent-session): group lifecycle contracts and records - #36909
Merged
Merged
Conversation
nwparker
added a commit
that referenced
this pull request
Nov 2, 2026
…fines them v1.4.246 is the first release cut after #36909, #36979, #37036 and #37070 moved the agent-session modules, so suites that imported the old paths from the newest release failed with ERR_MODULE_NOT_FOUND for every PR running cross-version wire. importReleaseCheckoutModule now resolves a moved module to the path the checked-out release ships, from one table of current and earlier locations, so both the rolling baseline and older pinned refs load. The released-chat writers drop their own per-module existsSync fallbacks for it. v1.4.246 also ships outcome storage, so it reads chats this build writes and closes its own rows with the outcomes marker. The downgrade test pins its refusing window to the two releases before outcome storage, and the upgrade test leaves the marker to the outcome reader, which restoreJournal checks.
nwparker
added a commit
that referenced
this pull request
Nov 2, 2026
…fines them (#37297) * test(cross-version): load moved modules from wherever each release defines them v1.4.246 is the first release cut after #36909, #36979, #37036 and #37070 moved the agent-session modules, so suites that imported the old paths from the newest release failed with ERR_MODULE_NOT_FOUND for every PR running cross-version wire. importReleaseCheckoutModule now resolves a moved module to the path the checked-out release ships, from one table of current and earlier locations, so both the rolling baseline and older pinned refs load. The released-chat writers drop their own per-module existsSync fallbacks for it. v1.4.246 also ships outcome storage, so it reads chats this build writes and closes its own rows with the outcomes marker. The downgrade test pins its refusing window to the two releases before outcome storage, and the upgrade test leaves the marker to the outcome reader, which restoreJournal checks. * test(cross-version): find a moved module by name in the release instead of a path table A table of earlier paths is a list of stale src literals the path-literal ratchet rightly refuses, and needs an entry for every future move. The release checkout itself says where it ships each module: the one file with that name under the same source root. Prunes the three released-chat-writers entries the ratchet baseline grandfathered. * test(cross-version): pin the chat-upgrade writers to the releases before outcome storage v1.4.246 keeps a chat in outcome tables, so its rows hold only the marker and there is no row upgrade to carry on; the newest release stays the reader this build must match.
audichuang
pushed a commit
to audichuang/orca
that referenced
this pull request
Nov 2, 2026
…fines them (stablyai#37297) * test(cross-version): load moved modules from wherever each release defines them v1.4.246 is the first release cut after stablyai#36909, stablyai#36979, stablyai#37036 and stablyai#37070 moved the agent-session modules, so suites that imported the old paths from the newest release failed with ERR_MODULE_NOT_FOUND for every PR running cross-version wire. importReleaseCheckoutModule now resolves a moved module to the path the checked-out release ships, from one table of current and earlier locations, so both the rolling baseline and older pinned refs load. The released-chat writers drop their own per-module existsSync fallbacks for it. v1.4.246 also ships outcome storage, so it reads chats this build writes and closes its own rows with the outcomes marker. The downgrade test pins its refusing window to the two releases before outcome storage, and the upgrade test leaves the marker to the outcome reader, which restoreJournal checks. * test(cross-version): find a moved module by name in the release instead of a path table A table of earlier paths is a list of stale src literals the path-literal ratchet rightly refuses, and needs an entry for every future move. The release checkout itself says where it ships each module: the one file with that name under the same source root. Prunes the three released-chat-writers entries the ratchet baseline grandfathered. * test(cross-version): pin the chat-upgrade writers to the releases before outcome storage v1.4.246 keeps a chat in outcome tables, so its rows hold only the marker and there is no row upgrade to carry on; the newest release stays the reader this build must match. (cherry picked from commit bdd997f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Agent-session lifecycle contracts and records now live together under a concrete folder. Backend, desktop, mobile, and tests import each symbol directly from its implementation owner. Behavior stays the same.
What Changed
src/shared/agent-session/lifecycle/: 26 production files and 16 test/support files.Why
This larger coherent batch completes the related records and lifecycle area together, making ownership and dependencies easier to follow without adding barrel exports or compatibility wrappers.
Linked Issue
Part of the ongoing module-organization cleanup.
Visual Proof
N/A — file organization and import ownership only; no rendered or interaction changes.
Testing
30242d17integration tree, 48 metadata-gate cases and the one remaining changed runtime case passed; 1,465 nonselected runtime cases were skipped. Reliability and test discovery passed, and all 13,509 unit files were assigned once across 12 shards. The two metadata files contain only the original path retargets over current main.ORCA_BACKGROUND_LAUNCH=1; configured hosted checks cover their platforms. No additional low-value tests were added for the mechanical move.Review
Detailed evidence and the full tracker stay local. The unmodified refactor-audit preservation gate passed before and after merge. Actual squash
57454e6d7eacfc22ad055102048d16e1d52a185bhas the exact reviewed immediate parent and integration tree; all other current-main files remain preserved.Agent skill upstream boundary
Notes
Wire names, permission and lifecycle semantics, runtime dependency order, platform behavior, remote compatibility, folder workspaces, and mobile behavior are preserved.
Checklist