Skip to content

Keep settled permission notices compact on desktop and phone - #36304

Merged
brennanb2025 merged 8 commits into
mainfrom
brennanb2025/sta-12798-completed-approval-notices
Oct 31, 2026
Merged

brennanb2025 merged 8 commits into
mainfrom
brennanb2025/sta-12798-completed-approval-notices

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 7 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​647 $\color{#cf222e}{\Huge{\mathbf{−}}}$​34 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​613
Prod 27 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​264 $\color{#cf222e}{\Huge{\mathbf{−}}}$​28 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​236

Native chat renders Codex safety-review warnings and Claude permission denials as full cards, so long explanations crowd the conversation even though these notices have no approval controls to answer.

These existing notices now start as a neutral, translated one-line disclosure on desktop and phone. Expansion preserves the entire available explanation and provider payload head, with warning/error tone and an explicit translated truncation label showing the original payload size. Active approvals, typed failures, other warnings and recovery actions keep their existing paths. Classification uses provider/frame kinds, with no provider-text matching.

This is tracked in STA-12798 and tracked in #35918.

Plan

The reviewed plan keeps this change in the readers: extend the shared notice presentation, reuse desktop disclosure and mobile toggle/scroll patterns, and leave provider admission, journal contents and wire contracts unchanged. Mobile details do not inherit tool-output clipping or full-output recovery controls. The change is useful on its own, including retained history and older hosts.

Common-pattern comparison and follow-up

  • Intended: Claude denial compaction follows the common pattern of a declared denial summary with details.
  • Intended: phone summaries retain the existing platform-specific text-selection and message-action behavior. The portable disclosure adapts the common pattern to the shipping phone renderer while preserving those existing interactions and a visible expansion indicator.
  • Intended: guardian warnings remain discoverable in the conversation, where the common pattern hides these diagnostics by default. The ticket requires details to remain reachable; the compact row preserves that discovery without changing the provider event or claiming an approval/denial outcome.
  • Possible follow-up, excluded here: newly visible structured automatic-review denied completions require a real recorded paired capture and a product decision. A guardian warning and assessment may describe one decision; showing both must not report the same failure twice. Existing suppression of review lifecycle frames remains unchanged.

Review path: full

  • Size: four production code files plus locale catalogs and focused tests. The reviewed plan and prior incidents require the full path regardless of size.
  • Risk: this changes a notice presentation default on desktop and phone in a mechanism with prior incidents; full path.
  • Repeat/history: prior kind-classification and wordless-row regressions require preserving typed-failure precedence and reader/host separation; full path.
  • Scope: shared native-chat presentation across desktop and phone; no schema, saved-data, provider-admission, ownership or recovery change.
  • Local effect: reader-derived disclosure only; generic warnings and active permission requests are excluded.

Validation

  • Full review finished in four rounds on dbd38ed with no remaining runtime findings. The independent panel's mobile header repair preserves summary selection, visible caret orientation and accessible expanded state. Final first-hand common-pattern, readiness and performance passes are complete.
  • All CI checks pass on the final head. Forty-five focused mobile tests pass, including four actual web-renderer regressions with real text/press/view and SVG/icon implementations under the production selection policy. Old-head and accessibility mutations fail as expected. English/French output, classification negatives, retained content and 10/100-notice scroll-operation/cleanup contracts are covered. Two later test-only import repairs preserve production and assertions. Normal commit hooks passed.
  • Exact-head native Android rerun passed both provider fixtures: summary hold/release gives Copy/Select while staying closed, next tap opens, right/down carets remain visible, expanded text selects without collapsing, and late explanation markers beyond character 4,000, retained payload and original 18342/9731-byte truncation metadata remain reachable. Fresh loaded page buildId 044e3be917cc96382ea31f14653b69f2e34bf8eeebacb172558571be4b4f86bf; reused APK's Android native inputs match this head. Owned launches/device stopped, gate ticket 3685 released, real config hashes unchanged.
  • Desktop screenshots cover the unchanged desktop flow. Current desktop and native screenshots are in the review status comment. Native evidence is Android/English synthetic paired-host input on the shipping screen; no live-agent, real-provider capture, iOS or selection-handle-drag verdict is claimed. Native-chat UI uses the review skill's tests row, so no live-agent QA round was required. One optional delivery-notice assertion concern remains deferred without a demonstrated runtime bug.

@brennanb2025
brennanb2025 marked this pull request as ready for review October 30, 2026 08:28
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8876fa97-277e-4baa-8cb2-f0047b7dae30
Commits

Reviewing files that changed from the base of the PR and between 88dc7f4 and dbd38ed.

Files selected for processing: 1
  • mobile/src/session/native-chat/transcript/MobileNativeChatNoticeRow.web.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The change classifies Codex safety-review warnings and Claude permission denials. Renderer and mobile notice rows display these notices with expandable details, including provider payload text and truncation byte counts. Locale files add translated notice messages. Tests cover classification, disclosure behavior, and localization.

Merge Risk: Low · up to dbd38

Collapsed permission notices appear muted rather than warning- or error-colored. This limited visual issue should be addressed or accepted before merging.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: making settled permission notices compact on desktop and mobile.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is substantially complete. It explains the user-visible change, scope, rationale, linked tracking references, visual evidence, testing, review considerations, risks, and validation res…
Full details: Description check

Explanation

The description is substantially complete. It explains the user-visible change, scope, rationale, linked tracking references, visual evidence, testing, review considerations, risks, and validation results. It does not use every template heading, does not provide a direct issue link in the Linked Issue section, and leaves checklist items and AI Disclosure unfilled, but these omissions do not make the description incomplete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 7 functions across 12 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@brennanb2025

brennanb2025 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Native chat displayed long Codex safety-review warnings and Claude permission denials as full cards, crowding the conversation after no approval action remained. These existing notices now start as a neutral, translated one-line disclosure on desktop and phone. Opening a row preserves the full available explanation and diagnostic payload, including warning/error tone and original byte-size/truncation metadata.

The full review finished in four rounds on dbd38ed. Native screenshots caught lost collapsed-summary selection and a disappearing expanded caret; both are repaired and passed the exact-head native rerun. The phone header now owns its text-selection policy, wraps the caret in a view that can rotate it correctly, and exposes its expanded state to accessibility APIs. Earlier repairs preserved native message actions, colocated shared-classifier coverage, and added 10/100-row scroll-operation and cleanup contracts. Two later commits repair test imports only, preserving production behavior and assertions.

Verification: all CI checks passed on the final head; 45 focused mobile tests passed, including four actual web-renderer cases using real text/press/view and SVG/icon implementations under the production selection policy. Old-head and isolated accessibility mutations fail as expected. Desktop/shared renderer coverage, live English/French output, classification negatives and retained-history inputs are covered. Final first-hand common-pattern comparison, readiness and performance passes are complete.

Native Android on the final head passed summary hold/release with the Copy/Select toolbar while staying closed, the next deliberate tap, visible right/down carets, selectable expanded text, collapse, full explanation markers beyond character 4,000, retained payload and original-size/truncation text for both provider fixtures. The fresh loaded page buildId is 044e3be917cc96382ea31f14653b69f2e34bf8eeebacb172558571be4b4f86bf. The reused debug APK's Android native inputs match this head. All owned test launches/device were stopped and the QA slot released; real config hashes are unchanged.

Evidence limits: native screenshots are Android/English synthetic paired-host inputs on the shipping native shell and session screen. They are renderer evidence, with no live-agent, real-provider-capture, iOS or selection-handle-drag verdict. Native-chat UI uses the review skill's tests row, so no live-agent QA round was required.

Intended differences from the common pattern: guardian diagnostics remain discoverable in the transcript because STA-12798 requires that discovery; phone summaries preserve the existing platform-specific inline selection or message actions. Declared Claude denial summary/details follows the common pattern. Active requests, permission decisions, stored records, host admission and wire contracts are unchanged. Newly displaying structured denied completions remains excluded: it needs a real paired capture and a product decision to avoid reporting one failure twice. Deferred: one optional delivery-notice assertion opportunity has no demonstrated runtime defect.

For Brennan's review:

Desktop, branch-only synthetic fixture, unchanged desktop flow:

Collapsed notices Expanded details
Desktop compact notices Desktop expanded details

Desktop long detail beyond character 4,000. Desktop was captured at 65ffc56; later commits affect tests and the phone header, so this evidence covers the unchanged desktop flow. Its synthetic fixture used one Claude session with both provider records, so these desktop images prove layout/disclosure rather than each provider's displayed name.

Native Android, exact final head, separate provider sessions and synthetic inputs:

State Codex Claude
Closed, right caret Codex closed Claude closed
Open, down caret Codex open Claude open
Summary hold, stays closed Codex selection toolbar Claude selection toolbar

Codex copied selection, Codex late marker and retained payload, Claude late marker and retained payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant