Repository navigation
Keep settled permission notices compact on desktop and phone - #36304
Conversation
|
No actionable comments were generated in the recent review.
|
|
Native chat displayed long Codex safety-review warnings and Claude permission denials as full cards, crowding the conversation after no approval action remained. These existing notices now start as a neutral, translated one-line disclosure on desktop and phone. Opening a row preserves the full available explanation and diagnostic payload, including warning/error tone and original byte-size/truncation metadata. The full review finished in four rounds on dbd38ed. Native screenshots caught lost collapsed-summary selection and a disappearing expanded caret; both are repaired and passed the exact-head native rerun. The phone header now owns its text-selection policy, wraps the caret in a view that can rotate it correctly, and exposes its expanded state to accessibility APIs. Earlier repairs preserved native message actions, colocated shared-classifier coverage, and added 10/100-row scroll-operation and cleanup contracts. Two later commits repair test imports only, preserving production behavior and assertions. Verification: all CI checks passed on the final head; 45 focused mobile tests passed, including four actual web-renderer cases using real text/press/view and SVG/icon implementations under the production selection policy. Old-head and isolated accessibility mutations fail as expected. Desktop/shared renderer coverage, live English/French output, classification negatives and retained-history inputs are covered. Final first-hand common-pattern comparison, readiness and performance passes are complete. Native Android on the final head passed summary hold/release with the Copy/Select toolbar while staying closed, the next deliberate tap, visible right/down carets, selectable expanded text, collapse, full explanation markers beyond character 4,000, retained payload and original-size/truncation text for both provider fixtures. The fresh loaded page buildId is 044e3be917cc96382ea31f14653b69f2e34bf8eeebacb172558571be4b4f86bf. The reused debug APK's Android native inputs match this head. All owned test launches/device were stopped and the QA slot released; real config hashes are unchanged. Evidence limits: native screenshots are Android/English synthetic paired-host inputs on the shipping native shell and session screen. They are renderer evidence, with no live-agent, real-provider-capture, iOS or selection-handle-drag verdict. Native-chat UI uses the review skill's tests row, so no live-agent QA round was required. Intended differences from the common pattern: guardian diagnostics remain discoverable in the transcript because STA-12798 requires that discovery; phone summaries preserve the existing platform-specific inline selection or message actions. Declared Claude denial summary/details follows the common pattern. Active requests, permission decisions, stored records, host admission and wire contracts are unchanged. Newly displaying structured denied completions remains excluded: it needs a real paired capture and a product decision to avoid reporting one failure twice. Deferred: one optional delivery-notice assertion opportunity has no demonstrated runtime defect. For Brennan's review: Desktop, branch-only synthetic fixture, unchanged desktop flow:
Desktop long detail beyond character 4,000. Desktop was captured at 65ffc56; later commits affect tests and the phone header, so this evidence covers the unchanged desktop flow. Its synthetic fixture used one Claude session with both provider records, so these desktop images prove layout/disclosure rather than each provider's displayed name. Native Android, exact final head, separate provider sessions and synthetic inputs:
Codex copied selection, Codex late marker and retained payload, Claude late marker and retained payload. |








Native chat renders Codex safety-review warnings and Claude permission denials as full cards, so long explanations crowd the conversation even though these notices have no approval controls to answer.
These existing notices now start as a neutral, translated one-line disclosure on desktop and phone. Expansion preserves the entire available explanation and provider payload head, with warning/error tone and an explicit translated truncation label showing the original payload size. Active approvals, typed failures, other warnings and recovery actions keep their existing paths. Classification uses provider/frame kinds, with no provider-text matching.
This is tracked in STA-12798 and tracked in #35918.
Plan
The reviewed plan keeps this change in the readers: extend the shared notice presentation, reuse desktop disclosure and mobile toggle/scroll patterns, and leave provider admission, journal contents and wire contracts unchanged. Mobile details do not inherit tool-output clipping or full-output recovery controls. The change is useful on its own, including retained history and older hosts.
Common-pattern comparison and follow-up
Review path: full
Validation