Repository navigation
test(native-chat): drop flaky at-rest admission bounds test - #36134
Merged
Merged
Conversation
The N/10N case asserted exact start/peak/permit counts across concurrent work under fake timers and failed intermittently on CI (expected 3 to be 4). The phone dispatch/retirement and shared-context tests in the same file still cover the user-facing behavior.
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
bounds mixed real-host %s admission, retained reads and replacement roots at N/10Nfromstructured-agent-session-at-rest-command-population.test.ts.It asserted exact
starts/peak/permitscounts across concurrent work driven by fake timers andvi.waitFor({ interval: 0 }), and failed intermittently on unrelated PRs (AssertionError: expected 3 to be 4, e.g. runs on #35059, #35503, #35599, #35616). It's ~318 lines of synthetic-scale operation counting; the remaining phone-dispatch/retirement and shared-context tests in the file still cover the user-facing behavior.Test-only; 351 deletions. Remaining file: 5/5 passing, 3 consecutive local runs.