Repository navigation
fix(emulator): run Android commands through the process host - #35599
Conversation
45d68b5 to
0fa41d9
Compare
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAndroid commands now run through
No actionable issues found. Tests were inspected but not run. Reviews (4) · Last reviewed commit: "fix(emulator): run Android commands thro..." · Reviewed by Greptile |
2fb314f to
2b9cd98
Compare
2b9cd98 to
e2dab9a
Compare
Summary
Runs Android
adb/emulatorcommands through@orca/process-host(runProcess) instead of a directexecFile.adb.exe/emulator.exenow spawn with hidden console windows (windowsHide), so Android actions no longer flash console windows..bat/.cmdSDK wrappers become launchable, since process-host builds the cmd line itself (Node rejects direct.bat/.cmdspawns).android-command-runner.tsfrom the process-host direct-import baseline.Tests
android-command-runner-native.test.ts: nonzero exit returned as data (with argument bytes preserved), and timeout mapped to a failed result.