Skip to content

fix(emulator): run Android commands through the process host - #35599

Merged
OrcaWin merged 1 commit into
mainfrom
audit/android-background-command-runner
Oct 29, 2026
Merged

OrcaWin merged 1 commit into
mainfrom
audit/android-background-command-runner

Conversation

@OrcaWin

@OrcaWin OrcaWin commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​21 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​21
Prod 2 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​34 $\color{#cf222e}{\Huge{\mathbf{−}}}$​34 0

Summary

Runs Android adb/emulator commands through @orca/process-host (runProcess) instead of a direct execFile.

  • Windows: adb.exe/emulator.exe now spawn with hidden console windows (windowsHide), so Android actions no longer flash console windows.
  • Windows: .bat/.cmd SDK wrappers become launchable, since process-host builds the cmd line itself (Node rejects direct .bat/.cmd spawns).
  • Otherwise unchanged: nonzero exits still resolve as data, 60s default timeout (0 = unlimited), 16 MiB output cap (now fails the command).
  • Removes android-command-runner.ts from the process-host direct-import baseline.

Tests

android-command-runner-native.test.ts: nonzero exit returned as data (with argument bytes preserved), and timeout mapped to a failed result.

@OrcaWin
OrcaWin changed the base branch from audit/android-avd-boot-deadline to main October 29, 2026 20:39
@OrcaWin
OrcaWin force-pushed the audit/android-background-command-runner branch from 45d68b5 to 0fa41d9 Compare October 29, 2026 20:43
@OrcaWin
OrcaWin marked this pull request as ready for review October 29, 2026 20:48
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 21 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 53d7912d-2020-443c-bdcd-fd102b1be4e5
Commits

Reviewing files that changed from the base of the PR and between c351825 and e2dab9a.

Files selected for processing: 3
  • config/process-host-direct-import-baseline.txt
  • src/main/emulator/android/android-command-runner-native.test.ts
  • src/main/emulator/android/android-command-runner.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Android commands now run through @orca/process-host instead of execFile.

  • Android emulator commands now use the process host's Windows launch rules.

No actionable issues found. Tests were inspected but not run.

Reviews (4) · Last reviewed commit: "fix(emulator): run Android commands thro..." · Reviewed by Greptile

@OrcaWin
OrcaWin force-pushed the audit/android-background-command-runner branch 2 times, most recently from 2fb314f to 2b9cd98 Compare October 29, 2026 21:18
@OrcaWin
OrcaWin force-pushed the audit/android-background-command-runner branch from 2b9cd98 to e2dab9a Compare October 29, 2026 21:44
@OrcaWin
OrcaWin merged commit 2d6ee2a into main Oct 29, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant