Repository navigation
Conversation
Collaborator
Author
|
Closing: this only triggers for a submodule whose directory name contains a literal backslash on a POSIX host, which nobody plausibly creates and which cannot be checked out on Windows. The fix is also partial: the same normalization remains in runtime-relative-paths and the blob readers, and WSL-from-Windows is unchanged. It would add 136 lines of mock and real-git tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A literal backslash is part of a filename on POSIX hosts. The submodule diff router changed it to
/before matching.gitmodules, then repeated that conversion while extracting the inner path. An expandedvendor\module/file.txtrow could therefore showvendor/module/file.txtfrom the parent repository as its original content, and the root pointer diff could show tree metadata instead of subproject commits.Convert only the owning process's filesystem separator at both existing routing steps. POSIX submodule names remain exact, and native Windows/Windows-host WSL retain backslash separator compatibility. No new resolver, wire field, cache, Git command, filesystem I/O or UI change is added.
Evidence and validation
vendor/module/file.txt. Baseline inner diff returns the neighbor's original bytes; fixed returns the child's original and working bytes. Root pointer diffs return exact subproject commits after the fix. The version executed through the production runner is asserted. Parent/child indexes and neighbor bytes remain unchanged; fixtures are removed.ORCA_BACKGROUND_LAUNCH=1 pnpm check:changed --base=2d3e7e452000c26433650d75422e79a06be80684 --maxWorkers=2completed 19 of 20 checks successfully in 604.6 seconds under Node 24. The broad affected-test selection was stopped at 600.5 seconds without an aggregate result; only its four verified owned descendants were terminated and all exited. The gate therefore exits nonzero and is not a full test pass. Its type, format, lint and quality checks passed.Reachability and integration
Source Control receives the exact submodule name from status. Its expansion combines that name with the inner status path in
buildSubmoduleChildEntry; registered local diff validation preserves the POSIX path before these two faulty conversions. The owning server executes remote paths on its own OS. Folder repositories keep their existing Git provider/root-validation path.#35012 separately fixes
.gitmodulesconfig parsing; this patch uses ordinary subsection syntax and preserves its parser changes. #27757 fixes early runtime path normalization and committed blob-reader filenames, while #35092 fixes index blob filenames. Those are still needed for literal backslashes inside an inner filename and for runtime requests normalized before this reader; this patch covers submodule-root identity only. Integrate both replacements with the adjacent #34779/#34967/#35048/#35084 diff-reader work without losing metadata, error, cancellation or symlink semantics. Actual #15994 patch changes host test fixtures, not these production conversions. Targeted open submodule/path/backslash searches and the relevant actual patches found no duplicate fix.Validation is Linux execution of both Git versions plus simulated separator tests. Native Windows/WSL/macOS, live SSH, Electron, physical mobile and packaged app build were not run. The runtime route's earlier normalization remains separately scoped above. Screenshots are not applicable to these two path-routing expressions; exact before/after content is asserted through real production readers.