Repository navigation
Conversation
This was referenced Oct 28, 2026
Collaborator
Author
|
The combined-diff section scheduler runs one load at a time, so a retired viewer leaves at most one already-deduped diff read. That gain does not justify about 900 lines across renderer, IPC, RPC and git, a swapped dedupe primitive behind every diff read, and a cached-restore generation bump that remounts editors. Per-request remote cancellation is also not delivered, because ctx.signal is socket-scoped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing or replacing a combined diff view, or reaching its existing row deadline, used to leave issued Git reads queued. Once admission reopened, those retired reads still started physical commands before the next live viewer. Propagate cancellation from the section owner through local IPC and the existing runtime subscription signal, and reuse the existing shared read lease owner so one canceled reader cannot terminate a surviving same-key read.
Retire issued controllers on unmount, generation replacement (including cached restores), and timeout. Cancel queued admission and supported active Git/file I/O after the final lease retires. Aborts propagate as errors instead of becoming empty successful diffs. Optional request tokens and signal arguments preserve old call shapes; older preload/hosts can still retire the renderer caller even when physical cancellation is unavailable. Existing WSL routing keys, provider options, result budgets and the row timeout message remain in place.
Validation:
pnpm tcpassed. Five additional unchanged routing/setup-cancellation/sender suites passed 26/26 controls.Required gate:
ORCA_BACKGROUND_LAUNCH=1 ORCA_CODE_QUALITY_BASE=2d3e7e452000c26433650d75422e79a06be80684 MISE_NODE_VERSION=24.22.0 pnpm_config_verify_deps_before_run=false pnpm check:changed --maxWorkers=2passed 25/27 checks. Formatting, lint, changed-code quality, typechecking and ratchets passed. The aggregate remains non-green: untouchedtr.jsonhas three baseline extra keys (English/Turkish files are byte-identical to base); the broad affected-test selection was deliberately stopped after 228.8 seconds without results, so its coverage is unverified. Exact focused tests above provide the completed test evidence.Reliability invariant (
git.diff.read-ownership): a retired diff caller cannot start queued physical work; a surviving same-key reader keeps its owner's read. Oracle: production queue/spawn/termination counts, exact surviving content, and no successor publication from retired generations. No matching reliability-manifest gate exists at this pinned base; the deterministic focused tests are the explicit accepted gap. Local/daemon PTY lifecycle and persistence are unaffected. Linux/system Git and semantic WSL option isolation are covered; native platforms, live SSH and mobile/relay execution remain accepted validation gaps. Runtime environments execute on their own server via its local provider; direct unservedssh:/runtime:targets keep refusing local fallback. Existing subscription teardown carries cancellation through setup and socket close; older-host physical cancellation is best effort.Integration: this independently targets pinned
2d3e7e452000c26433650d75422e79a06be80684. Resolve overlapping blob-reader edits with #34767 (bounded reads), #34778 (literal blob paths), and #34967 (incomplete-read errors), preserving their semantics and this signal forwarding/abort rethrow behavior. Reviewed related drafts include #34873 (projection cancellation), #34961/#35017 (publication echoes), #17506 (registry timing), #11287 (file selection), #9312 (native blobs) and #9597/#9598 (history publication); none of the inspected changes supplies this shared diff-read cancellation.