Skip to content

Mention an agent from the orchestration panel with one click - #34836

Merged
brennanb2025 merged 279 commits into
mainfrom
brennanb2025/orchestration-crew-panel
Nov 2, 2026
Merged

brennanb2025 merged 279 commits into
mainfrom
brennanb2025/orchestration-crew-panel

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 27 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1405 $\color{#cf222e}{\Huge{\mathbf{−}}}$​94 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1311
Prod 30 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​828 $\color{#cf222e}{\Huge{\mathbf{−}}}$​95 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​733

Problem and change

The Orchestration panel (#34891) shows who an agent works with, but asking the current agent to contact one of them still means finding and copying an address. This PR lets a person mention an agent from the panel with one click.

Experimental and off by default, like the panel itself: Mention is reachable only from the Orchestration panel, which shows only when Settings → Experimental → Orchestration panel is on. See "Effect with the setting off" below.

In a native chat, clicking a row's body inserts a mention chip at the composer's cursor. Focus stays in the composer and the panel stays open. Sending produces @name plus one address line per mentioned agent, so the receiving agent can use the existing messaging command. A draft holds each agent once: mentioning an agent already in the draft (from its row or from Mention all) adds nothing and just focuses the composer.

In a terminal, the same click types "name (Orca agent address)" into that pane's input, without Enter. Focus stays in the terminal and the panel stays open. Terminals type text, so they don't skip agents already typed.

Managing's "Mention all" button mentions every unfinished worker. It is dimmed and disabled when the pane can't take input. More also offers Mention in message. A row without a proven address stays visible but can't be mentioned.

Recalling a sent message returns the exact plain text and address lines that were sent; it does not rebuild chips. Answer, Show messages and Stop remain follow-up work.

Design and compatibility

The chip uses the existing draft document and selection APIs. A shared serializer combines captured file references and typed mentions; every send, Goal and queued-edit path keeps its existing admission and body ownership. Intended: where the host sets goals, a goal's address lines follow on the goal's own line, because a typed /goal is applied by re-reading the sent text with the existing one-line /goal rule, which stays unchanged while the panel is off; the common pattern classifies a goal before adding references. Where the agent handles /goal itself, the goal is sent as a message and keeps its address lines on their own lines. Terminal insertion uses the existing paste writer and the captured pane and transport, with no active-pane fallback, no Enter and no new permission cache. The common pattern keeps a target separate from its label and serializes the actual typed content. Intended difference: external agents need a printable Orca address rather than a provider-specific mention object.

Known intended limitation: an older Orca build can open an unsent native-chat draft containing an agent mention as empty. Brennan accepted this downgrade limitation on October 30; no downgrade repair is included. Sent messages and recalled plain text remain authoritative. Direct SSH terminal writes keep the existing lack of delivery acknowledgement; a rejected paired write shows one toast.

Effect with the setting off

Every change in this PR, for a user who has not turned the setting on:

Change Effect with the setting off Why
Mention from the panel (chat chips, terminal insert, Mention all, More → Mention in message) None Reachable only from the gated panel
The composer editor knows the mention chip No behavior change Intended: the chip has no paste rules and only the panel inserts it; it stays registered so a draft written while the setting was on keeps its chips
Chat, terminal-hosted chat and Goal send paths Same send text, no extra work A draft with no printed mention skips the mention serializer. Intended: prose that literally contains "(Orca agent " pays one extra pass over the draft, with the same output
Pasted-text file reference projection, rewritten to accept chips Same output Ordinary text projects exactly as before
/goal parsing Unchanged: main's code Mentions inside a goal carry their address lines on the goal's one line
Pane manager focus helpers Same behavior Moved code
Prompt editor's editable effect Same behavior Written as one line to stay under the file length cap after main's growth

Validation

With the setting off, Mention can't be reached: the panel tests above cover that nothing of it mounts. The shared /goal parser and its tests are main's code. A test covers a mention inside a goal on a host that sets goals (one line, notes included) and on a host where the agent handles /goal (sent as a message with its notes).

Renderer tests cover native and terminal Mention (focus, no Enter, the panel staying open), a restored terminal pane that connects after the panel rendered, refusal into a retired pane or a disconnected terminal, a row Mention followed by Mention all (each agent once), label collisions, unsent copy and caret, queued-edit handback, and the serializer through structured, terminal, typed-goal and Goal sends.

Real-app runs with Claude and Codex agents checked Mention in Claude and Codex native chats, and in Claude and Codex worker terminals. Screenshots are in the review status comment.

@brennanb2025
brennanb2025 marked this pull request as ready for review October 28, 2026 07:15
@brennanb2025
brennanb2025 force-pushed the brennanb2025/orchestration-crew-panel branch from bd0825e to 1147c3e Compare October 28, 2026 08:23
@brennanb2025 brennanb2025 changed the title Show who an agent works with, and mention them with one click Mention an agent from the crew panel with one click Oct 28, 2026
@brennanb2025
brennanb2025 changed the base branch from brennanb2025/chat-worker-lineage to brennanb2025/crew-panel-ui October 28, 2026 08:25
@brennanb2025
brennanb2025 force-pushed the brennanb2025/orchestration-crew-panel branch from 1147c3e to 4783c9f Compare October 28, 2026 12:11
@brennanb2025
brennanb2025 force-pushed the brennanb2025/crew-panel-ui branch from b80bb4b to 7d1cabf Compare October 28, 2026 12:11
@brennanb2025
brennanb2025 force-pushed the brennanb2025/orchestration-crew-panel branch from 4783c9f to 3e34030 Compare October 28, 2026 12:44
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change adds crew mentions across native chat and terminal-pane workflows.

Do not merge yet: returned drafts can still lose text when a pending send is accepted.

Findings

  1. P1 Returned drafts lose text ▶
  2. P2 Disabled mentions give no reason ▶
  3. P2 Late acceptance steals focus ▶

Summary

Adds one-click agent mentions from the crew panel.

  • Crew members can be added to chat messages as addressable mentions.
  • Crew members can be typed into a terminal prompt without sending them.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Crew panel click] --> B{Destination}
  B --> C[Native chat badge]
  C --> D[Send text with agent addresses]
  B --> E[Check captured terminal]
  E --> F[Insert printable text without Enter]
Loading

Reviews (19) · Last reviewed commit: "Follow image reference module relocation..." · Reviewed by Greptile

Brings the translated Open fallback for agents without a target.
@brennanb2025 brennanb2025 changed the title Mention an agent from the crew panel with one click Mention an agent from the orchestration panel with one click Nov 2, 2026
Settings > Experimental > Orchestration panel (experimentalOrchestrationPanel).
Off mounts nothing: the chat frame, the terminal-hosted chat's identity lookup
and the terminal pane portals all gate where they mount, and toggling applies
live without remounting the transcript.
CI on the merged head failed because main moved agent-session-conversation-view
under shared/agent-session/lifecycle; the crew mounted-render fixture now imports
it from there.
Brings the experimental Orchestration panel setting (default off) and main.
Mention's composer ref and readiness now ride on the gated panel element, so
the hosts compute nothing for the panel while the setting is off. The goal
objective keeps agent-reference serialization on main's new host-goal path.
NativeChatPromptEditor's editable effect is one line to stay under the cap.
The message card's avatar and its single-sender hook are back to main's code;
the panel keeps its own list hook. The panel's code now loads only when it
first mounts, behind the setting.
Brings main's message card and sender hook back for the setting-off path and
the lazily loaded panel; Mention rides on the lazy panel element.
A typed multi-line /goal is prose again, as on main; only Mention's own
routing lines after a one-line /goal join its objective. A draft with no
agent reference skips the reference serializer, so its send text is projected
once, as before. The routing line format now lives with the other reference
formats.
Brings main's fixes for its own unit checks (#37345, #37346).
Brings main and the panel tests' default-built settings.
The shared command parser is main's code again, so any typed or pasted text
parses as before. A typed /goal or Goal-mode objective with mentions carries
its routing notes on the same line instead.
There /goal goes to the agent as a message, so its notes keep their own lines,
as a typed /goal there already does. A draft with no mention sends main's text.
Brings main's Hermes-compatible plugin fingerprint (#37370) so the stacked PR's mobile check can pass.
Brings main's Hermes-compatible plugin fingerprint (#37370).
@brennanb2025
brennanb2025 changed the base branch from brennanb2025/crew-panel-ui to main November 2, 2026 08:21
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 92d51152-9bb1-410f-aefc-b398e220643c
Commits

Reviewing files that changed from the base of the PR and between c7195a8 and cd54fcb.

Files selected for processing: 57
  • src/main/native-chat/orchestration-agent-reference-delivery.test.ts
  • src/renderer/src/components/native-chat/NativeChatMessageList.reader-navigation.spec.tsx
  • src/renderer/src/components/native-chat/NativeChatPromptEditor.tsx
  • src/renderer/src/components/native-chat/NativeChatResolvedView.prompt-card-composer.test.tsx
  • src/renderer/src/components/native-chat/NativeChatResolvedView.tsx
  • src/renderer/src/components/native-chat/NativeChatSelectionQuote.test.tsx
  • src/renderer/src/components/native-chat/NativeChatStructuredSession.crew-pane.test.tsx
  • src/renderer/src/components/native-chat/NativeChatStructuredSession.tsx
  • src/renderer/src/components/native-chat/inline-composer-scaling.test.tsx
  • src/renderer/src/components/native-chat/inline-deferred-input.test.tsx
  • src/renderer/src/components/native-chat/inline-rich-draft-consumers.test.tsx
  • src/renderer/src/components/native-chat/native-chat-agent-reference-send.test.tsx
  • src/renderer/src/components/native-chat/native-chat-agent-reference-send.ts
  • src/renderer/src/components/native-chat/native-chat-agent-reference.test-fixture.tsx
  • src/renderer/src/components/native-chat/native-chat-agent-reference.test.tsx
  • src/renderer/src/components/native-chat/native-chat-agent-reference.tsx
  • src/renderer/src/components/native-chat/native-chat-composer-destination.test.ts
  • src/renderer/src/components/native-chat/native-chat-composer-input.ts
  • src/renderer/src/components/native-chat/native-chat-composer-pasted-text-references.ts
  • src/renderer/src/components/native-chat/native-chat-composer-reveal-focus.test.tsx
  • src/renderer/src/components/native-chat/native-chat-composer-types.ts
  • src/renderer/src/components/native-chat/native-chat-paste-routing.test.tsx
  • src/renderer/src/components/native-chat/native-chat-prompt-document-text.ts
  • src/renderer/src/components/native-chat/native-chat-prompt-document.test.ts
  • src/renderer/src/components/native-chat/native-chat-prompt-document.ts
  • src/renderer/src/components/native-chat/native-chat-queued-edit-draft.test.ts
  • src/renderer/src/components/native-chat/native-chat-queued-edit-lifetime.test-fixture.ts
  • src/renderer/src/components/native-chat/use-native-chat-composer-handle.ts
  • src/renderer/src/components/native-chat/use-native-chat-composer-submit.ts
  • src/renderer/src/components/native-chat/use-native-chat-context-menu.find.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-context-menu.targets.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-find.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-pty-composer-send.ts
  • src/renderer/src/components/native-chat/use-native-chat-root-input-routing.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-structured-composer-send.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-structured-composer-send.ts
  • src/renderer/src/components/native-chat/use-structured-agent-session-queued-edit.test.tsx
  • src/renderer/src/components/orchestration-crew/CrewAgentIcons.test.tsx
  • src/renderer/src/components/orchestration-crew/CrewRowMenu.tsx
  • src/renderer/src/components/orchestration-crew/CrewRowView.tsx
  • src/renderer/src/components/orchestration-crew/LazyOrchestrationCrewPanel.test.tsx
  • src/renderer/src/components/orchestration-crew/NativeChatCrewPanel.tsx
  • src/renderer/src/components/orchestration-crew/OrchestrationCrewPanel.fixture.tsx
  • src/renderer/src/components/orchestration-crew/OrchestrationCrewPanel.test.tsx
  • src/renderer/src/components/orchestration-crew/OrchestrationCrewPanel.tsx
  • src/renderer/src/components/orchestration-crew/TerminalCrewPortals.test.tsx
  • src/renderer/src/components/orchestration-crew/TerminalCrewPortals.tsx
  • src/renderer/src/components/terminal-pane/terminal-crew-mention.ts
  • src/renderer/src/i18n/locales/en.json
  • src/renderer/src/lib/pane-manager/pane-manager-host.ts
  • src/renderer/src/lib/pane-manager/pane-manager-pane-creation.ts
  • src/renderer/src/lib/pane-manager/pane-manager-spawn-placement.test.ts
  • src/renderer/src/lib/pane-manager/pane-manager-types.ts
  • src/renderer/src/lib/pane-manager/pane-manager.ts
  • src/renderer/src/lib/pane-manager/pane-overlay-focus.test.ts
  • src/shared/orchestration-agent-reference.test-fixture.ts
  • src/shared/orchestration-agent-reference.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.

Walkthrough

The change adds native-chat agent-reference nodes, insertion, serialization, pasted-text projection, and send-path coverage. Crew panels can mention individual running workers or all eligible workers. Native-chat mentions insert into the composer, while terminal mentions validate pane and transport state before writing converted references. Pane activation and styling logic move into reusable helpers. Tests cover serialization, focus, caret preservation, queued edits, terminal rejection, and adapter delivery.

Merge Risk: Minimal · up to cd54f

No confirmed issue currently blocks merging. The effect of routing-note newlines in Codex slash commands remains unverified.

Pre-merge checks: Passed 3 · Failed 1 · Inconclusive 1

Failed Failed checks: 1 warning · 1 inconclusive

Check name Status Explanation Resolution
Description check Warning The description provides detailed context, behavior, compatibility notes, and validation results, but it omits most required template sections, including ELI5, explicit What Changed and Why headings, … Rewrite the description using the repository template. Add each required heading and complete the missing information, including the linked issue, visual proof or N/A with a reason, testing platforms and checklist status, risk level and rol…
Docstring Coverage Inconclusive Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the primary user-facing change: one-click agent mentions from the orchestration panel.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides detailed context, behavior, compatibility notes, and validation results, but it omits most required template sections, including ELI5, explicit What Changed and Why headings, a Linked Issue with Fixes entry, Visual Proof, an explicit Risk level and rollback plan, AI Disclosure, Review, Notes, and the Checklist.

Resolution

Rewrite the description using the repository template. Add each required heading and complete the missing information, including the linked issue, visual proof or N/A with a reason, testing platforms and checklist status, risk level and rollback plan, AI disclosure where applicable, review notes, compatibility notes, and checklist confirmations.

Full details: Docstring Coverage

Explanation

Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 35 functions across 50 files. (7 skipped: 1 unsupported, 6 over the file limit.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@brennanb2025
brennanb2025 merged commit 3aa633d into main Nov 2, 2026
58 checks passed
@brennanb2025
brennanb2025 deleted the brennanb2025/orchestration-crew-panel branch November 2, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants