Repository navigation
Mention an agent from the orchestration panel with one click - #34836
Conversation
bd0825e to
1147c3e
Compare
1147c3e to
4783c9f
Compare
b80bb4b to
7d1cabf
Compare
4783c9f to
3e34030
Compare
[Medium impact] The change adds crew mentions across native chat and terminal-pane workflows. Do not merge yet: returned drafts can still lose text when a pending send is accepted. FindingsSummaryAdds one-click agent mentions from the crew panel.
|
Brings the translated Open fallback for agents without a target.
Settings > Experimental > Orchestration panel (experimentalOrchestrationPanel). Off mounts nothing: the chat frame, the terminal-hosted chat's identity lookup and the terminal pane portals all gate where they mount, and toggling applies live without remounting the transcript.
CI on the merged head failed because main moved agent-session-conversation-view under shared/agent-session/lifecycle; the crew mounted-render fixture now imports it from there.
Brings the experimental Orchestration panel setting (default off) and main. Mention's composer ref and readiness now ride on the gated panel element, so the hosts compute nothing for the panel while the setting is off. The goal objective keeps agent-reference serialization on main's new host-goal path. NativeChatPromptEditor's editable effect is one line to stay under the cap.
The message card's avatar and its single-sender hook are back to main's code; the panel keeps its own list hook. The panel's code now loads only when it first mounts, behind the setting.
Brings main's message card and sender hook back for the setting-off path and the lazily loaded panel; Mention rides on the lazy panel element.
A typed multi-line /goal is prose again, as on main; only Mention's own routing lines after a one-line /goal join its objective. A draft with no agent reference skips the reference serializer, so its send text is projected once, as before. The routing line format now lives with the other reference formats.
Brings main and the panel tests' default-built settings.
The shared command parser is main's code again, so any typed or pasted text parses as before. A typed /goal or Goal-mode objective with mentions carries its routing notes on the same line instead.
There /goal goes to the agent as a message, so its notes keep their own lines, as a typed /goal there already does. A draft with no mention sends main's text.
Brings main's Hermes-compatible plugin fingerprint (#37370) so the stacked PR's mobile check can pass.
Brings main's Hermes-compatible plugin fingerprint (#37370).
|
No actionable comments were generated in the recent review.
|
Problem and change
The Orchestration panel (#34891) shows who an agent works with, but asking the current agent to contact one of them still means finding and copying an address. This PR lets a person mention an agent from the panel with one click.
Experimental and off by default, like the panel itself: Mention is reachable only from the Orchestration panel, which shows only when Settings → Experimental → Orchestration panel is on. See "Effect with the setting off" below.
In a native chat, clicking a row's body inserts a mention chip at the composer's cursor. Focus stays in the composer and the panel stays open. Sending produces @name plus one address line per mentioned agent, so the receiving agent can use the existing messaging command. A draft holds each agent once: mentioning an agent already in the draft (from its row or from Mention all) adds nothing and just focuses the composer.
In a terminal, the same click types "name (Orca agent address)" into that pane's input, without Enter. Focus stays in the terminal and the panel stays open. Terminals type text, so they don't skip agents already typed.
Managing's "Mention all" button mentions every unfinished worker. It is dimmed and disabled when the pane can't take input. More also offers Mention in message. A row without a proven address stays visible but can't be mentioned.
Recalling a sent message returns the exact plain text and address lines that were sent; it does not rebuild chips. Answer, Show messages and Stop remain follow-up work.
Design and compatibility
The chip uses the existing draft document and selection APIs. A shared serializer combines captured file references and typed mentions; every send, Goal and queued-edit path keeps its existing admission and body ownership. Intended: where the host sets goals, a goal's address lines follow on the goal's own line, because a typed /goal is applied by re-reading the sent text with the existing one-line /goal rule, which stays unchanged while the panel is off; the common pattern classifies a goal before adding references. Where the agent handles /goal itself, the goal is sent as a message and keeps its address lines on their own lines. Terminal insertion uses the existing paste writer and the captured pane and transport, with no active-pane fallback, no Enter and no new permission cache. The common pattern keeps a target separate from its label and serializes the actual typed content. Intended difference: external agents need a printable Orca address rather than a provider-specific mention object.
Known intended limitation: an older Orca build can open an unsent native-chat draft containing an agent mention as empty. Brennan accepted this downgrade limitation on October 30; no downgrade repair is included. Sent messages and recalled plain text remain authoritative. Direct SSH terminal writes keep the existing lack of delivery acknowledgement; a rejected paired write shows one toast.
Effect with the setting off
Every change in this PR, for a user who has not turned the setting on:
Validation
With the setting off, Mention can't be reached: the panel tests above cover that nothing of it mounts. The shared /goal parser and its tests are main's code. A test covers a mention inside a goal on a host that sets goals (one line, notes included) and on a host where the agent handles /goal (sent as a message with its notes).
Renderer tests cover native and terminal Mention (focus, no Enter, the panel staying open), a restored terminal pane that connects after the panel rendered, refusal into a retired pane or a disconnected terminal, a row Mention followed by Mention all (each agent once), label collisions, unsent copy and caret, queued-edit handback, and the serializer through structured, terminal, typed-goal and Goal sends.
Real-app runs with Claude and Codex agents checked Mention in Claude and Codex native chats, and in Claude and Codex worker terminals. Screenshots are in the review status comment.