Skip to content

test: fix main's typecheck after the conversation view module moved - #37346

Merged
nwparker merged 1 commit into
mainfrom
brennanb2025/main-fix-conversation-view-import
Nov 2, 2026
Merged

nwparker merged 1 commit into
mainfrom
brennanb2025/main-fix-conversation-view-import

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 0
Prod 0 0 0 0

Main's typecheck fails for every PR: src/main/native-chat/agent-model-catalog/agent-model-catalog-scaling.test.ts imports ../../../shared/agent-session-conversation-view, but #37289 moved that module to src/shared/agent-session/lifecycle/agent-session-conversation-view.ts. #37191 added the import after the move landed, so main's "static analysis and typecheck" fails with TS2307.

This points the test at the module's new location. Test-only; no shipped behavior changes. The file's 3 tests pass locally.

#37191 added an import of the old path after #37289 moved the module, breaking
main's typecheck for every PR.
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 832d52f4-5274-4a5b-a14b-8182a6dbda2c
Commits

Reviewing files that changed from the base of the PR and between 999160b and 66c18e4.

Files selected for processing: 1
  • src/main/native-chat/agent-model-catalog/agent-model-catalog-scaling.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nwparker
nwparker merged commit 8ddc35b into main Nov 2, 2026
38 of 41 checks passed
@nwparker
nwparker deleted the brennanb2025/main-fix-conversation-view-import branch November 2, 2026 06:10
brennanb2025 added a commit that referenced this pull request Nov 2, 2026
Brings main's fixes for its own unit checks (#37345, #37346).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants