Internal cleanup by Jinwoo-H · Pull Request #33670 · stablyai/orca

Jinwoo-H · 2026-10-25T23:02:12Z

No description provided.

…ma to what the cloud sends

coderabbitai · 2026-10-25T23:05:38Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: f1e4c42
Latest commit, not reviewed: 65f8bbb

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Adds a private ES-module package that exports connector routes, limits, wire scalars, and versioned schemas for authentication, polling, deliveries, events, and replies. Adds matching machine-side contract constants. Adds schema tests and host-proof vector tests.

Priority: Normal

Merge Risk: Moderate · up to f1e4c

Mixed-version poll compatibility remains unsafe, and direct connector package validation can fail in a fresh checkout until the dependency build prerequisite is added.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 14 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title is specific and accurately describes the main change: a wire contract between Orca and the cloud connector service, added as inert code. It uses the conventional feat(connector) prefix and i…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The pull request description is complete and follows the repository template. It explains the change, motivation, compatibility approach, testing, review history, security impact, lack of UI changes, …

Full details: Title check

Explanation

The title is specific and accurately describes the main change: a wire contract between Orca and the cloud connector service, added as inert code. It uses the conventional feat(connector) prefix and is one sentence. It is 83 characters, which is slightly long but still clear.

Full details: Description check

Explanation

The pull request description is complete and follows the repository template. It explains the change, motivation, compatibility approach, testing, review history, security impact, lack of UI changes, and checklist status. The maintainer correctly marks the linked issue as not applicable. Manual testing was not reported, but automated validation is documented.

Finishing Touches: 💡 2

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: 04edd59e-746d-44e8-b36c-df89ba53f19a

Commits

Reviewing files that changed from the base of the PR and between 23798ef and 3e43652.

Files ignored due to path filters: 1

cloud/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 18

cloud/packages/connector-contract/package.json
cloud/packages/connector-contract/src/connector-endpoints.ts
cloud/packages/connector-contract/src/connector-host-proof-vector.json
cloud/packages/connector-contract/src/connector-host-proof-vector.test.ts
cloud/packages/connector-contract/src/connector-limits.ts
cloud/packages/connector-contract/src/connector-wire-scalars.ts
cloud/packages/connector-contract/src/contract.test.ts
cloud/packages/connector-contract/src/delivery-messages.ts
cloud/packages/connector-contract/src/event-messages.ts
cloud/packages/connector-contract/src/hello-messages.ts
cloud/packages/connector-contract/src/host-auth-messages.ts
cloud/packages/connector-contract/src/index.ts
cloud/packages/connector-contract/src/sign-in-messages.ts
cloud/packages/connector-contract/tsconfig.build.json
cloud/packages/connector-contract/tsconfig.json
config/scripts/check-test-file-runners.mjs
src/main/runtime/connector-host-proof-vector.test.ts
src/shared/connector-cloud-contract.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

coderabbitai · 2026-10-25T23:13:42Z

+  unsettled: z
+    .array(z.object({ deliveryId: OpaqueIdSchema, conversation: ConnectorConversationSchema }))
+    .optional(),
+  deliveries: z.array(ConnectorDeliverySchema).max(CONNECTOR_LIMITS.maxDeliveriesPerPoll),


Major · Data Integrity & Integration · Heavy lift

🔎 Supported by static analysis

Script executed:

cat cloud/packages/connector-contract/src/delivery-messages.ts rg -n 'unsupported|unknown|kind' cloud/packages/connector-contract/src/contract.test.ts

Repository: stablyai/orca

Length of output: 4365

Stop unknown delivery kinds from rejecting the whole poll.

ConnectorPollResponseSchema validates deliveries as z.array(ConnectorDeliverySchema). A delivery whose kind is not start, send, answer, or cancel fails the discriminated union. That failure rejects the whole poll response. The comment above ConnectorDeliverySchema says the machine settles such a delivery as {outcome:'unsupported'}. The schema does not do this, so the machine cannot acknowledge the unknown entry or process the other deliveries in the same poll.

Parse the poll envelope first. Then validate each delivery separately. Settle an unreadable delivery as unsupported when its deliveryId is readable, and keep the other deliveries. This keeps mixed-version clients compatible when the cloud adds a new kind.

The package is inert today, so this defect has no runtime effect yet. It becomes active when a consumer wires the contract.

coderabbitai · 2026-10-25T23:13:42Z

+    .array(z.object({ deliveryId: OpaqueIdSchema, conversation: ConnectorConversationSchema }))
+    .optional(),
+  deliveries: z.array(ConnectorDeliverySchema).max(CONNECTOR_LIMITS.maxDeliveriesPerPoll),
+  control: PollControlSchema.optional()


Minor · Data Integrity & Integration · Quick win

🔎 Supported by static analysis

Script executed:

sed -n '1,90p' cloud/packages/connector-contract/src/delivery-messages.ts rg -n 'control|Control' cloud/packages/connector-contract/src/contract.test.ts

Repository: stablyai/orca

Length of output: 3672

Script executed:

set -o pipefail printf '%s\n' '--- contract.test.ts ---' nl -ba cloud/packages/connector-contract/src/contract.test.ts | sed -n '1,110p' printf '%s\n' '--- schema references ---' rg -n -F --glob '*.ts' -e 'ConnectorPollResponseSchema' -e 'PollControlSchema' -e 'connector-contract' cloud src || test "$?" -eq 1 printf '%s\n' '--- package files ---' rg --files cloud/packages/connector-contract | sort

Repository: stablyai/orca

Length of output: 6699

Ignore controls without a recognized shape.

PollControlSchema accepts only three control shapes. .optional() permits an absent control, but a present control with no recognized shape still causes ConnectorPollResponseSchema to fail. This can hide valid deliveries from mixed-version clients. The contract is not currently consumed, so the impact is limited to future interoperability.

Suggested fix

--- "a/cloud/packages/connector-contract/src/delivery-messages.ts" +++ "b/cloud/packages/connector-contract/src/delivery-messages.ts" @@ -47,7 +47,7 @@ .array(z.object({ deliveryId: OpaqueIdSchema, conversation: ConnectorConversationSchema })) .optional(), deliveries: z.array(ConnectorDeliverySchema).max(CONNECTOR_LIMITS.maxDeliveriesPerPoll), - control: PollControlSchema.optional() + control: PollControlSchema.optional().catch(undefined) }) export const ConnectorDeliveryResultSchema = z.discriminatedUnion('outcome', [

Add a regression test that supplies an unrecognized control and asserts that parsing succeeds with data.control undefined.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

control: PollControlSchema.optional()

control: PollControlSchema.optional().catch(undefined)

…blank question text and labels

…ields

…ginal never undoes newer state

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

⚠️ Outside diff range comments (1)

Minor · Build @orca-cloud/push-contract before connector-contract typecheck and… · package.json:14-17

cloud/packages/connector-contract/package.json:14-17
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Build @orca-cloud/push-contract before connector-contract typecheck and build.

A direct pnpm typecheck or pnpm build in cloud/packages/connector-contract can fail in a fresh checkout. @orca-cloud/push-contract exposes dist/index.d.ts, but its dist directory is not tracked. Only pretest builds that dependency. The workspace-level build supplies the prerequisite, but the package scripts do not.
Suggested fix
     "build": "tsc -p tsconfig.build.json",
+    "prebuild": "pnpm --filter @orca-cloud/push-contract build",
     "typecheck": "tsc -p tsconfig.json --noEmit",
+    "pretypecheck": "pnpm --filter @orca-cloud/push-contract build",

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: d9aa9c9b-3570-4727-9acb-255929f845dd

Commits

Reviewing files that changed from the base of the PR and between 5b7d32c and f1e4c42.

Files selected for processing: 2

cloud/packages/connector-contract/src/contract.test.ts
cloud/packages/connector-contract/src/event-messages.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

…and acks belong to a hello

…gh-water mark

Jinwoo-H added 3 commits October 25, 2026 18:57

feat(connector): add the cloud connector wire contract package (inert)

d8f2e47

fix(connector): own the host handshake shapes; keep the delivery sche…

19ea12c

…ma to what the cloud sends

fix(connector): turn-ended names its turn by the turn-started time

3e43652

coderabbitai Bot reviewed Oct 25, 2026

View reviewed changes

Jinwoo-H added 2 commits October 25, 2026 20:27

fix(connector): one poll control at a time; prompts carry the seam's …

0c517c3

…blank question text and labels

fix(connector): poll controls stay exclusive without refusing added f…

0335ebb

…ields

Jinwoo-H mentioned this pull request Oct 26, 2026

Internal cleanup #33714

Merged

Jinwoo-H closed this Oct 26, 2026

Jinwoo-H reopened this Oct 26, 2026

Merge branch 'main' into jinwoo/connector-contract

5b7d32c

This was referenced Oct 26, 2026

Internal cleanup #33723

Merged

Internal cleanup #33726

Draft

Internal cleanup #33734

Merged

feat(connector): number events batches per host session so a late ori…

f1e4c42

…ginal never undoes newer state

coderabbitai Bot reviewed Oct 26, 2026

View reviewed changes

Jinwoo-H mentioned this pull request Oct 26, 2026

Internal cleanup #33741

Closed

Jinwoo-H added 3 commits October 26, 2026 00:21

feat(connector): machines authenticate with connector tokens; events …

f7d259c

…and acks belong to a hello

docs(connector): the contract states the one-queue rule beside the hi…

daaf8e9

…gh-water mark

docs(connector): rewrap the event-order comment

65f8bbb

Jinwoo-H merged commit 869ae49 into main Oct 26, 2026
50 checks passed

Jinwoo-H mentioned this pull request Oct 26, 2026

Internal cleanup #33852

Merged

Jinwoo-H changed the title ~~feat(connector): wire contract between Orca and the cloud connector service (inert)~~ Internal cleanup Nov 4, 2026

Navigation Menu

Repository navigation

Internal cleanup - #33670

Internal cleanup#33670
Jinwoo-H merged 10 commits into
mainfrom
jinwoo/connector-contract

Jinwoo-H commented Oct 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Reviews paused

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Oct 25, 2026

Uh oh!

coderabbitai Bot Oct 25, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	control: PollControlSchema.optional()
	control: PollControlSchema.optional().catch(undefined)

Conversation

Jinwoo-H commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Jinwoo-H commented Oct 25, 2026 •

edited

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading