Skip to content

Internal cleanup - #33741

Closed
Jinwoo-H wants to merge 7 commits into
jinwoo/connector-cloud-loginfrom
jinwoo/connector-poll-client
Closed

Jinwoo-H wants to merge 7 commits into
jinwoo/connector-cloud-loginfrom
jinwoo/connector-poll-client

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

…ch delivery onto the connector seam (experimental)
… messages on a byte boundary the orcad bundle accepts
…revoked after stop; confirmations retry on their own backoff
…g keeps a Retry-After; logout before connect clears the outbox
…, snapshot first; the client reaches the cloud through a small transport interface
@blacksmith-sh

blacksmith-sh Bot commented Oct 26, 2026

Copy link
Copy Markdown

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
[electron-headless] › tests/e2e/
orcad-serve-mode-switch.spec.ts:201:5 › each serve host refuses a profile the other hol
ds
View Logs
tests/e2e/orcad-serve-mode-switch.spec.ts/
each serve host refuses a profile the other holds
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

This was referenced Oct 26, 2026
@Jinwoo-H

Copy link
Copy Markdown
Contributor Author

Superseded by #33852 (desktop connector poll with relay-style connector tokens), stacked on #33821.

@Jinwoo-H
Jinwoo-H marked this pull request as draft October 26, 2026 08:30
@OrcaWin

OrcaWin commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Closing as superseded by merged #33852 (98690db2ab1), together with #33821's cloud-assigned hello contract. This agrees with the author's supersession note here and was checked against current origin/main (1a723194c32).

I compared this PR's complete production scope and regression intent. dispatchDelivery and DeliveryReceipts are byte-identical on main: independent delivery decoding, deadline refusal, received/done confirmations, deterministic launch identity and restart receipt recovery remain. Project/host enumeration, turn IDs, the 200 persisted turn-end / 500 live-event caps and the single held poll are retained.

The old machine-key/session generation and desktop/serve startup were deliberately replaced by the desktop's existing Orca account and short-lived connector tokens. The old send queue is superseded by one account-owned outbox: pending work leaves only after the accepted hello's confirmed response, snapshots start numbering at zero, stale requests receive 409, and retries retain ordering. Main also adds request-byte sizing, recovery after lost polls and account isolation. These replace the intermediate auth/hello/queue semantics rather than losing their reliability intent.

Six current cloud/poll/places/turn-events/outbox/receipt suites passed 58 tests. Headless sign-in remains an explicit follow-up; this closure does not claim orca serve connector support or a live Slack deployment.

@OrcaWin OrcaWin closed this Oct 26, 2026
@Jinwoo-H Jinwoo-H changed the title feat(connector): the machine holds one poll to Orca Cloud and hands each Slack delivery to the connector seam (experimental) Internal cleanup Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants