Repository navigation
fix(i18n): complete six locale catalogs and include community Portuguese translations - #32782
Conversation
Rolls in the 69 missing translations from #32017 by @lucasrbsouza, preserving the current catalog and his original translated values. Adapted from commits a103b8d and 81befb5.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly summarizes the main change: completing six locale catalogs and including community Portuguese translations. |
| Description check | |
The description is mostly complete. It explains the user impact, scope, rationale, linked issues, visual evidence, testing, review status, and upstream boundary. The AI Disclosure, Notes, and Checklis… |
| Linked Issues check | |
The six locale catalogs under src/renderer/src/i18n/locales/ add missing entries and replace copied-English values for #32316. The PR reports that only the 11 provider-balance fallback keys remain m… |
| Out of Scope Changes check | |
The change is limited to the six locale JSON catalogs named by #32316 and #32016. The added and revised strings support the linked catalog coverage and translation objectives. No unrelated application… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
Full details: Description check
-
Explanation
The description is mostly complete. It explains the user impact, scope, rationale, linked issues, visual evidence, testing, review status, and upstream boundary. The AI Disclosure, Notes, and Checklist sections are not included, but these omissions do not prevent review.
Full details: Linked Issues check
-
Explanation
The six locale catalogs under
src/renderer/src/i18n/locales/add missing entries and replace copied-English values for#32316. The PR reports that only the 11 provider-balance fallback keys remain missing and that placeholder, rich-text, policy, catalog, and delta checks pass. The Portuguese catalog also includes the#32016messages and preserves interpolation variables and plural variants. The PR reports 81 passing localization tests and a passingpnpm run verify:localization-catalogscheck.
Full details: Out of Scope Changes check
-
Explanation
The change is limited to the six locale JSON catalogs named by
#32316and#32016. The added and revised strings support the linked catalog coverage and translation objectives. No unrelated application logic, mobile catalog, or runtime behavior changes are shown.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔇 Additional comments: 1
src/renderer/src/i18n/locales/fr.json-12786-12786: 1
12786-12786: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Correct the French remote-server action label.
Ouvrir Serveurs Orca distantsis not grammatical French. UseOuvrir les serveurs Orca distantsso the action clearly references theServeurs Orca distantsmenu.
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
89edd29c-8fa3-4170-80d8-cd63f0393086
📒 Files selected for processing: 6
src/renderer/src/i18n/locales/es.jsonsrc/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/pt.jsonsrc/renderer/src/i18n/locales/zh.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
|
@coderabbitai Fixing. Will be in the next commit |
|
Tip For best results, initiate chat on the files or code changes. @AmethystLiang Thanks for the update. The finding remains open pending the next commit. You are interacting with an AI system. |
187 commits landed on main between f045046 and 7cafdb0. All seven catalogs conflicted along with en-runtime-required.json, so they are taken from main and the prune is recomputed in one pass. It is the previous 1,624 keys plus 9: five lost their reader when stablyai#32284 unified the single and multiple PR hover details, two when stablyai#31688 moved skill updates to Orca's own installer, and two when stablyai#28709 reworked where chat agents are offered. None left the set. Since stablyai#32782 filled the missing entries in the other catalogs, all seven now shed the same 1,633 keys. en.json goes from 16,992 entries to 15,359; en-runtime-required.json keeps 615 of them. native-chat-shared-copy-matches-catalog.test.ts merged cleanly this time and still differs from main by exactly the branch's edit.
ELI5
Selecting Spanish, French, Japanese, Korean, Brazilian Portuguese, or Simplified Chinese now shows translated text in places that previously fell back to English.
What Changed
Fill 1,357 missing catalog entries and replace 379 copied-English values. Review fixes cover technical terminology, browser permission prompts, Korean verb endings, account restarts, and remote-host instructions. Preserve placeholders, rich-text tags, commands, product names, and unrelated translations.
Includes the 69 Brazilian Portuguese translations from #32017 unchanged in a separate commit authored by Lucas Souza (@lucasrbsouza). His original translations and contributor credit are retained; the additional Portuguese gaps are filled alongside them.
Why
Missing entries and copied-English sentences bypassed localization. Only the 11 intentional provider-balance fallback keys remain missing in es/fr/ja/ko/zh; Portuguese now covers all 16,950 English keys. Legitimate identical technical strings and French cognates remain intact.
Linked Issue
Fixes #32316.
Fixes #32016.
Visual Proof
Portuguese before/after evidence from #32017, showing translations imported unchanged here:
Before:
After:
Other changed messages were reviewed in the catalogs and verified through localization tests; no additional rendered UI testing is claimed.
Testing
pnpm run verify:localization-catalogspasses.git diff --check, and the changed-code quality gate pass.Review
Self-reviewed translation wording and catalog integrity. Six locale JSON files change; runtime and protocol behavior remain unchanged across desktop/web, SSH hosts, folder workspaces, and supported operating systems. Separate mobile catalogs are outside this issue.
Agent skill upstream boundary