Skip to content

fix(i18n): fill 69 missing Brazilian Portuguese translations - #32017

Closed
lucasrbsouza wants to merge 3 commits into
stablyai:mainfrom
lucasrbsouza:fix/pt-br-missing-translations
Closed

lucasrbsouza wants to merge 3 commits into
stablyai:mainfrom
lucasrbsouza:fix/pt-br-missing-translations

Conversation

@lucasrbsouza

@lucasrbsouza lucasrbsouza commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What changed

After selecting Português (Brasil), some existing Orca screens still display English. This adds 69 missing Brazilian Portuguese messages for browser suggestions and zoom/appearance controls, agent settings, release-build search, plain SSH terminals, native chat, unsaved-file warnings, and file-search filters.

Only src/renderer/src/i18n/locales/pt.json changes. All 16,777 current Portuguese values, interpolation variables, technical names, and current UTF-8 safety warnings are preserved. Coverage on the updated base increases from 16,777 to 16,846 of 16,925 English leaves; 79 newer messages remain outside this patch.

Fixes #32016.

Validation

  • Reproduced on current main through Settings > Appearance > Language > Português (Brasil) > Browser: Zoom Padrão appears above the English default-zoom hint.
  • Verified the translated hint in the real hidden Electron renderer in dark and light themes, plus English > Portuguese switching through the actual language control.
  • Verified the translated address placeholder and new-tab guidance in a folder workspace, including wrapping at 1100px viewport width.
  • 76 localization tests in six suites pass after independent review, full renderer typecheck passes, official localization catalog verification passes, and formatting/changed-code quality checks pass.
  • Strict catalog audit preserves all current Portuguese values and checks every added placeholder and singular/plural pair. No new inventory tests are needed for this data-only change.

Before:

Portuguese settings with English fallback

After:

Portuguese settings with translated zoom hint

The same existing desktop/web localization system serves these catalog entries; no runtime, protocol, native-platform, or separate mobile catalog change. Not every added failure/warning state was manually rendered, and no live remote or native Windows/Linux rendering is claimed.

Merge risk

LOW risk; no blockers in independent review. Post-review verification repeats the real language-selection/reload flow, all 69 production translation lookups and 12 plural cases, 76 tests, full renderer typecheck, catalog verification, formatting, and changed-code quality. All evidence refers to head a4e4471d596cfbd4f9ebd4c62df22faed8cdf85e. Fresh exact-head CI has passed; no merge has been performed.

Contributor credit

Original contribution by @lucasrbsouza (Lucas Souza), with exact original commit 81befb581a2fd1ac29e12e1844a942c0818bb303 preserved. The updated branch retains current main translations where one of the original 70 missing entries has since been supplied.

AI disclosure

Prepared and validated with OpenAI Codex, including catalog audit and copy review.

Exact-head CI verified 2026-10-23 at 08:02 PT: all four workflows SUCCESS, 14 successful/19 skipped selected checks, zero pending or failing. Both packages, all five unit shards, static/typecheck and evidence checks passed. Original PR remains open and unmerged.

Translate 70 missing messages across browser controls, agent settings,
SSH terminals, native chat, unsaved edits, and file search.
Preserve existing translations and all interpolation placeholders.
@lucasrbsouza
lucasrbsouza marked this pull request as ready for review October 22, 2026 13:31
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f4af9a27-70e0-4454-97db-0d340ac068aa
📥 Commits

Reviewing files that changed from the base of the PR and between 81befb5 and a4e4471.

📒 Files selected for processing: 1
  • src/renderer/src/i18n/locales/pt.json
🚧 Files skipped from review as they are similar to previous changes: 1
  • src/renderer/src/i18n/locales/pt.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The Portuguese locale adds Brazilian Portuguese translations for existing browser, agent, chat, SSH terminal, workspace, build-search, and file-search messages. The additions include browser controls and suggestions, chat and plan actions, terminal states, unsaved-file handling, and search labels. No application logic changes.

Priority: ➖ Normal

Severity of issue fixed: Medium

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description is detailed and substantive, but it does not follow the repository template. It has no ELI5, Review, or AI Disclosure heading in the template's form, no Linked Issue in the template fo… Restructure the description to match the repository template. Add the ELI5 section in plain language. Rename the change summary to 'What Changed' and add a 'Why' section that explains the problem and why this approach was chosen over altern…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the primary change: adding missing Brazilian Portuguese translations. It is concise and directly related to the changeset.
Linked Issues check Passed The pull request addresses active issue [#32016]. It adds the reported missing Brazilian Portuguese catalog entries for the affected browser, appearance, agent, release-build, SSH, chat, unsaved-file,…
Out of Scope Changes check Passed The supplied change summary identifies only src/renderer/src/i18n/locales/pt.json as changed. The additions support the translation objective in [#32016]. No unrelated runtime, protocol, native-plat…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The pull request addresses active issue [#32016]. It adds the reported missing Brazilian Portuguese catalog entries for the affected browser, appearance, agent, release-build, SSH, chat, unsaved-file, and file-search areas. The current description explains that one entry was supplied on the updated base, so the patch adds 69 remaining entries. The reported audit checks key coverage, interpolation variables, singular/plural variants, duplicate keys, and preservation of existing Portuguese values. The reported localization tests and renderer typecheck also pass.

Full details: Out of Scope Changes check

Explanation

The supplied change summary identifies only src/renderer/src/i18n/locales/pt.json as changed. The additions support the translation objective in [#32016]. No unrelated runtime, protocol, native-platform, mobile-catalog, dependency, or behavior changes are reported.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description is detailed and substantive, but it does not follow the repository template. It has no ELI5, Review, or AI Disclosure heading in the template's form, no Linked Issue in the template format (it cites 'Fixes #32016' only inside prose), no 'Visual Proof' section with a labeled BEFORE/AFTER format (it uses embedded images, which is close), no Testing checkbox list, no Agent skill upstream boundary section, no Notes or Checklist. Content is mostly complete for the change itself, but several required template sections are missing or only partly addressed.

Resolution

Restructure the description to match the repository template. Add the ELI5 section in plain language. Rename the change summary to 'What Changed' and add a 'Why' section that explains the problem and why this approach was chosen over alternatives. Put the issue link in the 'Linked Issue' section as 'Fixes #32016'. Keep the before and after images under 'Visual Proof'. Add the 'Testing' section with the platforms actually tested and tick the manual testing and automated tests boxes as applicable. Add the 'AI Disclosure' section with model and version details, since Codex is named but the specific model is not. Add the 'Review' section with the agent skill upstream boundary checkbox, marking it N/A with a reason. Add the 'Notes' section that covers security, cross-platform, remote SSH, mobile, backward compatibility, and performance. Add the 'Checklist' section with the items checked or marked N/A.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 84268e0c-2c1c-42ce-aa45-ebf0a21f9498
📥 Commits

Reviewing files that changed from the base of the PR and between d053ff9 and a103b8d.

📒 Files selected for processing: 1
  • src/renderer/src/i18n/locales/pt.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Comment thread src/renderer/src/i18n/locales/pt.json Resolved
…r-missing-translations

# Conflicts:
#	src/renderer/src/i18n/locales/pt.json
@nwparker nwparker changed the title fix(i18n): fill 70 missing Brazilian Portuguese translations fix(i18n): fill 69 missing Brazilian Portuguese translations Oct 23, 2026
@AmethystLiang

Copy link
Copy Markdown
Contributor

Rolled into #32782, which includes these 69 Brazilian Portuguese translations unchanged alongside the fixes for the other locale catalogs.

@lucasrbsouza, your contribution is credited in that PR’s description and in a separate commit authored by you: 6138d0f. Thank you for the translations! Closing this PR because the work is now included there.

AmethystLiang pushed a commit that referenced this pull request Oct 23, 2026
Rolls in the 69 missing translations from #32017 by @lucasrbsouza, preserving the current catalog and his original translated values. Adapted from commits a103b8d and 81befb5.
@lucasrbsouza
lucasrbsouza deleted the fix/pt-br-missing-translations branch October 26, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Brazilian Portuguese falls back to English for 70 current UI messages

3 participants