Repository navigation
Conversation
nwparker
force-pushed
the
nwparker/wsl-mover-p1-split-shells
branch
from
October 23, 2026 11:44
a9274db to
ebee49b
Compare
nwparker
force-pushed
the
nwparker/wsl-mover-p1-paused-panes
branch
from
October 23, 2026 11:44
cd27476 to
f9e25f7
Compare
nwparker
force-pushed
the
nwparker/wsl-mover-p1-split-shells
branch
from
October 23, 2026 14:31
ebee49b to
23adc7b
Compare
nwparker
force-pushed
the
nwparker/wsl-mover-p1-paused-panes
branch
from
October 23, 2026 14:31
f9e25f7 to
38291e2
Compare
…browser tabs D1b-10 real-host run on awin (report bug 7, with bug 8 pinned), and verify-3: - A pane slept before the move had no live terminal, so its last folder never reached the restore hints and it reopened at the project root (verify-3 lost `deep/`). The pause step now adds the panes the saved session or the window still binds, through the slept-pane listing that already feeds their history, so hints and history read the same panes. - The move pauses projects through Sleep, which closes a workspace's browser tabs, so a moved project lost its in-app browser tab. A move's Sleep request now asks the renderer to keep them; an older renderer ignores the field. - A moving project's unsaved draft carries (the host-session seed lays it back); a test pins that it never refuses the move. Co-Authored-By: Claude <noreply@anthropic.com>
nwparker
force-pushed
the
nwparker/wsl-mover-p1-split-shells
branch
from
October 23, 2026 15:41
23adc7b to
501641f
Compare
nwparker
force-pushed
the
nwparker/wsl-mover-p1-paused-panes
branch
from
October 23, 2026 15:41
38291e2 to
a63e76f
Compare
11 of 12 tasks
Contributor
Author
|
Contained in the dark landing PR #34059 (its head commit is an ancestor of the landing branch). Closing in favour of it; branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Things a WSL move lost in the D1b-10 real-host run on awin (report bugs 7 and 8) and in verify-3:
deep/. fix(wsl-mover): fix the P0s the first real-machine move run found #32343 already carries such a pane's history; this carries its folder.Mechanism
listWslMoveSleptSessionPanes: bindings the saved session still holds, plus the window-reportedsleptPanes, each checked against the moved workspaces. Restore hints and history now read the same panes. These panes were never live, so the exit proof's session set is unaffected for them.keepBrowserTabs: true, and the renderer then skipsshutdownWorktreeBrowsers. An older renderer ignores the field.Testing
wsl-move-driver.test.ts: a pane slept before the move, both one the saved session binds and one only the window reports, reaches the restore-hint capture (fails on the old code).sleep-worktree-flow.test.ts,worktree-sleep-request-relay.test.ts: the move's Sleep keeps browsers; other callers unchanged.wsl-move-manifest-export.test.ts: an in-scope draft carries without a blocker.pnpm tcand the changed-code quality gate pass.