Repository navigation
Conversation
nwparker
force-pushed
the
nwparker/wsl-mover-p1-split-shells
branch
from
October 23, 2026 11:44
a9274db to
ebee49b
Compare
Contributor
Author
|
Standalone version for main: #32418, which is the same change. When the stack is next rebased onto a main that has #32418, drop this commit ( |
nwparker
force-pushed
the
nwparker/wsl-mover-p1-split-shells
branch
from
October 23, 2026 14:31
ebee49b to
23adc7b
Compare
Contributor
Author
…t fresh agents A moved (or any headless-restored) agent tab with a plain shell split beside the agent pane brought every split back as a new agent: the start path used the tab-wide launchAgent for each pane that had no recorded session. Tab-wide launch evidence now applies only to a tab's sole pane, as the renderer already treats it. Found in the D1b-10 real-host run on awin (report bug 6). Co-Authored-By: Claude <noreply@anthropic.com>
nwparker
force-pushed
the
nwparker/wsl-mover-p1-split-shells
branch
from
October 23, 2026 15:41
23adc7b to
501641f
Compare
Contributor
Author
|
Contained in the dark landing PR #34059 (its head commit is an ancestor of the landing branch). Closing in favour of it; branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a WSL move, a plain shell split beside an agent pane came back as a new agent with a new session, and lost its folder (D1b-10 real-host run on awin, report bug 6).
Before / after
codexsessions.Mechanism
When a host starts a saved pane with no live terminal (
materializePendingMobileSessionTerminal), a pane with no recorded agent session fell back to the tab-widelaunchAgentand launched that agent.launchAgentdescribes the tab, not a pane. The fallback (and thelaunchAgentlabel on the spawn) now applies only when the tab has a single pane, the same rule the renderer already uses for tab-wide launch evidence.Why this approach
The per-pane sleeping record already says which pane ran an agent; only the tab-wide fallback was wrong. Keeping the fallback for single-pane tabs preserves the #7587 rescue (a pending agent tab whose startup command never arrived).
Testing
mobile-session-tabs-split-agent-tab.spec.ts: split sibling starts as a shell (fails on the old code), the recording pane still resumes, and no pane starts a fresh agent without a record (fails on the old code).orca-runtime.test.ts: 1455 pass; the 2 failing folder-import tests fail the same way on the base commit.pnpm tcand the changed-code quality gate pass.