Skip to content

fix(i18n): clarify Japanese phone control and connection wording - #31467

Merged
nwparker merged 1 commit into
mainfrom
nwparker/mobile-ja-phone-control
Oct 21, 2026
Merged

nwparker merged 1 commit into
mainfrom
nwparker/mobile-ja-phone-control

Conversation

@nwparker

@nwparker nwparker commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​9 $\color{#cf222e}{\Huge{\mathbf{−}}}$​9 0

Closes #29247.

ELI5

The Japanese text now says that a smartphone controls the session, and that clicking Restore returns it to the desktop window size. It no longer sounds like a telephone call or promises restoration before the user acts.

Problem

Nine translations used misleading phone/control terminology, an imperative “take everything back,” or wording that suggested automatic restoration. Relay descriptions also confused cellular service with a telephone.

Design

Adopt the nine Japanese wording corrections from #29248. Use consistent スマホ terminology, explain manual restoration, and distinguish mobile data from Wi-Fi. This changes only the Japanese locale catalog.

Verification

  • Reproduced the old wording by rendering the baseline catalog in the actual MobileDriverOverlay and BrowserMobileDriverOverlay components.
  • Rendered both terminal ownership states and the browser take-back failure in a hidden Electron renderer via Playwright CDP, using the production stylesheet and components. The fixture injects driver state and a rejected take-back callback; it does not claim a real phone takeover/network test.
  • Opened and visually checked the before/after screenshots: text wraps inside the cards, buttons fit, and the failure remains visible with a retry action.
  • pnpm run verify:localization-catalogs: existing entries in all locale catalogs verified. Commit format hook passed.
  • Independent review by another native Codex agent found no blocking issues and reviewed the Japanese meaning. This is agent language review, not external native-speaker signoff.
  • Mobile consideration: these changed strings belong to the desktop side of phone control, relay settings, and Windows firewall notices. The mobile app's copy/runtime are unchanged. Real simslim iOS parser proof was performed separately for the companion pairing fix; it is not evidence of these desktop strings.

Before / after

Actual production overlays rendered in hidden Electron. Before and after use identical component state; only the catalog differs.

Before After
Before Japanese phone-control wording After Japanese phone-control wording

Community credit

Based on #29248 by @sojiro-o, including the updated plain-language phone-control notice. The commit includes Co-authored-by: sojiro-o <53679703+sojiro-o@users.noreply.github.com>.

Merge risk

Low: nine locale values only; no keys, interpolation, behavior, remote protocol, platform logic, or mobile code changed. Final terminology can still benefit from a human Japanese-speaking review.

Adopt the nine Japanese corrections reviewed from community PR #29248.

Co-authored-by: sojiro-o <53679703+sojiro-o@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ca31add-17b7-43e0-8b5b-3c5cfb20b4bd
📥 Commits

Reviewing files that changed from the base of the PR and between 84af8ef and 280381a.

📒 Files selected for processing: 1
  • src/renderer/src/i18n/locales/ja.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit 29a1446 into main Oct 21, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Japanese: phone-control messages say 電話 (telephone), 全部取り戻せ, and promise an automatic restore

1 participant