Repository navigation
fix(i18n): clarify Japanese phone control and connection wording - #31467
Merged
Merged
Conversation
Adopt the nine Japanese corrections reviewed from community PR #29248. Co-authored-by: sojiro-o <53679703+sojiro-o@users.noreply.github.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29247.
ELI5
The Japanese text now says that a smartphone controls the session, and that clicking Restore returns it to the desktop window size. It no longer sounds like a telephone call or promises restoration before the user acts.
Problem
Nine translations used misleading phone/control terminology, an imperative “take everything back,” or wording that suggested automatic restoration. Relay descriptions also confused cellular service with a telephone.
Design
Adopt the nine Japanese wording corrections from #29248. Use consistent スマホ terminology, explain manual restoration, and distinguish mobile data from Wi-Fi. This changes only the Japanese locale catalog.
Verification
MobileDriverOverlayandBrowserMobileDriverOverlaycomponents.pnpm run verify:localization-catalogs: existing entries in all locale catalogs verified. Commit format hook passed.Before / after
Actual production overlays rendered in hidden Electron. Before and after use identical component state; only the catalog differs.
Community credit
Based on #29248 by @sojiro-o, including the updated plain-language phone-control notice. The commit includes
Co-authored-by: sojiro-o <53679703+sojiro-o@users.noreply.github.com>.Merge risk
Low: nine locale values only; no keys, interpolation, behavior, remote protocol, platform logic, or mobile code changed. Final terminology can still benefit from a human Japanese-speaking review.