Skip to content

fix(i18n): clarify Japanese phone control and connection wording - #29248

Closed
sojiro-o wants to merge 2 commits into
stablyai:mainfrom
sojiro-o:sojiro-o/ja-phone-wording
Closed

sojiro-o wants to merge 2 commits into
stablyai:mainfrom
sojiro-o:sojiro-o/ja-phone-wording

Conversation

@sojiro-o

@sojiro-o sojiro-o commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Some Japanese messages about using Orca from a phone called the phone a "telephone call", told users to "take it all back!", and said the terminal would restore itself when it won't. This fixes those Japanese strings.

What Changed

Nine values in src/renderer/src/i18n/locales/ja.json. English copy, code, and other languages are unchanged.

English Before After
Still sized for your phone スマートフォンにぴったりのサイズ スマホのサイズのままです
Your phone session ended. Restore to fit this window. 電話セッションが終了しました。このウィンドウに合わせて復元します。 スマホでの操作が終了しました。復元すると、このウィンドウのサイズに戻ります。
Take back all 全部取り戻せ すべての操作を取り戻す
Desktop typing is paused. Output keeps streaming. デスクトップの入力が一時停止されます。出力はストリーミングを続けます。 デスクトップからの入力は止まっています。出力の表示は続きます。
This tab is being controlled from your phone. Take back to use it on desktop. このタブはスマートフォンから制御されています。持ち帰ってデスクトップで使用します。 このタブはスマホから操作されています。操作を取り戻すと、デスクトップで使えます。
Couldn't take back this tab. Check the phone session, then try again. このタブを元に戻すことができませんでした。電話セッションを確認して、もう一度試してください。 このタブの操作を取り戻せませんでした。スマホでの接続状況を確認して、もう一度試してください。
Allow phone connections 電話接続を許可 スマホからの接続を許可
Connect Orca Mobile to this desktop across cellular or any Wi-Fi. (settings and sign-out card) Orca Mobile を携帯電話または Wi-Fi 経由でこのデスクトップに接続します。 Orca Mobile をモバイル回線でも、どの Wi-Fi からでも、このデスクトップに接続します。

Why

The old wording misled Japanese users: after a phone session the banner read like a feature ("perfect smartphone size") and promised an automatic restore, so it was unclear that pressing Restore was needed. The new strings reuse terms already in the same overlays (スマホ, 操作を取り戻す, 復元) rather than introducing new ones, and only the Japanese catalog changes, so nothing else is affected.

Linked Issue

Fixes #29247

Visual Proof

N/A — wording only, no layout change. Before/after text is in the table above.

Testing

  • node config/scripts/verify-localization-catalog.mjs passes.

  • pnpm test src/renderer/src/i18n passes (118 tests).

  • No new tests: string-pinning catalog tests were removed in perf(ci): cut redundant tests and reuse expensive setup #28669, so none were added.

  • Not launched locally.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

AI Disclosure

Written with OpenAI Codex (GPT-6) and Claude Code (Claude Opus 5.5). Reported by a Japanese-speaking user.

Review

Each changed value was checked against its English source and the neighbouring Japanese strings in the same overlay.

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Translation-only change; no effect on security, platforms, SSH, Mobile behavior, or compatibility.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

Describe retained phone sizing and manual restoration accurately. Use consistent smartphone and take-back terminology, and clarify cellular and Wi-Fi connection descriptions.
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d44ac159-5686-4fa0-8808-363a0b7b66fe
📥 Commits

Reviewing files that changed from the base of the PR and between c8ace29 and c5bfed8.

📒 Files selected for processing: 1
  • src/renderer/src/i18n/locales/ja.json
🚧 Files skipped from review as they are similar to previous changes: 1
  • src/renderer/src/i18n/locales/ja.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The Japanese locale updates mobile-control messages to refer to smartphone control and clarify control recovery. Both Orca Relay descriptions specify mobile networks or any Wi-Fi network. The browser-control failure message now directs users to check the smartphone connection.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c5bfe

The Japanese wording reviewed here clarifies that the terminal stays phone-sized until restored. No issue requiring a fix before merge was established.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the focused change: clarifying Japanese phone-control and connection wording.
Description check Passed The description covers the required sections, linked issue, user-facing changes, rationale, testing, visual-proof exception, review, and checklist. It is sufficiently complete, although it inconsisten…
Linked Issues check Passed Issue #29247 requires Japanese-only corrections for phone-control messages. The reviewed change updates only src/renderer/src/i18n/locales/ja.json. It uses スマホ for phone, 操作を取り戻す for take back, …
Out of Scope Changes check Passed The change is limited to Japanese localization values in src/renderer/src/i18n/locales/ja.json. It does not change English copy, application code, other locales, or behavior. The updated desktop-inp…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Description check

Explanation

The description covers the required sections, linked issue, user-facing changes, rationale, testing, visual-proof exception, review, and checklist. It is sufficiently complete, although it inconsistently states that nine values changed while the table and objectives identify eight.

Full details: Linked Issues check

Explanation

Issue #29247 requires Japanese-only corrections for phone-control messages. The reviewed change updates only src/renderer/src/i18n/locales/ja.json. It uses スマホ for phone, 操作を取り戻す for take back, and モバイル回線 for cellular connectivity. It also clarifies that the terminal remains at phone size until the user restores it. The banner, tab-control, connection, and restoration messages are covered. The reported localization verification and i18n tests support the catalog change.

Full details: Out of Scope Changes check

Explanation

The change is limited to Japanese localization values in src/renderer/src/i18n/locales/ja.json. It does not change English copy, application code, other locales, or behavior. The updated desktop-input message is part of the affected phone-control overlay and supports the linked issue scope.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

nwparker added a commit that referenced this pull request Oct 21, 2026
)

Adopt the nine Japanese wording corrections from community PR #29248. Clarify smartphone control, manual restoration, and mobile data connections.

Closes #29247.

Co-authored-by: sojiro-o <53679703+sojiro-o@users.noreply.github.com>
@nwparker

Copy link
Copy Markdown
Contributor

Superseded by merged #31467, which adapts this contribution to the current code and includes the original contributor as a co-author in the merge commit. Thank you @sojiro-o for the fix. Closing this duplicate now that the replacement is on main.

@nwparker nwparker closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Japanese: phone-control messages say 電話 (telephone), 全部取り戻せ, and promise an automatic restore

2 participants