Repository navigation
test(e2e): read Space rows from the separate Space window - #29627
Merged
Merged
Conversation
Space opens in its own window since #29513, so the full-suite spec waited on the main window for checkboxes that now render in space.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A full-suite end-to-end test for the disk-usage ("Space") view was looking for its rows in the wrong window. Space now opens in its own window, so the test now looks there.
What Changed
workspace-space-git-status.spec.tscalledopenSpacePage()and then waited 30s for 60 row checkboxes in the main Orca window. Since feat(space): open disk usage in a separate window #29513,openSpacePage()asks main to open a separatespace.htmlwindow and leaves the main window's view unchanged, so the main window never shows those rows and the test failed every time (3/3 locally on main, and in the full-suite run 38888262404).space.htmlwindow that Electron opened and runs the same two assertions (all 60 rows render, none says "git not checked") against that window.No product code changes.
Why
This is a test update for intended behaviour, not a regression: #29513 moved Space into its own window on purpose, and the per-row git status check the test protects still works in the new window. The spec only runs in the scheduled/dispatched full e2e suite, so #29513's PR checks never ran it. Keeping the test and pointing it at the new window preserves its coverage, which is better than deleting it.
Linked Issue
N/A (release-gate triage of full e2e run 38888262404).
Visual Proof
N/A: test-only change.
Testing
ORCA_BACKGROUND_LAUNCH=1 ORCA_E2E_WEB_CLIENT=1 pnpm run test:e2e tests/e2e/workspace-space-git-status.spec.ts --workers=1 --repeat-each=3: 3/3 pass on macOS (it failed 3/3 before this change). The Space window opens hidden under background launch.oxlint (root plus type-aware),
check:code-quality:changed,pnpm typecheck, and the max-lines, focus-read, ts-nocheck and reliability-gate ratchets all pass.Codex review (gpt-6.1-sol, high): no findings.
I manually tested these changes locally
Automated tests added/updated, or explained why not below