Repository navigation
feat(space): open disk usage in a separate window - #29513
Merged
Merged
Conversation
nwparker
marked this pull request as ready for review
October 16, 2026 08:06
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 16, 2026
nwparker
added a commit
that referenced
this pull request
Oct 16, 2026
Space opens in its own window since #29513, so the full-suite spec waited on the main window for checkboxes that now render in space.html.
3 of 5 tasks
smwbev
added a commit
to smwbev/orca
that referenced
this pull request
Oct 16, 2026
312 commits landed on main between 67fe1e1 and 5db05e8, and the es, ja, ko and zh catalogs and en-runtime-required.json conflicted. All six catalogs are taken from main and the prune is recomputed in one pass: 1,480 keys. Five keys joined the set and none left: four labels of the old disk-usage panels that stablyai#29513 replaced, and workspaceSpace.chart.workspaceSizes, which stablyai#29567 stopped reading and which exists only in en.json. en.json goes from 16,175 entries to 14,695; en-runtime-required.json keeps 567 of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Space now opens beside the main Orca window, so reviewing disk usage does not replace the workspace you were using.
What Changed
Before, Review navigated the main window to Space. Now it opens one dedicated Space window and reuses it when opened again. The main window supplies current workspace and safety information; scans and deletions flow back so both windows stay current. The Space view has a clearer first scan prompt, chart, summary, and selection state. Local disk measurement now runs through workers: the existing process worker starts
du, and a dedicated scan worker parses its output or traverses the filesystem whenduis unavailable. Discovered worktrees that Orca does not manage remain inspectable but cannot be selected for deletion.Why
A dedicated native window lets people compare disk usage with their active workspace. Reusing the existing Space view and deletion flow keeps its safety checks in one place. The review also corrected misleading linked-worktree totals, a preview translation that reported healthy workspaces as unavailable, and a saved-scan race that hid folder details after reopening the window. Worker startup and scan failures produce an unavailable row rather than moving the traversal back onto Electron’s main thread.
Linked Issue
None (maintainer change).
Visual Proof
Before: Space is accessed from the Resource Manager card.
After: Space opens in its own window with the scan overview and folder breakdown.
The new first scan state:
Testing
dutimeout, scan capacity, and a failed-worker path. A built scan worker returned a real folder result from a non-main thread.pnpm tc,pnpm run check:code-quality:changed, andpnpm run build:electron-vitepass.Review
Self-reviewed IPC sender checks, window cleanup, scan synchronization, deletion safety, host routing, and cross-platform path behavior. The Space publisher stops watching store updates when its window closes.
Agent skill upstream boundary
Notes
The window uses the existing Space scan and worktree removal services.
duoutput remains capped at 16 MiB and timed out after 120 seconds; portable traversal retains its entry budget. A live SSH host was not available for manual validation.Checklist
pnpm lint,pnpm test, andpnpm buildwill be covered by CI; local focused checks passed.