Repository navigation
fix(tasks): make mobile and desktop searches agree - #28580
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
6c3b2083-95e0-431f-95d9-955b63a1f78b
📒 Files selected for processing: 9
mobile/src/tasks/mobile-task-search.test.tsmobile/src/tasks/mobile-tasks-item-mapping.tsmobile/src/test-support/rpc-recording/operation-module-loader.test.tsmobile/src/test-support/rpc-recording/operation-module-loader.tssrc/renderer/src/components/task-page-github-task-kind.test.tssrc/renderer/src/components/task-page-github-task-kind.tssrc/shared/task-github-search.tssrc/shared/task-query.test.tssrc/shared/task-query.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.
ELI5
The same task search now means the same thing on your phone and desktop. Searching for pull requests no longer accidentally adds an issue filter on mobile.
What Changed
Mobile now uses the desktop's search rules and the shared preset map.
is:pull-request, draft, review, and merged searches select the PR tab. Actual scope qualifiers are recognized as tokens, so quoted phrases and label values stay search text. Old saved “All” settings still open Issues, matching the current desktop's separate tabs.Why
Two copies had drifted. Moving the existing desktop behavior into a shared module keeps both surfaces aligned without reviving the removed mixed tab. This follows the earlier parity work in #11121 by MumuTW, credited in the commit.
Linked Issue
Addresses the query portion of #10950. The Jira/provider portion is implemented separately; this PR alone should not close the issue.
Visual Proof
N/A — no screen layout or component changed. The changed behavior is search-string interpretation; regression tests exercise the mobile call site and the existing desktop call site.
Testing
The mobile recording loader now follows named reexports through the existing task barrel. Its prior failure was reproduced (20 failures across the focused recording/mutant suites); the full recording folder and mobile query cases pass1,783 tests plus3 existing skips. The named/aliased/type-only export regression passes. Explicit issue queries now override PR presets on both call sites; shared/desktop query tests pass77 checks. Current renderer/mobile product typechecks and nine-file changed-code quality pass after generating the mobile assets.
Regression tests failed on the base for
is:pull-requestand PR-only qualifiers, then passed after the change. Four mobile search tests and 76 shared/desktop tests pass. Mobile typecheck, desktop web typecheck, changed-code quality, and diff checks pass. The branch is updated to fixed main; CI should run full checks/build on the new head. No full app build or native-device test was run for this string-only change.Review
Merge risk: Low. The existing desktop search rules are reused. Token handling also corrects the shared parser's treatment of quoted phrases, so the regression suite checks both surfaces. No authentication, RPC parameters, paths, shortcuts, or dependencies change; macOS/Linux/Windows, SSH, and folder workspaces follow the same host search path.
Agent skill upstream boundary
Notes
Reference: #11121 (closed), author MumuTW. The mobile Jira integration is a separate PR.
Checklist