Repository navigation
Conversation
📝 WalkthroughWalkthroughGitHub task preset, scope, and kind-resolution logic is centralized in shared modules. Mobile task handling and renderer workspace code now use the shared helpers, while query parsing recognizes unquoted 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/shared/task-query.test.ts (1)
25-31: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd negative scope-detection cases.
These tests cover only valid explicit aliases. Add cases such as
"is:issue"andlabel:"is:issue"to ensure raw text is not mistaken for an explicit scope qualifier.mobile/src/tasks/mobile-github-task-query.test.ts (1)
15-21: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExercise the mobile parser, not only the shared helper.
This suite calls
scopeGitHubTaskSearchdirectly and does not exercise mobilegithubKindFromQueryat Line 907. A regression in mobileis:pull-requestrecognition would still pass; add a focused seam or integration test for that path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3073496c-fd98-4657-b680-4d84507fa9b3
📥 Commits
Reviewing files that changed from the base of the PR and between df9f559 and 8f2edd570b000d6affbf42c9819eb955296605eb.
📒 Files selected for processing (6)
mobile/app/h/[hostId]/tasks.tsxmobile/src/tasks/mobile-github-task-query.test.tssrc/renderer/src/components/TaskPage.tsxsrc/renderer/src/lib/new-workspace.tssrc/shared/task-query.test.tssrc/shared/task-query.ts
8f2edd5 to
48e6412
Compare
|
Closing this PR. I am not going to keep iterating contribution PRs here; if a report is useful I will file an issue instead. |
Summary
is:pull-requestalias and PR-only qualifiers consistently with desktop.allview normalized toissuesin mobile state while retaining exhaustive query mapping for persisted settings.Addresses the task-query parity portion of #10950. Mobile Jira/provider availability remains intentionally out of scope.
Screenshots
No visual change.
Testing
pnpm lintpnpm typecheckpnpm testpnpm buildTargeted validation:
oxlintandoxfmt --checkpassedgit diff --checkpassed after rebasing onto currentorigin/mainAI Review Report
The adversarial review compared desktop/mobile query behavior, persisted preset handling, provider boundaries, quoted search text, and the mobile picker options. It caught that an initial version could resurrect the removed
allview in mobile state despite no matching picker option. CodeRabbit later identified raw-regex scope detection that could misclassify quoted text; the final version uses one token-aware detector across shared and mobile code and directly tests the mobile kind resolver.Cross-platform compatibility was reviewed for macOS, Linux, and Windows. This change only transforms GitHub search strings and does not alter shortcuts, labels, paths, shells, or Electron-specific platform behavior.
Security Audit
No command execution, filesystem paths, authentication, secrets, dependencies, or IPC contracts changed. User-entered search text is still passed through the existing GitHub query path; the shared function only adds or preserves recognized scope qualifiers.
Notes
This PR does not add Jira to mobile and does not remove
mobile-task-providers.ts.