[brennanb2025]

	Files	Added	Deleted	Net
Test	2	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​81	$\color{#cf222e}{\Huge{\mathbf{−}}}$​21	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​60
Prod	0	0	0	0

ELI5

Two tests on main went red after #25418 added Spanish, French, Japanese, Korean and Chinese translations. Both tests had borrowed a real string that wasn't translated yet, to stand in for "a string with no translation". Once the translations landed, the stand-in strings were translated and the tests failed, even though the app was working correctly. This PR gives the tests a made-up language catalog that never has those strings, so the next translation can't break them again.

What Changed

What broke on main. Since e02adc5320b (#25418, "Add translations for terminal shell settings"), six tests fail on main and on every PR that merges main:

• NativeChatSupportedAgents.test.tsx, "renders the English fallback when the active locale lacks the label key". The test switched to Spanish and first checked that Spanish has no "Supported agents:" label. Add translations for terminal shell settings #25418 added that label to the Spanish catalog, so the check fails.
• source-control-discard-localization.test.ts, "uses current index-preserving descriptions in es/fr/ja/ko/zh". fix(git): reduce queries and preserve data across execution hosts #24602 changed the wording of the discard confirmation, because discarding now keeps your staged changes. It moved the text to new keys that existed only in English. This test then expected the English text in every language, so no language could still show the old, wrong wording ("revert all changes", "restore the file from HEAD"). Add translations for terminal shell settings #25418 translated the new keys correctly, so the test now gets real translations instead of English.

I checked that e02adc5320b is the cause: its parent d279adc6efd passes all 12 tests in these two files, and e02adc5320b fails the same 6.

The fix. Both tests now use the plugin language pack mechanism to load a small catalog they write themselves, then switch the app to that language. Other tests already load catalogs this way, for example lazy-locale.test.ts.

• Supported agents: the made-up catalog doesn't contain the label, so the test still checks that a missing label falls back to "Supported agents:".
• Discard confirmation: the made-up catalog contains only the old wording, under the old keys. The test checks that the dialog still shows the current English wording. So a catalog that was never updated can't bring back the old text.
• Discard confirmation, shipped languages: for each shipped language (en, es, fr, ja, ko, zh), the test now checks that the dialog never shows that language's old-wording translation. Every catalog still holds that old translation, so this check is real in every language.

What users see. Nothing changes. This PR changes tests only.

Why

These tests are about what happens when a string has no translation. A real string that happens to be untranslated today becomes translated as soon as someone translates it, which is exactly what #25418 did. A catalog the test writes itself stays without the string for good. Pointing the tests at another real string that is untranslated today would break again with the next translation PR.

The discard test was really guarding against the old wording coming back, not testing the English fallback. So it keeps that purpose: against the shipped catalogs it now checks "not the old wording" instead of "exactly English".

Linked Issue

None. This fixes main's red tests from #25418.

Visual Proof

N/A. Test-only change; nothing a user sees changes.

Testing

• I manually tested these changes locally

• Automated tests added/updated, or explained why not below

• The two files pass on current main (2b0ce175145) with this change: 13 passed.

• Without this change, the same two files fail on current main: 6 failed, 6 passed.

• Ablations:

  • With the supported-agents label added to the made-up catalog, the fallback test fails.
  • With the discard dialog pointed back at the old wording's keys, all 7 discard tests fail.

• Web typecheck, oxlint and oxfmt on both files, and the changed-code quality gate pass.

AI Disclosure

Review

Agent skill upstream boundary

• Not applicable, or this change follows docs/reference/agent-skill-sharing-upstream-boundary.md and copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Test-only. No product code, catalogs or wire changes, so nothing changes for security, platforms, SSH, mobile, compatibility or performance.

Checklist

• This PR is small and focused
• I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
• Before/after screenshots or videos attached for UI changes, or N/A with reason
• Self-reviewed for correctness, security, and performance
• Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
• pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

[brennanb2025]

Superseded by e46fa0d (#10241) on main, which fixed these two tests by asserting the current translations. This PR took a different route: a made-up language pack for the English-fallback test, and an old-wording guard across every shipped language for the discard test. That would survive the next translation change, but it isn't worth a competing PR, so I'm closing this one. If the tests break again on a future translation update, this branch's approach is the one to reuse.