[AmethystLiang]

	Files	Added	Deleted	Net
Test	0	0	0	0
Prod	10	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​4853	$\color{#cf222e}{\Huge{\mathbf{−}}}$​646	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​4207

Problem

Terminal shell configuration UI—labels, descriptions, and search keywords—was displayed only in English, even when Orca is set to other languages.

Solution

Wrapped terminal shell setting strings in the translation system and added corresponding translation keys for Spanish, French, Japanese, Korean, and Simplified Chinese. Updated localization allowlist to reflect the new translatable content.

Why

Follows the existing i18n pattern used throughout the codebase. Ensures users in non-English locales see shell settings in their language, matching the rest of the UI.

Testing

• Verified terminal shell settings display correctly in each supported language
• Confirmed search keywords for shell settings work in translated text
• pnpm lint passes (localization allowlist updated)

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (1)

AGENTS.md — auto-discovered

📝 Walkthrough

Walkthrough

Terminal shell settings and their search entry now use translation helpers, with related locale strings and localization coverage entries updated. French, Japanese, Korean, and Chinese locale files also add interface strings for providers, settings, terminal workflows, credentials, editing, recovery, and session handling. Chinese locale entries revise several translations for agent and child terminology. Shell selection, validation, and argument behavior remain unchanged.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 9ebd8

Users of affected languages may see incorrect settings text or need to find the Codex reversal command elsewhere. The changes are mergeable with these localized fixes or an explicit follow-up.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description explains the problem, solution, and reason, but it leaves required information incomplete: the linked issue is blank, no before-and-after visual proof or N/A explanation is provided fo…	Add the linked issue, attach before-and-after visual proof or state N/A with a reason if there is no visual or interaction change, and provide the testing steps and platforms used. Update the test checkboxes to reflect the actual verificati…
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (7 skipped: 7 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding translations for terminal shell settings.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, solution, and reason, but it leaves required information incomplete: the linked issue is blank, no before-and-after visual proof or N/A explanation is provided for the UI change, and the testing section lists unchecked items instead of verification steps and platforms.

Resolution

Add the linked issue, attach before-and-after visual proof or state N/A with a reason if there is no visual or interaction change, and provide the testing steps and platforms used. Update the test checkboxes to reflect the actual verification status.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (7 skipped: 7 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 7

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 1dca0fb1-22fa-41a4-94d9-211cb671aa86

📥 Commits

Reviewing files that changed from the base of the PR and between f873aaa and 9ebd8066a912ae7749e3786809b87a22b194ac02.

📒 Files selected for processing (10)

• config/localization-audit.md
• config/localization-coverage-allowlist.json
• src/renderer/src/components/settings/TerminalPane.tsx
• src/renderer/src/components/settings/terminal-search.ts
• src/renderer/src/i18n/locales/en.json
• src/renderer/src/i18n/locales/es.json
• src/renderer/src/i18n/locales/fr.json
• src/renderer/src/i18n/locales/ja.json
• src/renderer/src/i18n/locales/ko.json
• src/renderer/src/i18n/locales/zh.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

[pullfrog]

ℹ️ No critical issues — minor suggestions only.

Reviewed changes

• Terminal shell settings localized — TerminalPane.tsx now wraps its title, description, segmented-control labels, input placeholder/aria labels, validation error, help text, and the settings-search title/description/keywords in translate(...) / translateSearchKeyword(...); terminal-search.ts does the same for the pane search entry. The old allowlisted raw strings are correspondingly removed.
• Catalog additions — 31 auto.components.settings.TerminalPane.* and 12 auto.components.settings.terminal.search.* keys added to en.json, plus translations in all five target locales. es.json also carries a ~3700-line Spanish backfill and fr/ja/ko/zh ~300 lines each of unrelated backlog (zcode usage, Codex server isolation, phone session, freebuff/qoder/jcode/dsh labels) from the recurring config/update-translation.txt scan — broader than the title implies.
• Allowlist + audit doc — localization-coverage-allowlist.json trimmed to 11 entries and the count prose in config/localization-audit.md updated to match.

I ran the four localization gates against the branch: verify-localization-catalogs (all five locales 15187/15187, 0 missing), audit-localization-coverage --check, verify-localization-extraction, and a flattened key/placeholder parity check across locales — all pass, and every JSON parses.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}