Repository navigation
test(mobile): repin the recording corpus to main's tip after the page safe-area and polish PRs - #22576
Merged
Conversation
#22570 pinned its own branch commit, which the squash left off main; the corpus now pins main at 37820f9, the tree its fenced paths match. Every golden changes only its baseline line. Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Corpus-wide repin — all 787 goldens under
mobile/rpc-foundation/goldens/pluspilot-scenarios.jsonchange exactly one line: thebaselineheader from996f9cc3068c…to37820f9683527becf68d8d4d4fb564f32c49e72d. Collapsing every added/removed line confirms it — 788 additions all equal the new line, 788 deletions all equal the old, nothing else moved. - Pin names a real, reachable tree —
37820f9683ismain's tip at review time (#22570) and the sole parent of the single repin commit, so the guard'sancestrycheck holds. No file elsewhere in the repo references either sha. - Reproduction still owns the verdict —
mobile/srcis a fenced path, so the guard'sreproduce --if-changed-sincejob checks out the new pin, overlays this tree's recorder, and replays the corpus in CI. Because it runs on every corpus provenance change, passing it is what certifies a header-only repin like this one;README.mdstep 4 predicts exactly this "header-only" shape.
DeepSeek Flash (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The four page PRs that landed today (#22549, #22556, #22569, #22570) changed fenced paths (
mobile/src,mobile/app) without touching the recording corpus. The corpus still reproduces byte-identically from the old pin (the pin guard'sreproducejob stayed green on every one of them and main's ancestry check is green), but the recorder refuses--recordwhile the fenced tree differs from itsbaseline, so no new scenario can be recorded until the pin moves. This repins the corpus to main's tip 37820f9. Every golden changes only itsbaselineline (788 files, two distinct changed lines after masking the sha); recorded fresh with--record(148 s), and the recorder's own ancestry and reproduce checks pass from the pinned tree. Same shape as #22407 after #22381.